Page MenuHomePhabricator

Consolidate ParamValidator messages in one file
Open, MediumPublicBUG REPORT

Description

I see some messages with paramvalidator in their keys in languages/i18n/en.json, and I also see some in includes/libs/ParamValidator/i18n/en.json.

Is there a good reason to have them in those two places, or can they perhaps all be in includes/libs/ParamValidator/i18n/en.json?

My hunch is that they all belong in one place, but correct me if I'm wrong.

Or maybe they should move from languages/i18n/en.json to includes/api/i18n/en.json. People who know ParamValidator well should decide.

Details

Event Timeline

Change #1016845 had a related patch set uploaded (by Amire80; author: Amire80):

[mediawiki/core@master] Consolidate ParamValidator messages in one file

https://gerrit.wikimedia.org/r/1016845

MaryMunyoki triaged this task as Medium priority.Apr 8 2025, 5:58 PM
MaryMunyoki subscribed.

removing tag as this is not in Q1 priorities (July 2025- Sep 2025), might need to revisit later

Generally with includes/libs the assumption is that each directory will eventually be spun out into a standalone library (at which point it needs separate i18n files).

Generally with includes/libs the assumption is that each directory will eventually be spun out into a standalone library (at which point it needs separate i18n files).

In this particular case, T382170: Create separate ParamValidator library. The i18n hasn't yet been moved to the library repo (which also isn't yet published and used).