Page MenuHomePhabricator

🦮 Modal Accessibility Improvements
Closed, ResolvedPublic3 Estimated Story Points

Description

Currently when modals appear they're not focusable. The page behind them can also be still navigated.

They most likely need to tell the page that live content is appearing with aria-live and do some focus management.

There are two modals reachable from the donation confirmation page:

  • address update
  • donation comments

Implementation Notes

Event Timeline

Tanuja_Doriya renamed this task from Modal Accessibility Improvements to 🦮 Modal Accessibility Improvements.Apr 8 2024, 2:35 PM
Tanuja_Doriya claimed this task.
Tanuja_Doriya moved this task from Todo to Doing on the WMDE-FUN-Sprint-2024-02-27 board.
kai.nissen set the point value for this task to 8.
kai.nissen changed the point value for this task from 8 to 3.
AbbanWMDE removed AbbanWMDE as the assignee of this task.EditedMay 21 2024, 3:01 PM
AbbanWMDE moved this task from Doing to Review on the WMDE-FUN-Sprint-2024-05-21 board.

I discovered the native HTML Dialog works well now so I implemented that.

PR: https://github.com/wmde/fundraising-app-frontend/pull/400

Deployed here: test-spenden-2.wikimedia.de