Page MenuHomePhabricator

Support Wordpress 6.5
Closed, ResolvedPublic

Description

Test Wikipedia Preview Wordpress plugin again Wordpress 6.5 and adjust tested up to field accordingly.

QA Results - Beta

ACStatusDetails
1T361827#9750094

Event Timeline

SBisson triaged this task as Medium priority.Apr 5 2024, 4:56 PM

@hueitan WordPress 6.5 seems to be fine for the most part during regression testing but I did come across a few issues below if you can review, thanks!

Status: ❌FAIL
Environment: WordPress Dev- 6.5; Wikipreview: 1.12.0; Commit: 72f4c09a097ddeb58e96d82e411a53cb43c77a10, Fri Apr 5 12:38:09 2024 -0400
OS: macOS Sonoma 14.2
Browser: Chrome 123, Firefox 124, Safari 17.4
Skins. N/A
Device: MBA M2
Emulated Device:: n/a
Test Links:
http://dev-test.local/philadelphia-eagles-test/

✅AC1: https://phabricator.wikimedia.org/T361827

2023-12-13_11-25-22.mp4.gif (1×2 px, 2 MB)

❌Issues

  1. Change icon- Did not change to the new link. Also, why would "association" jump to a different line when the first Wikipedia preview link didn't move at all?

  1. Change Icon- Also when I click on the Change Icon, it jumps to the beginning of the paragraph.

a. I just selected the word "association"
b. Click Wikipedia Preview icon and selected "Association Football"
c. Wikipedia preview pops up for Association Football and I selected the "Change" icon
d. It then jumps to the beginning of the paragraph with Wikipedia preview popup and typed in "Dog Breed"

  1. Read more on Wikipedia- This is more of a design question but do you think this is hard to read since the lettering is dark?

2024-04-23_11-22-12.png (989×1 px, 183 KB)

  1. Language- What is this supposed to do since it didn't do anything?

@hueitan Issues 1 and 2 are covered in the task I created in T363600: Wikipedia Preview Change icon adding a new preview set. Issue #3, @SGautam_WMF is aware of. The last issue is out of scope which we can ignore. Other than that, it looks good to go to move to Design sign-off. Thanks for all your work!

Status: ✅ Pass
Environment: WordPress Dev- 6.5; Wikipreview: 1.12.0; Commit: 72f4c09a097ddeb58e96d82e411a53cb43c77a10, Fri Apr 5 12:38:09 2024 -0400
OS: macOS Sonoma 14.2
Browser: Chrome 123
Skins. N/A
Device: MBA M2
Emulated Device:: n/a
Test Links:
http://dev-test.local/wp-admin/post.php?post=27&action=edit

✅AC1: https://phabricator.wikimedia.org/T361827

GMikesell-WMF updated the task description. (Show Details)
GMikesell-WMF moved this task from QA to Design sign off on the Inuka-Team (Kanban) board.