Page MenuHomePhabricator

Update less.php in 1.39
Closed, ResolvedPublic

Description

22:38:59 28) ResourcesTest::testResourceFiles
22:38:59 Creation of dynamic property Less_Tree_Variable::$parensInOp is deprecated
22:38:59 
22:38:59 /workspace/src/vendor/wikimedia/less.php/lib/Less/Parser.php:2313
22:38:59 /workspace/src/vendor/wikimedia/less.php/lib/Less/Parser.php:2328
22:38:59 /workspace/src/vendor/wikimedia/less.php/lib/Less/Parser.php:808
22:38:59 /workspace/src/vendor/wikimedia/less.php/lib/Less/Parser.php:2450
22:38:59 /workspace/src/vendor/wikimedia/less.php/lib/Less/Parser.php:808
22:38:59 /workspace/src/vendor/wikimedia/less.php/lib/Less/Parser.php:1159
22:38:59 /workspace/src/vendor/wikimedia/less.php/lib/Less/Parser.php:1140
22:38:59 /workspace/src/vendor/wikimedia/less.php/lib/Less/Parser.php:808
22:38:59 /workspace/src/vendor/wikimedia/less.php/lib/Less/Parser.php:2427
22:38:59 /workspace/src/vendor/wikimedia/less.php/lib/Less/Parser.php:2290
22:38:59 /workspace/src/vendor/wikimedia/less.php/lib/Less/Parser.php:2328
22:38:59 /workspace/src/vendor/wikimedia/less.php/lib/Less/Parser.php:808
22:38:59 /workspace/src/vendor/wikimedia/less.php/lib/Less/Parser.php:2450
22:38:59 /workspace/src/vendor/wikimedia/less.php/lib/Less/Parser.php:808
22:38:59 /workspace/src/vendor/wikimedia/less.php/lib/Less/Parser.php:1159
22:38:59 /workspace/src/vendor/wikimedia/less.php/lib/Less/Parser.php:1140
22:38:59 /workspace/src/vendor/wikimedia/less.php/lib/Less/Parser.php:808
22:38:59 /workspace/src/vendor/wikimedia/less.php/lib/Less/Parser.php:2427
22:38:59 /workspace/src/vendor/wikimedia/less.php/lib/Less/Parser.php:2290
22:38:59 /workspace/src/vendor/wikimedia/less.php/lib/Less/Parser.php:2328
22:38:59 /workspace/src/vendor/wikimedia/less.php/lib/Less/Parser.php:808
22:38:59 /workspace/src/vendor/wikimedia/less.php/lib/Less/Parser.php:2450
22:38:59 /workspace/src/vendor/wikimedia/less.php/lib/Less/Parser.php:2254
22:38:59 /workspace/src/vendor/wikimedia/less.php/lib/Less/Parser.php:808
22:38:59 /workspace/src/vendor/wikimedia/less.php/lib/Less/Parser.php:1966
22:38:59 /workspace/src/vendor/wikimedia/less.php/lib/Less/Parser.php:808
22:38:59 /workspace/src/vendor/wikimedia/less.php/lib/Less/Parser.php:954
22:38:59 /workspace/src/vendor/wikimedia/less.php/lib/Less/Parser.php:1843
22:38:59 /workspace/src/vendor/wikimedia/less.php/lib/Less/Parser.php:1897
22:38:59 /workspace/src/vendor/wikimedia/less.php/lib/Less/Parser.php:808
22:38:59 /workspace/src/vendor/wikimedia/less.php/lib/Less/Parser.php:954
22:38:59 /workspace/src/vendor/wikimedia/less.php/lib/Less/Parser.php:1843
22:38:59 /workspace/src/vendor/wikimedia/less.php/lib/Less/Parser.php:1897
22:38:59 /workspace/src/vendor/wikimedia/less.php/lib/Less/Parser.php:808
22:38:59 /workspace/src/vendor/wikimedia/less.php/lib/Less/Parser.php:954
22:38:59 /workspace/src/vendor/wikimedia/less.php/lib/Less/Parser.php:635
22:38:59 /workspace/src/vendor/wikimedia/less.php/lib/Less/Parser.php:585
22:38:59 /workspace/src/vendor/wikimedia/less.php/lib/Less/Parser.php:426
22:38:59 /workspace/src/includes/ResourceLoader/FileModule.php:1127
22:38:59 /workspace/src/includes/ResourceLoader/FileModule.php:1010
22:38:59 /workspace/src/includes/ResourceLoader/FileModule.php:986
22:38:59 /workspace/src/includes/ResourceLoader/FileModule.php:964
22:38:59 /workspace/src/vendor/wikimedia/testing-access-wrapper/src/TestingAccessWrapper.php:114
22:38:59 /workspace/src/tests/phpunit/structure/ResourcesTest.php:297
22:38:59 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:500
22:38:59 /workspace/src/tests/phpunit/phpunit.php:101
22:38:59 /workspace/src/tests/phpunit/phpunit.php:153

https://github.com/wikimedia/less.php/commit/a93b0827b650a347f7c694e1e234f8c86efa8812 seemingly fixed this... Which is in v3.2.0 and v3.2.1...

1.39 currently has v3.1.0.

https://github.com/wikimedia/less.php/compare/v3.1.0...v3.2.1

rMWa3d487b9d718: Upgrading wikimedia/less.php (v3.1.0 => v3.2.0)
rMWafbb8690d54f: ResourceLoader: Update wikimedia/less.php to v3.2.1

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

This'd potentially be quite a difficult to debug breaking change for downstream extensions to suddenly appear in a branch. Is it worth it?

This'd potentially be quite a difficult to debug breaking change for downstream extensions to suddenly appear in a branch. Is it worth it?

There doesn't seem to be any obvious breaking changes, especially if we only go to 3.2.1:

## 3.2.1

* Tree_Ruleset: Fix support for nested parent selectors (Timo Tijhof) [T204816](https://phabricator.wikimedia.org/T204816)
* Fix ParseError when interpolating variable after colon in selector (Timo Tijhof) [T327163](https://phabricator.wikimedia.org/T327163)
* Functions: Fix "Undefined property" warning on bad minmax arg
* Tree_Call: Include previous exception when catching functions (Robert Frunzke)

## 3.2.0

* Fix "Implicit conversion" PHP 8.1 warnings (Ayokunle Odusan)
* Fix "Creation of dynamic property" PHP 8.2 warnings (Bas Couwenberg)
* Fix "Creation of dynamic property" PHP 8.2 warnings (Rajesh Kumar)
* Tree_Url: Add support for "Url" type to `Parser::getVariables()` (ciroarcadio) [#51](https://github.com/wikimedia/less.php/pull/51)
* Tree_Import: Add support for importing URLs without file extension (Timo Tijhof) [#27](https://github.com/wikimedia/less.php/issues/27)

4.0.0 would be ok (but unnecessary), as it's mostly dropping old PHP.. 4.2.0 starts to change other stuff to match upstream less.js changes

Change #1017416 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/vendor@REL1_39] composer.json: Update wikimedia/less.php from 3.1.0 to 3.2.1

https://gerrit.wikimedia.org/r/1017416

Change #1017417 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@REL1_39] Update wikimedia/less.php from 3.1.0 to 3.2.1

https://gerrit.wikimedia.org/r/1017417

The two patches here are the last pieces needed to get clean tests of 1.39 on PHP 8.2 and PHP 8.3...

https://integration.wikimedia.org/ci/job/mediawiki-quibble-vendor-mysql-php82/34/console
https://integration.wikimedia.org/ci/job/mediawiki-quibble-vendor-mysql-php83/34/console

The state of extensions (and more specifically, bundled ones), I'm not sure.

Change #1017416 merged by Reedy:

[mediawiki/vendor@REL1_39] composer.json: Update wikimedia/less.php from 3.1.0 to 3.2.1

https://gerrit.wikimedia.org/r/1017416

Change #1017417 merged by jenkins-bot:

[mediawiki/core@REL1_39] Update wikimedia/less.php from 3.1.0 to 3.2.1

https://gerrit.wikimedia.org/r/1017417

Reedy claimed this task.
Reedy removed a project: Patch-For-Review.