Page MenuHomePhabricator
Create Task
Maniphest T361985

MW 1.39/1.40/1.41 core fixes needed for PHP 8.2/8.3
Closed, ResolvedPublic
Actions

Description

00:01:08 1) ApiEditPageTest::testEditAbortedByEditPageHookWithResult
00:01:08 Creation of dynamic property MediaWiki\Status\Status::$apiHookResult is deprecated
00:01:08 
00:01:08 /workspace/src/includes/Status/Status.php:123
00:01:08 /workspace/src/tests/phpunit/includes/api/ApiEditPageTest.php:1565
00:01:08 /workspace/src/includes/HookContainer/HookContainer.php:161
00:01:08 /workspace/src/includes/HookContainer/HookRunner.php:1470
00:01:08 /workspace/src/includes/editpage/Constraint/EditFilterMergedContentHookConstraint.php:100
00:01:08 /workspace/src/includes/editpage/Constraint/EditConstraintRunner.php:88
00:01:08 /workspace/src/includes/editpage/EditPage.php:2237
00:01:08 /workspace/src/includes/editpage/EditPage.php:1800
00:01:08 /workspace/src/includes/api/ApiEditPage.php:533
00:01:08 /workspace/src/includes/api/ApiMain.php:1935
00:01:08 /workspace/src/includes/api/ApiMain.php:881
00:01:08 /workspace/src/tests/phpunit/includes/api/ApiTestCase.php:169
00:01:08 /workspace/src/tests/phpunit/includes/api/ApiTestCase.php:209
00:01:08 /workspace/src/tests/phpunit/includes/api/ApiEditPageTest.php:1569
00:01:08 /workspace/src/tests/phpunit/includes/api/ApiTestCase.php:322
00:22:35 2) WikiPageDbTest::testPrepareContentForEdit
00:22:35 Creation of dynamic property MediaWiki\Edit\PreparedEdit::$timestamp is deprecated
00:22:35 
00:22:35 /workspace/src/tests/phpunit/includes/page/WikiPageDbTest.php:1949
00:22:35 /workspace/src/tests/phpunit/includes/page/WikiPageDbTest.php:201

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Zuul: [mediawiki/core] Make PHP 8.2 and 8.3 voting for REL1_39–41integration/configmaster+6 -0
StatusValue: Allow passing arbitrary data to augment resultmediawiki/coreREL1_39+14 -3
StatusValue: Allow passing arbitrary data to augment resultmediawiki/coreREL1_40+14 -3
StatusValue: Allow passing arbitrary data to augment resultmediawiki/coreREL1_41+14 -3
Customize query in gerrit

Related Objects

Event Timeline

Reedy created this task.Apr 5 2024, 11:15 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 5 2024, 11:15 PM
Reedy updated the task description. (Show Details)Apr 5 2024, 11:20 PM
Reedy updated the task description. (Show Details)Apr 5 2024, 11:22 PM
Reedy updated the task description. (Show Details)Apr 5 2024, 11:26 PM
gerritbot added a comment.Apr 5 2024, 11:29 PM

Change #1017428 had a related patch set uploaded (by Reedy; author: Ammarpad):

[mediawiki/core@REL1_41] StatusValue: Allow passing arbitrary data to augment result

https://gerrit.wikimedia.org/r/1017428

gerritbot added a project: Patch-For-Review.Apr 5 2024, 11:29 PM
Reedy updated the task description. (Show Details)Apr 5 2024, 11:45 PM
Reedy renamed this task from MW 1.41 fixes needed for PHP 8.2/8.3 to MW 1.41 core fixes needed for PHP 8.2/8.3.Apr 5 2024, 11:59 PM
gerritbot added a comment.Apr 6 2024, 12:25 AM

Change #1017428 merged by jenkins-bot:

[mediawiki/core@REL1_41] StatusValue: Allow passing arbitrary data to augment result

https://gerrit.wikimedia.org/r/1017428

Reedy renamed this task from MW 1.41 core fixes needed for PHP 8.2/8.3 to MW 1.40/1.41 core fixes needed for PHP 8.2/8.3.Apr 6 2024, 12:42 AM
Reedy added a project: MW-1.40-release.
gerritbot added a comment.Apr 6 2024, 12:58 AM

Change #1017442 had a related patch set uploaded (by Reedy; author: Ammarpad):

[mediawiki/core@REL1_40] StatusValue: Allow passing arbitrary data to augment result

https://gerrit.wikimedia.org/r/1017442

ReleaseTaggerBot added a project: MW-1.41-notes.Apr 6 2024, 1:00 AM
gerritbot added a comment.Apr 6 2024, 1:21 AM

Change #1017442 merged by jenkins-bot:

[mediawiki/core@REL1_40] StatusValue: Allow passing arbitrary data to augment result

https://gerrit.wikimedia.org/r/1017442

Reedy closed this task as Resolved.Apr 6 2024, 1:21 AM
Reedy claimed this task.

Passing for MW core on 1.40 and 1.41 on PHP 8.2 and 8.3. Wheeeee.

Extensions are a different beast... Maybe.

gerritbot added a comment.Apr 6 2024, 1:22 AM

Change #1017445 had a related patch set uploaded (by Reedy; author: Ammarpad):

[mediawiki/core@REL1_39] StatusValue: Allow passing arbitrary data to augment result

https://gerrit.wikimedia.org/r/1017445

gerritbot added a comment.Apr 6 2024, 1:35 AM

Change #1017445 merged by jenkins-bot:

[mediawiki/core@REL1_39] StatusValue: Allow passing arbitrary data to augment result

https://gerrit.wikimedia.org/r/1017445

ReleaseTaggerBot added projects: MW-1.39-notes, MW-1.40-notes.Apr 6 2024, 2:00 AM
Reedy renamed this task from MW 1.40/1.41 core fixes needed for PHP 8.2/8.3 to MW 1.39/1.40/1.41 core fixes needed for PHP 8.2/8.3.Apr 6 2024, 3:08 AM
Reedy edited projects, added MW-1.39-release; removed Patch-For-Review.
Reedy updated the task description. (Show Details)
gerritbot added a comment.Apr 8 2024, 1:53 PM

Change #1017869 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] Zuul: [mediawiki/core] Make PHP 8.2 and 8.3 voting for REL1_39–41

https://gerrit.wikimedia.org/r/1017869

gerritbot added a project: Patch-For-Review.Apr 8 2024, 1:53 PM
gerritbot added a comment.Apr 8 2024, 2:16 PM

Change #1017869 merged by jenkins-bot:

[integration/config@master] Zuul: [mediawiki/core] Make PHP 8.2 and 8.3 voting for REL1_39–41

https://gerrit.wikimedia.org/r/1017869

Stashbot added a comment.Apr 8 2024, 2:16 PM

Mentioned in SAL (#wikimedia-releng) [2024-04-08T14:16:51Z] <James_F> Zuul: [mediawiki/core] Make PHP 8.2 and 8.3 voting for REL1_39–41 T361985

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits