Maniphest T361988

Adding multiple maintenance tags to page with one maintenance tag and no {{Multiple issues}} should place old tag inside {{Multiple issues}}
Open, Needs TriagePublicBUG REPORT
Actions

Assigned To

Authored By

	Novem_Linguae
	Apr 6 2024, 12:10 AM

Project Tags

Referenced Files

	F44733125: image.png
	Apr 6 2024, 12:10 AM

	F44733085: image.png
	Apr 6 2024, 12:10 AM

Subscribers

Aklapper

ClaudineChionh

Monkeysmashingkeyboards

MPGuy2824

Novem_Linguae

Soda

Description

Steps to replicate the issue (include links if applicable):

Log out
Create a page with wikitext {{Disputed}} (one maintenance tag)
Log in
Visit page
Page curation toolbar -> maintenance tags -> tag it with two random tags such as {{Advert}} and {{All plot}}`

What happens?:

What should have happened instead?:

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

related but not the same: T323883: Adding maintenance tag to page with {{Multiple issues}} should place new tag inside {{Multiple issues}}

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	toolbar: include previous tags in the new wrapper when adding new tags	Apehitkey	mediawiki/extensions/PageTriage	master	+721 -44
	toolbar: include previous tags in the new wrapper when adding new tags	Apehitkey	mediawiki/extensions/PageTriage	master	+721 -44

Customize query in gerrit

Related Objects

Mentioned In: T353437: Maintenance tagging an article adds an unnecessary line break between top and template
Mentioned Here: T323883: Adding maintenance tag to page with {{Multiple issues}} should place new tag inside {{Multiple issues}}

Event Timeline

Novem_Linguae created this task.Apr 6 2024, 12:10 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 6 2024, 12:10 AM

Novem_Linguae moved this task from Backlog to Tagging wikicode bugs on the PageTriage board.Apr 6 2024, 12:10 AM

Novem_Linguae mentioned this in T353437: Maintenance tagging an article adds an unnecessary line break between top and template.

@Novem_Linguae How does twinkle handle this case ?

Twinkle's maintenance tag code is pretty convoluted. I wrote a patch for it once and I think I ended up abandoning it.

AFC Helper script has a ticket like this open for combining WikiProject banners. If I come up with a good approach for that, maybe I'll swing by and apply it here too.

The fact that Wikicode allows nested templates really complicates things. RegEx would be great for just one layer of templates, but starts falling apart once you nest templates.

A somewhat related use case: there is already (only) one maint tag in the article, and a reviewer is adding only one more, then both tags should be put inside a {{Multiple issues}} template.

Restricted Application added a project: Moderator-Tools-Team. · View Herald TranscriptOct 26 2025, 3:30 AM

ClaudineChionh subscribed.Oct 26 2025, 3:47 AM

Samwalton9-WMF moved this task from Inbox to Triaged on the Moderator-Tools-Team board.Nov 6 2025, 8:27 AM

I'm going to claim all the wikicode tagging bugs since I recently "rewrote" (stole Novem's code) the toolbar tagging logic. I will hopefully be done with all of them in at most a week.

Change #1338368 had a related patch set uploaded (by Apehitkey; author: Apehitkey):

[mediawiki/extensions/PageTriage@master] toolbar: include preexisting tags in the new {{multiple issues}} when adding new tags

https://gerrit.wikimedia.org/r/1338368

gerritbot added a project: Patch-For-Review.Thu, Sep 10, 1:45 AM

Monkeysmashingkeyboards moved this task from Triaged to Code review requests on the Moderator-Tools-Team board.Fri, Sep 11, 3:30 PM

Change #1341411 had a related patch set uploaded (by Apehitkey; author: Apehitkey):

[mediawiki/extensions/PageTriage@master] toolbar: include previous tags in the new wrapper when adding new tags

https://gerrit.wikimedia.org/r/1341411

Change #1338368 abandoned by Apehitkey: