Page MenuHomePhabricator

Editing keys on Z46 and Z64 does not work
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?: You get an error message "User does not have permission to edit"

What should have happened instead?: I guess functioneer and sysop rights should be enough to make these edits, so the edit should be safed.


Also reported on Project chat: https://www.wikifunctions.org/wiki/Wikifunctions:Project_chat#c-Jdforrester_(WMF)-20240802101700-Amire80-20240730123000

Event Timeline

I guess functioneer and sysop rights should be enough to make these edits, so the edit should be safed.

Sounds like your attempted edit triggered the wikilambda-edit-predefined right, which it shouldn't have, yes. (Sorry for the low-context error message; fixing that is T351583.)

Change #1017875 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] tests: Add authorisation test for adding a label to a built-in type

https://gerrit.wikimedia.org/r/1017875

I guess functioneer and sysop rights should be enough to make these edits, so the edit should be safed.

Sounds like your attempted edit triggered the wikilambda-edit-predefined right, which it shouldn't have, yes. (Sorry for the low-context error message; fixing that is T351583.)

@Ameisenigel: However, I've re-created (what I imagine is close to) your edit in our test suite, and it seems to pass: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikiLambda/+/1017875 – do you have any more information about the change you tried to make?

I guess functioneer and sysop rights should be enough to make these edits, so the edit should be safed.

Sounds like your attempted edit triggered the wikilambda-edit-predefined right, which it shouldn't have, yes. (Sorry for the low-context error message; fixing that is T351583.)

@Ameisenigel: However, I've re-created (what I imagine is close to) your edit in our test suite, and it seems to pass: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikiLambda/+/1017875 – do you have any more information about the change you tried to make?

For Z64 I tried to add the following German labels:

  • Z64K1: Identität
  • Z64K2: Typ
  • Z64K3: Umwandler
  • Z64K4: nativer Typ
Jdforrester-WMF changed the task status from Open to In Progress.Jun 17 2024, 8:22 PM
Jdforrester-WMF assigned this task to gengh.

I have now been able to add translated keys to Z46 and Z64.

I have now been able to add translated keys to Z46 and Z64.

Excellent!

This issue is the same as the one filed in https://phabricator.wikimedia.org/T374931

And was fixed with https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikiLambda/+/1073433

The issue is not related about the particular rights of key labels, but to the fact that the UI initializes keys Z4K4...Z4K8 when they are undefined, and those require functioneer rights. This has been fixed so that they are only initialized for people that can edit them.

Change #1017875 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] tests: Add authorisation test for adding a label to a built-in type, Z46

https://gerrit.wikimedia.org/r/1017875