Page MenuHomePhabricator

Deploy reading accessibility settings menu and new typography defaults to first set of wikis
Closed, ResolvedPublic2 Estimated Story Points

Description

Background

  • The new reading accessibility settings menu has now been available as a beta feature for three months and has performed as expected. This ticket will cover its deployment to first set of wikis for testing

User story

  • As a reader and editor of Wikipedia, I want the ability to change my typography, so that I have a more accessible experience and can read easier and quicker

Requirements

  • The standard type option is the default for all logged-out users
  • The small type option is the default for all logged-in users

BDD

Feature: Deploy Reading Accessibility Settings and New Typography Defaults

  Scenario: Default typography settings for logged-out users
    Given the user is logged out
    When the user views a page on betawiki, plwiki, eswiki, or nlwiki
    Then the default text size should be set to "Standard"

  Scenario: Default typography settings for logged-in users
    Given the user is logged in
    When the user views a page on betawiki, plwiki, eswiki, or nlwiki
    Then the default text size should be set to "Small"

Test Steps

Test Case 1: Default Typography Settings for Logged-Out Users

  1. Open Wikipedia on betawiki (for beta testing) or plwiki, eswiki, and nlwiki (for production testing) and log out if logged in.
  2. View a page.
  3. AC1: Confirm that the default text size is set to "Standard."

Test Case 2: Default Typography Settings for Logged-In Users

  1. Open Wikipedia on betawiki (for beta testing) or plwiki, eswiki, and nlwiki (for production testing) and log in.
  2. View a page.
  3. AC2: Confirm that the default text size is set to "Small."

Design

  • n/a

Acceptance criteria

Communication criteria - does this need an announcement or discussion?

  • Announcement before deployment
  • Announcement after deployment

QA Results - Beta

ACStatusDetails
1T362147#9797402
2T362147#9797402

Event Timeline

ovasileva triaged this task as High priority.

Discussed in grooming and both changes (enabling menu and changing font size) would need to ride the train.

Jdlrobson renamed this task from Deploy reading accessibility settings menu and new typogrpahy defaults to first set of wikis to Deploy reading accessibility settings menu and new typography defaults to first set of wikis.Apr 23 2024, 10:31 PM

This one is blocked on backporting a fix for T362808 as that task does not consider cached HTML.

@ovasileva we have a problem - we can't easily backport the patch to the deployment branch which means we'd need to manually rebase it against the master branch and deploy an untested mode of the site which is pretty risky and something we generally tend to avoid (though not possible).

Can this wait until Thursday 2nd?

@ovasileva we have a problem - we can't easily backport the patch to the deployment branch which means we'd need to manually rebase it against the master branch and deploy an untested mode of the site which is pretty risky and something we generally tend to avoid (though not possible).

Can this wait until Thursday 2nd?

If we can do both the backport and the deploy in time for the train Thursday, that makes sense to me.

Change #1025819 had a related patch set uploaded (by Kimberly Sarabia; author: Kimberly Sarabia):

[operations/mediawiki-config@master] Deploy a11y settings to testwiki

https://gerrit.wikimedia.org/r/1025819

Change #1025819 merged by jenkins-bot:

[operations/mediawiki-config@master] Deploy a11y settings to testwiki

https://gerrit.wikimedia.org/r/1025819

Mentioned in SAL (#wikimedia-operations) [2024-04-30T20:17:33Z] <cjming@deploy1002> Started scap: Backport for [[gerrit:1025819|Deploy a11y settings to testwiki (T362147)]]

Mentioned in SAL (#wikimedia-operations) [2024-04-30T20:20:21Z] <cjming@deploy1002> ksarabia and cjming: Backport for [[gerrit:1025819|Deploy a11y settings to testwiki (T362147)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-04-30T20:38:34Z] <cjming@deploy1002> Finished scap: Backport for [[gerrit:1025819|Deploy a11y settings to testwiki (T362147)]] (duration: 21m 00s)

Change #1025878 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Use new configuration for wmf.3

https://gerrit.wikimedia.org/r/1025878

After deploying the change to test wikipedia, the appearance menu is not showing on https://test.wikipedia.org/wiki/Zhang_Leping despite clearing the cache and I am seeing the vector-feature-appearance-disabled class on the HTML element. This is because we renamed the configuration variable too.

I would recommend spending Wednesday getting this working.

I explored adding a short term fix to site CSS. The following CSS could be added to https://pl.wikipedia.org/wiki/MediaWiki:Vector-2022.css in case of a rollback:

#vector-client-prefs-dropdown, #vector-client-prefs-pinned-container { display: none !important; }

However this would disable the menu for everyone including beta feature users (but I think that's fine)
@Jdrewniak I'll leave this decision on the technical side from you.

If possible and doing a Thursday deployment I would strongly recommend you arrange that @Mabualruz does this during the morning backport window to allow time to react to any big issues.

Otherwise a Monday deployment should be safe, provided you check that T361397 has been resolved before pushing ahead with the deployment.

Change #1025878 merged by jenkins-bot:

[operations/mediawiki-config@master] [Vector] Enable appearance menu and increased font-size on testwiki

https://gerrit.wikimedia.org/r/1025878

Mentioned in SAL (#wikimedia-operations) [2024-05-01T20:03:17Z] <jdrewniak@deploy1002> Started scap: Backport for [[gerrit:1025878|[Vector] Enable appearance menu and increased font-size on testwiki (T362147)]]

Mentioned in SAL (#wikimedia-operations) [2024-05-01T20:08:17Z] <jdrewniak@deploy1002> jdlrobson and jdrewniak: Backport for [[gerrit:1025878|[Vector] Enable appearance menu and increased font-size on testwiki (T362147)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-05-01T20:22:47Z] <jdrewniak@deploy1002> Finished scap: Backport for [[gerrit:1025878|[Vector] Enable appearance menu and increased font-size on testwiki (T362147)]] (duration: 19m 29s)

Change #1026663 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[operations/mediawiki-config@master] Deploy Vector appearance menu and increased font-size to plwiki

https://gerrit.wikimedia.org/r/1026663

Change #1026663 merged by jenkins-bot:

[operations/mediawiki-config@master] Deploy Vector appearance menu and increased font-size to plwiki

https://gerrit.wikimedia.org/r/1026663

Mentioned in SAL (#wikimedia-operations) [2024-05-02T20:09:49Z] <jdrewniak@deploy1002> Started scap: Backport for [[gerrit:1023928|Update wgVectorClientPrefs to wgVectorAppearance (T362808)]], [[gerrit:1026663|Deploy Vector appearance menu and increased font-size to plwiki (T362147)]]

Mentioned in SAL (#wikimedia-operations) [2024-05-02T20:14:27Z] <jdrewniak@deploy1002> bwang and jdrewniak: Backport for [[gerrit:1023928|Update wgVectorClientPrefs to wgVectorAppearance (T362808)]], [[gerrit:1026663|Deploy Vector appearance menu and increased font-size to plwiki (T362147)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

@Jdrewniak - adding eswiki and nlwiki to the list since they were scheduled for today.

Change #1028522 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[operations/mediawiki-config@master] [Vector 2022] Deploy larger font-size and appearance menu to pilot wikis

https://gerrit.wikimedia.org/r/1028522

Change #1028522 merged by jenkins-bot:

[operations/mediawiki-config@master] [Vector 2022] Deploy larger font-size and appearance menu to pilot wikis

https://gerrit.wikimedia.org/r/1028522

Mentioned in SAL (#wikimedia-operations) [2024-05-06T20:32:02Z] <jdrewniak@deploy1002> Started scap: Backport for [[gerrit:1028522|[Vector 2022] Deploy larger font-size and appearance menu to pilot wikis (T362147)]]

Mentioned in SAL (#wikimedia-operations) [2024-05-06T20:34:33Z] <jdrewniak@deploy1002> jdrewniak: Backport for [[gerrit:1028522|[Vector 2022] Deploy larger font-size and appearance menu to pilot wikis (T362147)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-05-06T20:47:13Z] <jdrewniak@deploy1002> Finished scap: Backport for [[gerrit:1028522|[Vector 2022] Deploy larger font-size and appearance menu to pilot wikis (T362147)]] (duration: 15m 10s)

Edtadros subscribed.

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Default Typography Settings for Logged-Out Users

  1. Open Wikipedia on betawiki (for beta testing) or plwiki, eswiki, and nlwiki (for production testing) and log out if logged in.
  2. View a page.
  3. AC1: Confirm that the default text size is set to "Standard."

screenshot 338.png (1×1 px, 375 KB)

Test Case 2: Default Typography Settings for Logged-In Users

  1. Open Wikipedia on betawiki (for beta testing) or plwiki, eswiki, and nlwiki (for production testing) and log in.
  2. View a page.
  3. AC2: Confirm that the default text size is set to "Small."

screenshot 339.png (1×1 px, 408 KB)

ovasileva claimed this task.