Page MenuHomePhabricator
Create Task
Maniphest T362251

Wikifunction parser tag: Trimming wikitext inputs means users can't use whitespace-only inputs, but not trimming them would break user inputs of wikitext
Closed, ResolvedPublic
Actions

Description

Currently we use array_map on Sanitizer::decodeCharReferences() to turn our passed $args into an array of $cleanedArgs. This is a mess, and possibly(?) loses information. We should consider if this is a problem, and if so, replace it with something better.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Don't trim arguments which are only whitespacesmediawiki/extensions/WikiLambdamaster+45 -16
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdforrester-WMF created this task.Apr 10 2024, 3:31 PM
Jdforrester-WMF triaged this task as Low priority.Apr 10 2024, 3:44 PM
Jdforrester-WMF moved this task from To Triage to Upcoming Epics on the Abstract Wikipedia team board.Apr 11 2024, 4:37 PM
Jdforrester-WMF added a parent task: T261472: [25Q1] Let users embed function calls in wikitext which are rendered in the output (for WF itself, not remote wikis).May 28 2024, 1:07 PM
Jdforrester-WMF moved this task from Upcoming Epics to 25Q1 (Jul–Sep) on the Abstract Wikipedia team board.Jun 27 2024, 9:59 AM
Jdforrester-WMF edited projects, added: Abstract Wikipedia team (25Q1 (Jul–Sep)); removed: Abstract Wikipedia team.
Jdforrester-WMF moved this task from Incoming to Ready, Features on the Abstract Wikipedia team (25Q1 (Jul–Sep)) board.
Jdforrester-WMF updated the task description. (Show Details)Jul 25 2024, 3:33 PM
Jdforrester-WMF moved this task from 25Q1 (Jul–Sep) to 25Q2 (Oct–Dec) on the Abstract Wikipedia team board.Oct 8 2024, 2:05 PM
Jdforrester-WMF edited projects, added: Abstract Wikipedia team (25Q2 (Oct–Dec)); removed: Abstract Wikipedia team (25Q1 (Jul–Sep)).
Jdforrester-WMF moved this task from Incoming to Ready, Features on the Abstract Wikipedia team (25Q2 (Oct–Dec)) board.Oct 8 2024, 2:09 PM
Jdforrester-WMF edited parent tasks, added: T376521: Enable one WF use case in a smaller language Wikipedia; removed: T261472: [25Q1] Let users embed function calls in wikitext which are rendered in the output (for WF itself, not remote wikis).Oct 16 2024, 4:42 PM
Jdforrester-WMF moved this task from 25Q2 (Oct–Dec) to 25Q3 (Jan–Mar) on the Abstract Wikipedia team board.Jan 15 2025, 5:30 PM
Jdforrester-WMF edited projects, added: Abstract Wikipedia team (25Q3 (Jan–Mar)); removed: Abstract Wikipedia team (25Q2 (Oct–Dec)).
Jdforrester-WMF moved this task from Incoming to In Engineering on the Abstract Wikipedia team (25Q3 (Jan–Mar)) board.
Jdforrester-WMF claimed this task.Jan 21 2025, 2:38 PM
DSantamaria changed the task status from Open to In Progress.Jan 31 2025, 11:58 AM
DSantamaria added a project: Wikifunctions integration.
Jdforrester-WMF changed the task status from In Progress to Open.Feb 13 2025, 5:53 PM
Jdforrester-WMF moved this task from In Engineering to Ready, Quarterly Work on the Abstract Wikipedia team (25Q3 (Jan–Mar)) board.
Jdforrester-WMF removed a parent task: T376521: Enable one WF use case in a smaller language Wikipedia.Mar 11 2025, 1:45 PM
Jdforrester-WMF removed a project: Wikifunctions integration.Mar 11 2025, 4:27 PM
Jdforrester-WMF unsubscribed.
Jdforrester-WMF edited projects, added: Abstract Wikipedia team; removed: Abstract Wikipedia team (25Q3 (Jan–Mar)).Mar 12 2025, 12:59 PM
Jdforrester-WMF renamed this task from Wikifunction parser tag: Expand $args properly to Wikifunction parser tag: Trimming wikitext inputs means users can't use whitespace-only inputs, but not trimming them would break user inputs of wikitext.Mar 12 2025, 4:32 PM
Jdforrester-WMF removed Jdforrester-WMF as the assignee of this task.
Jdforrester-WMF removed a project: Abstract Wikipedia Fix-It tasks.
Jdforrester-WMF moved this task from To Triage to Product Backlog on the Abstract Wikipedia team board.
Jdforrester-WMF subscribed.
gengh claimed this task.May 6 2025, 2:30 PM
gengh mentioned this in T391021: Implement default value replacement for Gregorian calendar date with today's date as per local client wiki timezone..
gerritbot added a comment.May 17 2025, 10:05 PM

Change #1147123 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] Don't trim arguments which are only whitespaces

https://gerrit.wikimedia.org/r/1147123

gerritbot added a project: Patch-For-Review.May 17 2025, 10:05 PM
gengh changed the task status from Open to In Progress.May 19 2025, 10:03 AM
gengh moved this task from Product Backlog to 25Q4 (Apr–Jun) on the Abstract Wikipedia team board.
gengh edited projects, added: Abstract Wikipedia team (25Q4 (Apr–Jun)); removed: Abstract Wikipedia team.
gengh moved this task from Incoming to In Engineering on the Abstract Wikipedia team (25Q4 (Apr–Jun)) board.
gengh moved this task from In Engineering to In Code review on the Abstract Wikipedia team (25Q4 (Apr–Jun)) board.
Jdforrester-WMF moved this task from In Code review to Ready to deploy on the Abstract Wikipedia team (25Q4 (Apr–Jun)) board.May 19 2025, 3:44 PM
gerritbot added a comment.May 19 2025, 4:23 PM

Change #1147123 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Don't trim arguments which are only whitespaces

https://gerrit.wikimedia.org/r/1147123

Maintenance_bot removed a project: Patch-For-Review.May 19 2025, 4:31 PM
ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.2; 2025-05-20).May 19 2025, 5:00 PM
DSantamaria subscribed.EditedMay 20 2025, 1:08 PM

Hi @Jdforrester-WMF @gengh
Just for my understanding, this is not OKR-Work nor Essential-Work, and not a Bug or Production error. Why did it jump on our quarter?

Jdforrester-WMF added a comment.May 20 2025, 6:35 PM

It's OKR work, but wasn't tagged as such.

Jdforrester-WMF added a parent task: T391021: Implement default value replacement for Gregorian calendar date with today's date as per local client wiki timezone..May 20 2025, 6:35 PM
Jdforrester-WMF added a project: OKR-Work.
Jdforrester-WMF moved this task from Ready to deploy to Needs Sign-off on the Abstract Wikipedia team (25Q4 (Apr–Jun)) board.May 21 2025, 12:53 PM
Jdforrester-WMF closed this task as Resolved.May 21 2025, 12:56 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits