Page MenuHomePhabricator
Create Task
Maniphest T362256

Wikifunction parser tag: For pre-ACF build, cache API call stack
Closed, ResolvedPublic
Actions

Description

(This should happen after work to migrate the logic handling to WikiLambda and use an API, T371027.)

  • Wrap the call in a cache function (like we do for orchestrator calls in WikiLambda).
  • Ensure the cache key prefix is distinct from that for WikiLambda's orchestrator calls.

No need for cache key normalisation as-yet, as this'll be replaced by the ACF work next Quarter.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Re-write function call system to split responsibilitiesmediawiki/extensions/WikiLambdamaster+1 K -252
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdforrester-WMF created this task.Apr 10 2024, 3:34 PM
Jdforrester-WMF renamed this task from Wikifunction parser tag: For pre-ACF build, cache results to Wikifunction parser tag: For pre-ACF build, cache API call stack.
Jdforrester-WMF triaged this task as Low priority.Apr 10 2024, 3:44 PM
Jdforrester-WMF moved this task from To Triage to Upcoming Epics on the Abstract Wikipedia team board.Apr 11 2024, 4:37 PM
Jdforrester-WMF added a parent task: T261472: [25Q1] Let users embed function calls in wikitext which are rendered in the output (for WF itself, not remote wikis).May 28 2024, 1:07 PM
Jdforrester-WMF moved this task from Upcoming Epics to 25Q1 (Jul–Sep) on the Abstract Wikipedia team board.Jun 27 2024, 9:59 AM
Jdforrester-WMF edited projects, added Abstract Wikipedia team (25Q1 (Jul–Sep)); removed Abstract Wikipedia team.
Jdforrester-WMF moved this task from Incoming to Ready, Features on the Abstract Wikipedia team (25Q1 (Jul–Sep)) board.
Jdforrester-WMF mentioned this in T261472: [25Q1] Let users embed function calls in wikitext which are rendered in the output (for WF itself, not remote wikis).Jun 27 2024, 10:03 AM
Jdforrester-WMF updated the task description. (Show Details)Jul 25 2024, 3:26 PM
Jdforrester-WMF moved this task from 25Q1 (Jul–Sep) to 25Q2 (Oct–Dec) on the Abstract Wikipedia team board.Oct 8 2024, 2:05 PM
Jdforrester-WMF edited projects, added Abstract Wikipedia team (25Q2 (Oct–Dec)); removed Abstract Wikipedia team (25Q1 (Jul–Sep)).
Jdforrester-WMF moved this task from Incoming to Ready, Features on the Abstract Wikipedia team (25Q2 (Oct–Dec)) board.Oct 8 2024, 2:09 PM
Jdforrester-WMF edited parent tasks, added: T376521: Enable one WF use case in a smaller language Wikipedia; removed: T261472: [25Q1] Let users embed function calls in wikitext which are rendered in the output (for WF itself, not remote wikis).Oct 16 2024, 4:42 PM
gerritbot added a comment.Nov 11 2024, 8:03 PM

Change #1071260 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] [WIP] Re-write function call system to split responsibilities

https://gerrit.wikimedia.org/r/1071260

gerritbot added a project: Patch-For-Review.Nov 11 2024, 8:03 PM
Jdforrester-WMF moved this task from 25Q2 (Oct–Dec) to 25Q3 (Jan–Mar) on the Abstract Wikipedia team board.Jan 15 2025, 5:30 PM
Jdforrester-WMF edited projects, added Abstract Wikipedia team (25Q3 (Jan–Mar)); removed Abstract Wikipedia team (25Q2 (Oct–Dec)).
Jdforrester-WMF moved this task from Incoming to In Engineering on the Abstract Wikipedia team (25Q3 (Jan–Mar)) board.
Jdforrester-WMF claimed this task.Jan 21 2025, 2:38 PM
DSantamaria changed the task status from Open to In Progress.Jan 31 2025, 11:57 AM
DSantamaria added a project: Wikifunctions integration.
Jdforrester-WMF moved this task from In Engineering to In Code review on the Abstract Wikipedia team (25Q3 (Jan–Mar)) board.Feb 10 2025, 2:44 PM
gerritbot added a comment.Feb 13 2025, 4:23 PM

Change #1071260 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Re-write function call system to split responsibilities

https://gerrit.wikimedia.org/r/1071260

Maintenance_bot removed a project: Patch-For-Review.Feb 13 2025, 4:31 PM
Jdforrester-WMF moved this task from In Code review to Needs Sign-off on the Abstract Wikipedia team (25Q3 (Jan–Mar)) board.Feb 13 2025, 5:51 PM

We're not deploying this code (it's behind a feature flag), so moving straight to sign-off.

Jdforrester-WMF closed this task as Resolved.Feb 20 2025, 3:26 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits