[Bug] Mobile watchlist broken
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	ovasileva
	Apr 11 2024, 6:53 AM

Project Tags

Referenced Files

	F46180435: screenshot 198.png
	Apr 12 2024, 9:51 PM

	F46175985: screenshot 197.png
	Apr 12 2024, 9:24 PM

	F45884993: Screenshot 2024-04-11 at 10.28.26 AM.png
	Apr 11 2024, 2:33 PM

	F45821936: Wikivoyage_Screenshot_2024-04-10-11-21-00-_Watchlist.jpg
	Apr 11 2024, 7:22 AM

	F45817029: WhatsApp Image 2024-04-11 at 08.44.32.jpeg
	Apr 11 2024, 6:53 AM

Subscribers

Description

Steps to reproduce

Expected results

Watchlist is not broken

Actual results

Environments observed

Browser version:
OS version:
Device model:
Device language:

Check any additional observations

Observed on a production wiki
Observed on Vector desktop skin
Observed on MinervaNeue responsive skin
Observed while logged in
Observed while not logged in (anonymous)

Note: original report is from Wikivoyage:
https://en.m.wikivoyage.org/wiki/Wikivoyage:Travellers%27_pub?markasread=594092&markasreadwiki=enwikivoyage#/media/File%3AWikivoyage_Screenshot_2024-04-10-11-21-00-_Watchlist.jpg

QA Results - Beta

AC	Status	Details
1	✅	T362297#9711020

QA Results - Prod

AC	Status	Details
1	✅	T362297#9711117

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	Revert "Update mobile search for dark mode, remove unused functions in MobilePage.php"	Jdrewniak	mediawiki/extensions/MobileFrontend	master	+131 -25
	Revert "Update mobile search for dark mode, remove unused functions in MobilePage.php"	Hashar	mediawiki/extensions/MobileFrontend	wmf/1.42.0-wmf.26	+131 -25

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	BUG REPORT	ovasileva	T362297 [Bug] Mobile watchlist broken
		Resolved		ovasileva	T362338 [Bug] Mobile watchlist automatically redirecting to "view and edit"

Event Timeline

ovasileva created this task.Apr 11 2024, 6:53 AM

ovasileva triaged this task as Unbreak Now! priority.

Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptApr 11 2024, 6:53 AM

ovasileva mentioned this in T360158: 1.42.0-wmf.26 deployment blockers.Apr 11 2024, 6:54 AM

ovasileva added a parent task: T360158: 1.42.0-wmf.26 deployment blockers.

hashar subscribed.Apr 11 2024, 7:19 AM

hashar updated the task description. (Show Details)Apr 11 2024, 7:22 AM

@Jdlrobson said on the wiki page it might be a fallout of T358904 and thus https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MobileFrontend/+/1015636

hashar updated the task description. (Show Details)Apr 11 2024, 7:37 AM

When I hit https://en.m.wikivoyage.org/wiki/Special:Watchlist I get redirected https://en.m.wikivoyage.org/wiki/Special:EditWatchlist and I do not get the top navigation bar with All Pages Talk Other nor the time/delta on the side :/ Or can it be fixed during the day? :)

Using git bisect and testing locally, I can verify that https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MobileFrontend/+/1015636 is the offending commit.
Regarding the redirect, I'm able to reproduce that too, and I see that it's a separate issue, not produced by the offending patch :/
On my local, I can see that the redirect from Special:Watchlist to Special:EditWatchlist only happens for non-admin users.
admin users are still able to visit Special:Watchlist.

it looks like the overlay issue was an existing bug that was made visible by the addition of a grey background. The screenshot below shows the positioning of the elements *before* the patch. By adding a grey background to the element, as the patch did, the text beside it overlaps. The offending patch did not change the positioning of the elements. ~~Instead of reverting this patch, I think it would be simpler to remove this grey background~~ I think a revert is warranted because the size of the element also changed, so just removing the grey background won't entirely fix the issue. As a follow-up, we should fix the positioning and re-introduce this grey background (which was intended for thumbnails).

Screenshot 2024-04-11 at 10.28.26 AM.png (589×891 px, 69 KB)

Change #1018973 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/extensions/MobileFrontend@master] Revert "Update mobile search for dark mode, remove unused functions in MobilePage.php"

https://gerrit.wikimedia.org/r/1018973

gerritbot added a project: Patch-For-Review.Apr 11 2024, 2:54 PM

Change #1018973 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Revert "Update mobile search for dark mode, remove unused functions in MobilePage.php"

https://gerrit.wikimedia.org/r/1018973

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.1; 2024-04-16).Apr 11 2024, 4:00 PM

Change #1018974 had a related patch set uploaded (by Hashar; author: Jdrewniak):

[mediawiki/extensions/MobileFrontend@wmf/1.42.0-wmf.26] Revert "Update mobile search for dark mode, remove unused functions in MobilePage.php"

https://gerrit.wikimedia.org/r/1018974

hashar mentioned this in T362338: [Bug] Mobile watchlist automatically redirecting to "view and edit".Apr 11 2024, 4:09 PM

Change #1018974 merged by Hashar:

[mediawiki/extensions/MobileFrontend@wmf/1.42.0-wmf.26] Revert "Update mobile search for dark mode, remove unused functions in MobilePage.php"

https://gerrit.wikimedia.org/r/1018974

Mentioned in SAL (#wikimedia-operations) [2024-04-11T16:29:00Z] <hashar@deploy1002> Started scap: Backport for [[gerrit:1018974|Revert "Update mobile search for dark mode, remove unused functions in MobilePage.php" (T362297)]]

Mentioned in SAL (#wikimedia-operations) [2024-04-11T16:31:41Z] <hashar@deploy1002> hashar: Backport for [[gerrit:1018974|Revert "Update mobile search for dark mode, remove unused functions in MobilePage.php" (T362297)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

I have verified the fix on the debug server using my admin account on MediaWiki.org. I have used https://m.mediawiki.org/wiki/Special:Watchlist?debug=1 to nuke the resource loader cache.

This task is no more blocking the train, however T362338 still does :)

hashar lowered the priority of this task from Unbreak Now! to High.Apr 11 2024, 4:37 PM

ovasileva moved this task from Incoming to Needs More Work on the Web-Team-Backlog-Archived (FY2023-24 Q4 Sprint 1) board.Apr 11 2024, 4:40 PM

ovasileva moved this task from Needs More Work to QA on the Web-Team-Backlog-Archived (FY2023-24 Q4 Sprint 1) board.

Mentioned in SAL (#wikimedia-operations) [2024-04-11T16:45:48Z] <hashar@deploy1002> Finished scap: Backport for [[gerrit:1018974|Revert "Update mobile search for dark mode, remove unused functions in MobilePage.php" (T362297)]] (duration: 16m 47s)

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.26; 2024-04-09).Apr 11 2024, 5:00 PM

ovasileva removed a parent task: T360158: 1.42.0-wmf.26 deployment blockers.Apr 11 2024, 5:07 PM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

Log in to the mobile site and visit watchlist on mediawiki with AMC off\
✅ AC1: Watchlist is not broken. There should NOT be a gray band on the left hand side.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

Log in to the mobile site and visit watchlist on mediawiki with AMC off\
✅ AC1: Watchlist is not broken. There should NOT be a gray band on the left hand side.