Page MenuHomePhabricator

Create a Query Builder for IDatabase::deleteJoin or remove the function
Open, Needs TriagePublic

Description

The function IDatabase::deleteJoin of the database abstraction layer does not have a query builder replacement.

  • Add DeleteQueryBuilder::join like exists on SelectQueryBuilder
  • Create a new Query Builder
  • Deprecate and remove the function - It could be replaced with explicit select of a primary key and delete with proper batching

Usage: https://codesearch.wmcloud.org/search/?q=%5CbdeleteJoin%5Cb&files=&excludeFiles=&repos=

In deployed code:

  • In core when remove expiry from watchlist items
  • OAuth
  • CampaignEvents, seems also oauth handling