Page MenuHomePhabricator

Remove wgMinervaApplyKnownTemplateHacks code.
Closed, ResolvedPublic2 Estimated Story Points

Description

Background

In T361589 we moved code relating to templates from Minerva to WikimediaMessages. We now have 2 instances of the CSS which is confusing, so we should remove ASAP.

User story

As a user, I don't want delays in getting night mode updates due to confusion relating to code living in 2 places in production.

Before working on this task

Check that cached pages have cleared to a significant rate and that the new style module is present: https://logstash.wikimedia.org/goto/bdc5fa26c4c69d2a03e15b3fc50a74b6

Acceptance criteria

  • The wgMinervaApplyKnownTemplateHacks configuration variable is removed from Minerva
  • The Readme.md has been updated.
  • References to when (@wgMinervaApplyKnownTemplateHacks = 1) { are removed.
  • resources/skins.minerva.base.styles/content/tablet/hacks.less is removed
  • resources/skins.minerva.mainPage.styles/hacks.less is removed
  • resources/skins.minerva.base.styles/content/hacks.less is removed

QA steps

Communication criteria - does this need an announcement or discussion?

This will surface T362747 for a small selection of page views from 2nd May.

  • There were 76,000 page views impacted with the issue over last hour on Thursday 25th
  • On Thursday 18th 1,445,668 page views were impacted.
  • This number should be even lower on 2nd May.

We may want to inform communities that if unsatisfied with this situation they can add the following code to MediaWiki:Mobile.js:

mw.loader.using( 'ext.wikimediamessages.styles' )

QA Results - Beta

ACStatusDetails
1T362727#9762163

QA Results - Prod

ACStatusDetails
1T362727#9765526

Details

Other Assignee
bwang
Related Changes in Gerrit:

Event Timeline

Change #1023114 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/MinervaNeue@master] Remove MinervaKnownTemplateHacks

https://gerrit.wikimedia.org/r/1023114

Jdlrobson updated Other Assignee, added: bwang.
Jdlrobson added a subscriber: bwang.

The error rate seems to be dropping off a little, but I'd like to leave this until at least Thursday before making a call to merge it:

Screenshot 2024-04-23 at 4.01.08 PM.png (378×615 px, 13 KB)

Screenshot 2024-04-23 at 4.01.37 PM.png (229×1 px, 24 KB)

I've left some feedback on the patch in the mean time (attention @bwang)

yep i can update the patch. Just wondering though, what is that error rate of? and how does it relate to removing these hacks css?

Jdlrobson updated the task description. (Show Details)

Change #1023114 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Remove MinervaKnownTemplateHacks

https://gerrit.wikimedia.org/r/1023114

Edtadros subscribed.

Test Result - Beta

Status: ❌ FAIL
Environment: beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

Test Steps

Visit https://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=Dog&minervanightmode=1 and resize to mobile
✅ AC1: Make sure the infobox goes full screen
This is probably not the important part of this task. But see AC2 for the infobox in full width.

❌ AC2: Make sure no color contrast issues
There are a lot of contrast issues. The Red text, as well as the colored boxes under Temporal Range near the top of the infobox.

screenshot 288.png (1×1 px, 436 KB)

❌ AC2: Make sure no color contrast issues

Edward, please erun on https://en.m.wikipedia.beta.wmflabs.org/wiki/The_New_Blue_of_Yale?minervanightmode=1
You can ignore any color contrast issues with red links OR the language button as they are tracked in T363778 and T361693.

Jdlrobson updated the task description. (Show Details)

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

Test Steps

Visit https://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=Dog&minervanightmode=1 and resize to mobile
✅ AC1: Make sure the infobox goes full screen
See AC2 for the infobox in full width.

✅ AC2: Make sure no color contrast issues inside the infobox (ignore issues with red links and language button)
No color contrast issues aside from the red links in the infobox.

screenshot 302.png (772×1 px, 173 KB)

Test Result - PROD

Status: ✅ PASS
Environment: PROD
OS: macOS Sonoma 14.4.1
Browser: Chrome 124
Device: MBA
Emulated Device:NA

Test Artifact(s):

Test Steps

Visit https://en.m.wikipedia.org/wiki/Cat?minervanightmode=1 and resize to mobile
✅ AC1: Make sure the infobox goes full-screen

2024-05-02_14-59-23.png (886×710 px, 239 KB)

✅ AC2: Make sure no color contrast issues inside the infobox (ignore issues with red links and language button)
No color contrast issues aside from the blue links in the infobox.

2024-05-02_14-59-02.png (1×1 px, 379 KB)

Looks good, resolving!

Change #1031588 had a related patch set uploaded (by Func; author: Func):

[mediawiki/skins/MinervaNeue@master] styles: Stop using SkinModule in skins.minerva.mainPage.styles

https://gerrit.wikimedia.org/r/1031588

Change #1127887 had a related patch set uploaded (by Hashar; author: Hashar):

[operations/mediawiki-config@master] Remove obsolete $wgMinervaApplyKnownTemplateHacks

https://gerrit.wikimedia.org/r/1127887