Page MenuHomePhabricator
Create Task
Maniphest T362811

Remove unnecessary metadata stored in the translate_metadata table
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Looking at the code, if priority languages are set, we store the reason even if it is empty. Similarly, we store priority force (as off) even if the option is selected

The code can be updated to avoid saving rows if:

  • If reason is an empty string (363 rows on MetaWiki, 46 in MediaWiki.org)
  • If priority force is 'off' (413 rows on MetaWiki, 43 in MediaWiki.org)

After the code changes are deployed, we need to run a script to remove these existing values.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
MessageGroupMetadata: Remove unnecessary metadatamediawiki/extensions/Translatemaster+82 -13
Customize query in gerrit

Related Objects

Event Timeline

abi_ created this task.Apr 17 2024, 5:44 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 17 2024, 5:44 PM
abi_ moved this task from Quarter Backlog to In Review on the Language-Team (Language-2024-April-June) board.Apr 17 2024, 5:44 PM
gerritbot added a comment.Apr 17 2024, 5:45 PM

Change #1016081 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] MessageGroupMetadata: Remove unnecessary metadata

https://gerrit.wikimedia.org/r/1016081

gerritbot added a project: Patch-For-Review.Apr 17 2024, 5:45 PM
Nikerabbit moved this task from Backlog to group management on the MediaWiki-extensions-Translate board.Apr 18 2024, 8:36 AM
Nikerabbit moved this task from Backlog to Translatable pages (LH1) on the Localization Infrastructure FY2023-24 board.May 7 2024, 11:14 AM
gerritbot added a comment.May 13 2024, 1:50 PM

Change #1016081 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] MessageGroupMetadata: Remove unnecessary metadata

https://gerrit.wikimedia.org/r/1016081

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.5; 2024-05-14).May 13 2024, 2:00 PM
Maintenance_bot removed a project: Patch-For-Review.May 13 2024, 2:31 PM
abi_ moved this task from In Review to Check after deployment on the Language-Team (Language-2024-April-June) board.May 14 2024, 5:58 AM
Pols12 mentioned this in T365191: Marking a page for translation "removed priority languages" even if there never were any.May 19 2024, 6:18 PM
abi_ added a comment.May 20 2024, 9:50 AM

I ran the script to remove the redundant metadata from all the wikis where the Translate extension is installed.

Tacsipacsi subscribed.May 20 2024, 10:17 AM

Out of curiosity, do we know how many rows did this remove?

abi_ added a comment.May 20 2024, 12:23 PM
In T362811#9812022, @Tacsipacsi wrote:

Out of curiosity, do we know how many rows did this remove?

Difficult to say, but as per my initial research on the task it should be around 776 rows on Meta-Wiki, and 89 rows on MediaWiki.org

abi_ closed this task as Resolved.May 22 2024, 5:08 AM
abi_ moved this task from Check after deployment to Done on the Language-Team (Language-2024-April-June) board.
Tacsipacsi added a comment.May 22 2024, 9:13 AM

Thanks! So we didn’t actually win a lot of disk space, just made the code easier to follow.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits