Provide two links from Special:Investigate to Special:InvestigateBlock (one for accounts and one for IPs)
Closed, ResolvedPublic2 Estimated Story PointsFeature
Actions

Assigned To

Authored By

	Dreamy_Jazz
	Apr 18 2024, 9:55 AM

Description

To implement T313446: Make non-CUs linking users and IPs when CUs use block forms in CheckUser harder, the Trust and Safety Product Team have decided to change the one link from Special:Investigate to Special:InvestigateBlock into two links, with one prefilling all the accounts being blocked and the other prefilling all IPs being blocked.

Acceptance criteria

Special:Investigate allows the user to block IPs and accounts using two links, with one being for IPs and the other being for accounts.

Details

	Subject	Repo	Branch	Lines +/-
	Provide two blocking links from Special:Investigate	mediawiki/extensions/CheckUser	master	+195 -78

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved	Feature	Dreamy_Jazz	T313446 Make non-CUs linking users and IPs when CUs use block forms in CheckUser harder
Resolved		Dreamy_Jazz	T362548 Warn if blocking both IPs and accounts when using Special:InvestigateBlock
Resolved	Feature	Dreamy_Jazz	T362862 Provide two links from Special:Investigate to Special:InvestigateBlock (one for accounts and one for IPs)
Resolved		Dreamy_Jazz	T362152 Improve test coverage on Special:Investigate code
Resolved		Dreamy_Jazz	T362569 Test SpecialInvestigateBlock
Resolved		Dreamy_Jazz	T362914 Add qunit tests for investigate/blockform.js

Event Timeline

Dreamy_Jazz created this task.Apr 18 2024, 9:55 AM

Dreamy_Jazz added a subtask: T362152: Improve test coverage on Special:Investigate code.

Dreamy_Jazz added a subtask: T362569: Test SpecialInvestigateBlock.

Dreamy_Jazz changed the subtype of this task from "Task" to "Feature Request".Apr 18 2024, 9:57 AM

Dreamy_Jazz set the point value for this task to 2.Apr 18 2024, 10:09 AM

Dreamy_Jazz moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)) board.

Dreamy_Jazz mentioned this in T362914: Add qunit tests for investigate/blockform.js.Apr 18 2024, 5:33 PM

Change #1021524 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] [WIP] Provide two blocking links from Special:Investigate

https://gerrit.wikimedia.org/r/1021524

gerritbot added a project: Patch-For-Review.Apr 18 2024, 5:35 PM

Dreamy_Jazz closed subtask T362152: Improve test coverage on Special:Investigate code as Resolved.Apr 19 2024, 3:45 PM

Dreamy_Jazz moved this task from In Progress to Needs Review on the Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)) board.Apr 19 2024, 5:35 PM

Dreamy_Jazz edited projects, added Trust and Safety Product Sprint (Sprint Pennywhistle (23rd April - 3rd May)); removed Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)).Apr 23 2024, 10:50 AM

Dreamy_Jazz moved this task from Priority Backlog to Needs Review on the Trust and Safety Product Sprint (Sprint Pennywhistle (23rd April - 3rd May)) board.

Dreamy_Jazz closed subtask T362569: Test SpecialInvestigateBlock as Resolved.Apr 23 2024, 10:52 AM

Change #1021524 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Provide two blocking links from Special:Investigate

https://gerrit.wikimedia.org/r/1021524

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.3; 2024-04-30).Apr 24 2024, 6:00 PM

Dreamy_Jazz closed subtask T362914: Add qunit tests for investigate/blockform.js as Resolved.Apr 24 2024, 6:15 PM

Dreamy_Jazz moved this task from Needs Review to Needs QA on the Trust and Safety Product Sprint (Sprint Pennywhistle (23rd April - 3rd May)) board.Apr 24 2024, 6:27 PM

Suggested QA steps:

Open Special:Investigate while logged into an account with the checkuser and sysop groups
Enter some testing targets and run the check
Exclude at least one IP and user from the results (use Filter from the results in the dropdown menu). This button is shown below:

Verify that the subtitle of the results page looks has two buttons to block, one for IPs and the other for accounts:

Click on the Block accounts button and verify that only the accounts marked as targets in the investigation are included in the list of users, such as the following:

Verify that the user you filtered out in step 3 appears as an option you can select if you click in the usernames input shown in the screenshot above.
Click Continue and verify that the accounts listed in the usernames input are pre-filled in the Special:InvestigateBlock form and that this opened in a new tab
Repeat steps 5 to 7, but press Block IPs and verify that only the IPs marked as targets in the investigation are included in the usernames input.

I have verified the new code has been implemented and is functioning and displaying as expected... Thank You for the QA Steps @Dreamy_Jazz!!!

Djackson-ctr moved this task from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Pennywhistle (23rd April - 3rd May)) board.Apr 25 2024, 4:32 AM

Djackson-ctr unsubscribed.

Djackson-ctr subscribed.

Thanks for the QA.

Maintenance_bot removed a project: Patch-For-Review.Apr 26 2024, 5:53 PM

	F48557181: image.png
	Apr 25 2024, 4:27 AM

	F48557115: image.png
	Apr 25 2024, 4:27 AM

	F48557005: image.png
	Apr 25 2024, 4:27 AM

	F48556950: image.png
	Apr 25 2024, 4:27 AM

Provide two links from Special:Investigate to Special:InvestigateBlock (one for accounts and one for IPs)Closed, ResolvedPublic2 Estimated Story PointsFeatureActions