Exception handling for appearance settings (font-size and width) - Vector
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To

Authored By

	Jdrewniak
	Apr 18 2024, 5:24 PM

Description

Background

This is a follow-up to T361158. In that task, exception handling was added only to the night mode setting. This task aims to add exception handling for the width and font-size settings as well.

User story

As a reader, if either my font-size settings or width settings are not respected a given page, I want a notice explaining why.

Requirements

If a certain page has an font-size or limited-width override, it should appear with the overridden settings, the user should not be able to change the settings, the radio buttons should appear disabled, and a notice should appear below the related Appearance menu settings.

Design

~~From T361158 (to be updated).~~

Acceptance criteria

Communication criteria - does this need an announcement or discussion?

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	[POC] Radio buttons should work but not change class when disabled	mediawiki/skins/Vector	master	+13 -9
	[Vector 2022] Test night mode disabled on mainpage on beta cluster.	operations/mediawiki-config	master	+3 -0

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	ovasileva	T362911 Exception handling for appearance settings (font-size and width) - Vector
Resolved	ovasileva	T364159 [Bug] As an anonymous user I get night theme enabled on pages where night mode should be disabled
Declined	None	T364015 Exception handling for appearance settings (width) - Vector
Resolved	ovasileva	T366216 Don't hide width controls at narrow viewport sizes
Duplicate	Jdlrobson	T363834 [GOAL] Add Feature Default Values Configuration Options in Vector and Minerva Skins
Resolved	ovasileva	T364887 It should be possible to set a different default font size on different pages for Vector 2022
Resolved	Jdlrobson	T365408 [Subtask[Regression] Vector 2022 uses wrong font size on talk pages

Event Timeline

Jdrewniak created this task.Apr 18 2024, 5:24 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 18 2024, 5:24 PM

Jdrewniak attached a referenced file: F43552917: image.png. (Show Details)Apr 18 2024, 5:24 PM

Jdrewniak mentioned this in T361158: Exception handling for appearance settings - Vector.

Action Items:

Implement changes to disable radio button preferences and freeze font size to small on all exception pages.
Make necessary adjustments to the UI elements and conduct user testing on the updated design.

Document the chosen design approach for disabling preferences and freezing font size on exception pages.
Detail the rationale behind the decision and provide clear guidelines for implementation.

Schedule a meeting between Justin and Jan to discuss further options regarding the behavior of radio buttons on exception pages.
Explore alternative solutions and gather input before finalizing the implementation.

Evaluate feasibility of removing all exceptions to font size preferences as an alternative solution.
This evaluation should consider potential impact on user experience and accessibility requirements.

ovasileva assigned this task to JScherer-WMF.Apr 18 2024, 5:36 PM

ovasileva triaged this task as High priority.

ovasileva edited projects, added Web-Team-Backlog-Archived (FY2023-24 Q4 Sprint 1); removed Web-Team-Backlog-Archived.

ovasileva moved this task from Incoming to Design Review on the Web-Team-Backlog-Archived (FY2023-24 Q4 Sprint 1) board.

Change #1021515 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] [POC] Radio buttons should work but not change class when disabled

https://gerrit.wikimedia.org/r/1021515

gerritbot added a project: Patch-For-Review.Apr 19 2024, 4:24 PM

The fact that the original design of letting users change settings even though those settings are not applied on exception pages and giving them a notice to explain why the changes are not taking effect, was relatively complicated for implementation.

To unblock dev, I included a design for the disabled radios in the description. Moving to Sprint 2 and putting this in ready for dev.

JScherer-WMF edited projects, added Web-Team-Backlog-Archived (FY2023-24 Q4 Sprint 2); removed Web-Team-Backlog-Archived (FY2023-24 Q4 Sprint 1).Apr 19 2024, 9:30 PM

ovasileva moved this task from Backlog to Ready for Development on the Web-Team-Backlog-Archived (FY2023-24 Q4 Sprint 2) board.Apr 23 2024, 4:56 PM

Jdrewniak moved this task from Ready for Development to Doing on the Web-Team-Backlog-Archived (FY2023-24 Q4 Sprint 2) board.Apr 29 2024, 5:23 PM

Jdlrobson removed JScherer-WMF as the assignee of this task.Apr 29 2024, 5:23 PM

Jdlrobson assigned this task to Jdrewniak.

Jdlrobson added a subscriber: JScherer-WMF.

Jdlrobson set the point value for this task to 3.Apr 29 2024, 5:32 PM

Jdlrobson moved this task from Doing to Blocked on Others on the Web-Team-Backlog-Archived (FY2023-24 Q4 Sprint 2) board.Apr 29 2024, 5:46 PM

Jdlrobson subscribed.

This comment was removed by Jdlrobson.

Jdlrobson moved this task from Blocked on Others to Doing on the Web-Team-Backlog-Archived (FY2023-24 Q4 Sprint 2) board.Apr 29 2024, 5:46 PM

Jdrewniak mentioned this in T364015: Exception handling for appearance settings (width) - Vector.May 2 2024, 3:14 PM

Change #1026939 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[operations/mediawiki-config@master] [Vector 2022] Test night mode disabled on mainpage on beta cluster.

https://gerrit.wikimedia.org/r/1026939

Change #1026939 abandoned by Jdrewniak:

[operations/mediawiki-config@master] [Vector 2022] Test night mode disabled on mainpage on beta cluster.

Reason:

Never mind, the config inherits from the Minerva settings which disable night mode on the page "Banana".

https://gerrit.wikimedia.org/r/1026939

There hasn't been much activity on this task last even though it's been in "doing" all week. Unfortunately a few complications arose that have delayed this work. This task was original split from T361158 where a visual design for exception handling for all settings was proposed. This task was meant to split the night-mode settings from width/font-size, but it turns out these two settings could have been split further. During the course of this work, we actually produced the following tasks based on new information:

T363834 Add Feature Default Values Configuration Options in Vector and Minerva Skins - We realized we don't have the configuration logic for the font-size setting. This task propose a re-design of the configuration architecture and applying it to the font-size setting (T360452 also seems related).
T364015 Exception handling for appearance settings (width) - Vector - The width settings behave somewhat unusually at ultra-wide resolutions, so we'd like to validate the behaviour with Design
T364159 - (Bug) As an anonymous user I get night theme enabled on pages where night mode should be disabled - While working on this task we discovered that the previously implemented night-mode override has a bug that makes it ineffective for anonymous users. It seems sensible to solve that bug first to avoid introducing it for the width & font-size settings.