For this requirement:

For noJS users, we will keep the current flow.

We have a bit of a conundrum. There are two ways that we can redirect the user to the event page: server-side and client-side.

• Server-side works regardless of whether you have JavaScript enabled or not, and after enabling registration you are immediately taken to the event page. Then, if you have JS enabled you also see the success notification; otherwise you don't see any notification (but you do see the registration header with the information you just entered in the form).
• Client-side only works if JS is enabled. This would allow us to keep the current flow for no-JS users. However, JS users will have a suboptimal flow where the current success message loads and remains visible for a little bit (how long exactly depends on various factors such as internet speed), and then they're redirected to the event page.

Of the two, I would choose the first option, on the grounds that the subpar experience should be for no-JS users, not the other way around. Still, curious to hear what you think @ifried!

I would also like to ask if the redirect should be done when enabling registration only, or also when editing it. If so, I can file a separate task for it.

Also, even if registration is enabled successfully, there might be warnings. Currently, this can happen if there were troubles enabling integration with the P&E Dashboard. I'm assuming these warnings would be shown as warning-type notifications along with the success message?

Change #1084146 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] Make the event page available as a class member after editing event

https://gerrit.wikimedia.org/r/1084146

Change #1084165 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] Redirect user to event page after enabling registration

https://gerrit.wikimedia.org/r/1084165

Change #1084146 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Make the event page available as a class member after editing event

https://gerrit.wikimedia.org/r/1084146

Pending answers to T362924#10273154 and T362924#10273208, I implemented it with a server-side redirect and warnings displayed on the event page, which is I think the most sensible approach given the requirements. Here's a screenshot of what it would look like with a warning:

Hi @Daimona, thanks for explaining the two options. I agree that the server-side approach is better, since we should give the optimal experience to JS users and the no-JS experience is still fine.

And, yup, we can keep the warning type messages in their current form. They can be useful to organizers and I see no issue with how they are currently displayed.

In T362924#10282190, @ifried wrote:

And, yup, we can keep the warning type messages in their current form. They can be useful to organizers and I see no issue with how they are currently displayed.

This is how we're displaying them currently:

My proposal above (F57656765) is to keep the same separation, and turning them both into bubble notifications on the event page. If that works for you, I think this is ready for review.

I'm also wondering if I should create a task for making the same change to the edit registration workflow.

Yup, keeping them separated & using bubble notifications works, @Daimona

And, yes, good point. We should also do it for edit registration. Thanks for offering to create a task for that too :)

Thanks for confirming!

Change #1084165 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Redirect user to event page after enabling registration

https://gerrit.wikimedia.org/r/1084165

Acceptance criteria:

• Given an organizer has created an Event page
  • ✅ When an event registration has been successfully enabled on Special:EnableEventRegistration
  • ✅ Then the user should be redirected to the Event page
  • ✅ And they should see a success message in a bubble notification
    • ✅ The exact content of the success message will be handled in T377998 (see below, from T377998)
      • "Registration is enabled. Participants can now register on your event page."
      • And in a new line in the same bubble notification, they should see:
      • "This event is included in the Collaboration list."
      • Collaboration list should be bold
  • ✅ And if there are any warnings, they should be displayed in separate bubble notifications

screencap	screenshot	warning in separate bubble notification
		{F57727223}