Page MenuHomePhabricator

Don't show dialog after saving a linked page
Open, LowPublicBUG REPORT

Description

Currently, after saving any page that is linked to Wikidata, the dialog is shown (with the "This article is already linked to an item." message). This is disruptive and doesn't really help anything.

For any page that is already linked, the postEdit dialog should not be displayed.

This bug was introduced after the postEdit behaviour was fixed recently.

Task Description:

QA Results - En Wiki Prod

Details

TitleReferenceAuthorSource BranchDest Branch
Do not show dialog automatically after saving a linked pagerepos/commtech/autosuggest-sitelink!58samwilsonavoid-posteditmain
Customize query in GitLab

Event Timeline

Restricted Application added a subscriber: Aklapper. Β· View Herald Transcript

@Samwilson Chrome and Firefox seem to be working fine but please review the Safari issue below and let me know what you think.

Status: ❌ Fail
Environment: En Wiki Prod
OS: macOS Sonoma 14.4.1
Browser: Chrome 123, Firefox 124, Safari 17.4
Skins. Vector 2022
Device: MBA M2
Emulated Device:: n/a
Test Links:
https://en.wikipedia.org/wiki/Th%E1%BA%A9m_Khuy%C3%AAn_Cave

βœ…AC1: https://phabricator.wikimedia.org/T362943

ChromeFireFox

❌Issue-Safari is having an issue when clicking the AutosuggestSiteLink the first time. It just hangs until you push it a 2nd time as seen in the video below.

❌Issue-Safari is having an issue when clicking the AutosuggestSiteLink the first time. It just hangs until you push it a 2nd time as seen in the video below.

@GMikesell-WMF I'm not able to replicate this. It does look like there's some slowness somewhere, in that the link is supposed to grey out only while it loads the required code, and then only start searching Wikidata after the dialog has opened. A couple of questions:

  1. what happens if you wait longer?
  2. can you open the web browser dev console and see if there are any error messages?
  3. also in the console, but in the network tab, do you see it make any requests to load.php after you click?

It doesn't look like it's an issue with the actual click, because it's greying out the link correctly. It could perhaps be something going wrong with fetching or parsing the translations, because it does that after the click (you should see it make a request to something like https://meta.wikimedia.org/w/api.php?action=query&format=json&prop=revisions&titles=MediaWiki%3AGadget-AutosuggestSitelink-messages%2Fen&rvprop=content&rvslots=main&formatversion=2 i.e. a URL containing MediaWiki:Gadget-AutosuggestSitelink-messages/en).

@Samwilson Please see remarks below.

  1. what happens if you wait longer?

I waited for over a minute after clicking, which nothing happened

  1. can you open the web browser dev console and see if there are any error messages?

It looks like I get an "Unhandled Promise Rejection: badtoken when I first click on it in Safari as seen in the 1st video

  1. also in the console, but in the network tab, do you see it make any requests to load.php after you click?

Yes, as seen in the 2nd video.

AutosuggestSiteLink Issue- This only happens when I click on it the first time in Safari.

Console TabNetwork Tab