Page MenuHomePhabricator

Potential logspam on rollback of 1.43-wmf.2
Closed, ResolvedPublic

Description

As described in T361396#9731220, rollback of 1.43.0-wmf.2 to 1.43.0-wmf.1 might cause PHP notice messages to be emitted about an undefined TOCHTML field in the ParserCache JSON. This should be harmless, as TOCHTML has not been used in production for a looong time, but I'm submitting belt-and-suspenders backport patches to both 1.43.0-wmf.1 and 1.43.0-wmf.2 to prevent the issue:

Either patch is sufficient to prevent the rollback issue.

Event Timeline

Change #1023098 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] ParserOutput: Temporarily write (unused) TOCHTML to ParserCache

https://gerrit.wikimedia.org/r/1023098

Change #1023100 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@wmf/1.43.0-wmf.1] ParserOutput: don't complain if TOCHTML is unset from ParserCache

https://gerrit.wikimedia.org/r/1023100

Change #1023098 merged by jenkins-bot:

[mediawiki/core@master] ParserOutput: Temporarily write (unused) TOCHTML to ParserCache

https://gerrit.wikimedia.org/r/1023098

Change #1023147 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@REL1_42] ParserOutput: don't complain if TOCHTML is unset from ParserCache

https://gerrit.wikimedia.org/r/1023147

Change #1023100 merged by jenkins-bot:

[mediawiki/core@wmf/1.43.0-wmf.1] ParserOutput: don't complain if TOCHTML is unset from ParserCache

https://gerrit.wikimedia.org/r/1023100

Mentioned in SAL (#wikimedia-operations) [2024-04-23T08:15:53Z] <hashar@deploy1002> Started scap: Backport for [[gerrit:1023100|ParserOutput: don't complain if TOCHTML is unset from ParserCache (T363107)]]

Mentioned in SAL (#wikimedia-operations) [2024-04-23T08:20:23Z] <hashar@deploy1002> hashar and cscott: Backport for [[gerrit:1023100|ParserOutput: don't complain if TOCHTML is unset from ParserCache (T363107)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-04-23T08:24:11Z] <hashar@deploy1002> Started scap: Backport for [[gerrit:1023100|ParserOutput: don't complain if TOCHTML is unset from ParserCache (T363107)]]

Mentioned in SAL (#wikimedia-operations) [2024-04-23T08:28:39Z] <hashar@deploy1002> cscott and hashar: Backport for [[gerrit:1023100|ParserOutput: don't complain if TOCHTML is unset from ParserCache (T363107)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-04-23T08:40:25Z] <hashar@deploy1002> Finished scap: Backport for [[gerrit:1023100|ParserOutput: don't complain if TOCHTML is unset from ParserCache (T363107)]] (duration: 16m 13s)

I have deployed the patch for 1.43.0-wmf.1

The other one ( https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1023098 ) is included in 1.43.0-wmf.2 which is deployed this week.

Change #1023147 abandoned by C. Scott Ananian:

[mediawiki/core@REL1_42] ParserOutput: don't complain if TOCHTML is unset from ParserCache

Reason:

Apparently the TOCHTML removal was backported to REL1_42 (i guess i probably did that...)

https://gerrit.wikimedia.org/r/1023147

Change #1023153 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@REL1_42] ParserOutput: Temporarily write (unused) TOCHTML to ParserCache

https://gerrit.wikimedia.org/r/1023153

Change #1023153 merged by jenkins-bot:

[mediawiki/core@REL1_42] ParserOutput: Temporarily write (unused) TOCHTML to ParserCache

https://gerrit.wikimedia.org/r/1023153

brennen claimed this task.
brennen reassigned this task from brennen to cscott.
brennen subscribed.