Page MenuHomePhabricator
Create Task
Maniphest T363162

Move ReferencePreviews user setting creation from Popups to Cite
Closed, ResolvedPublic
Actions

Description

The user setting to disable Reference Previews is still set up in the Page-Previews codebase. This needs to move. See [1]

  • Copy the code creating the user setting over to the Cite extension
  • Make sure to also include the i18n messages involved and see for example T363156: Move ReferencePreviews i18n messages from Popups to Cite
  • Make sure that we do not end up in having two settings for the same thing added
  • After the changes in Cite are fully deployed remove the settings setup from the Popups codebase

[1] https://gerrit.wikimedia.org/g/mediawiki/extensions/Popups/+/cc1bbeffd2365df42a63c28269adb466ec3d5165/includes/PopupsHooks.php#157

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Hide reference previews option when Popups not installedmediawiki/extensions/Citemaster+8 -1
Move Reference Previews user preference into the Cite extensionmediawiki/extensions/Citemaster+167 -20
[refactor] Rewrite context as servicemediawiki/extensions/Citemaster+58 -20
[WIP] [refactor] Wire internal helpers as services for testingmediawiki/extensions/Citemaster+97 -37
[cleanup] Remove unused configuration $wgPopupsReferencePreviewsmediawiki/extensions/Popupsmaster+17 -92
Customize query in gerrit

Related Objects
Search...

Event Timeline

WMDE-Fisch created this task.Apr 23 2024, 12:30 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 23 2024, 12:30 PM
WMDE-Fisch mentioned this in T363156: Move ReferencePreviews i18n messages from Popups to Cite.Apr 24 2024, 8:17 AM
Jdlrobson mentioned this in T355194: Move the reference previews code to Cite extension.Jun 17 2024, 4:17 PM
Jdlrobson mentioned this in T366419: Default user option for Reference Previews changed for users created before 2017/08/16 without any justification.
Izno moved this task from Unsorted backlog to Enhancement backlog on the Cite board.Aug 22 2024, 8:21 PM
Izno mentioned this in T365538: Reference preview preference is defined inside Popups not Cite.
WMDE-Fisch added a project: WMDE-TechWish-Maintenance.Aug 30 2024, 8:55 AM
WMDE-Fisch moved this task from Incoming to Priority backlog on the WMDE-TechWish-Maintenance board.
awight added a parent task: T365538: Reference preview preference is defined inside Popups not Cite.Sep 4 2024, 9:05 AM
gerritbot added a comment.Sep 4 2024, 10:34 AM

Change #1070560 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/Popups@master] [cleanup] Remove unused configuration $wgPopupsReferencePreviews

https://gerrit.wikimedia.org/r/1070560

gerritbot added a project: Patch-For-Review.Sep 4 2024, 10:34 AM
Tobi_WMDE_SW added a project: WMDE-TechWish-Sprint-2024-09-04.Sep 4 2024, 12:56 PM
awight claimed this task.Sep 5 2024, 7:44 AM
awight moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2024-09-04 board.
gerritbot added a comment.Sep 5 2024, 11:25 PM

Change #1070560 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] [cleanup] Remove unused configuration $wgPopupsReferencePreviews

https://gerrit.wikimedia.org/r/1070560

Maintenance_bot removed a project: Patch-For-Review.Sep 5 2024, 11:30 PM
ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.22; 2024-09-10).Sep 6 2024, 12:00 AM
gerritbot added a comment.Sep 6 2024, 9:21 AM

Change #1071148 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/Cite@master] Move Reference Previews user preference into the Cite extension

https://gerrit.wikimedia.org/r/1071148

gerritbot added a project: Patch-For-Review.Sep 6 2024, 9:21 AM
awight removed awight as the assignee of this task.Sep 6 2024, 10:11 AM
awight moved this task from Doing to Tech Review on the WMDE-TechWish-Sprint-2024-09-04 board.
awight subscribed.

The task isn't complete but we should merge the small patches here and then continue with clean-up after the next train. After this patch, we can merge the major cleanup in Popups.

gerritbot added a comment.Sep 6 2024, 12:25 PM

Change #1071187 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/Cite@master] [WIP] [refactor] Wire internal helpers as services for testing

https://gerrit.wikimedia.org/r/1071187

gerritbot added a comment.Sep 6 2024, 2:32 PM

Change #1071218 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/Cite@master] [refactor] Rewrite context as service

https://gerrit.wikimedia.org/r/1071218

gerritbot added a comment.Sep 6 2024, 2:33 PM

Change #1071187 abandoned by Awight:

[mediawiki/extensions/Cite@master] [WIP] [refactor] Wire internal helpers as services for testing

Reason:

split and squashed

https://gerrit.wikimedia.org/r/1071187

gerritbot added a comment.Sep 10 2024, 8:27 AM

Change #1071218 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] [refactor] Rewrite context as service

https://gerrit.wikimedia.org/r/1071218

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.23; 2024-09-17); removed MW-1.43-notes (1.43.0-wmf.22; 2024-09-10).Sep 10 2024, 9:00 AM
Tobi_WMDE_SW added a project: WMDE-TechWish-Sprint-2024-09-18.Sep 18 2024, 12:33 PM
Tobi_WMDE_SW moved this task from Sprint Backlog to Tech Review on the WMDE-TechWish-Sprint-2024-09-18 board.
awight moved this task from Tech Review to Demo on the WMDE-TechWish-Sprint-2024-09-18 board.Sep 23 2024, 10:34 AM
gerritbot added a comment.Sep 23 2024, 10:47 AM

Change #1071148 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Move Reference Previews user preference into the Cite extension

https://gerrit.wikimedia.org/r/1071148

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.24; 2024-09-24); removed MW-1.43-notes (1.43.0-wmf.23; 2024-09-17).Sep 23 2024, 11:00 AM
Maintenance_bot removed a project: Patch-For-Review.Sep 23 2024, 11:31 AM
WMDE-Fisch moved this task from Demo to Done on the WMDE-TechWish-Sprint-2024-09-18 board.Oct 2 2024, 12:17 PM
Tobi_WMDE_SW closed this task as Resolved.Oct 2 2024, 12:18 PM
Tobi_WMDE_SW claimed this task.
gerritbot added a comment.Aug 19 2025, 1:27 PM

Change #1179773 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Jack Phoenix):

[mediawiki/extensions/Cite@master] Hide reference previews option when Popups not installed

https://gerrit.wikimedia.org/r/1179773

gerritbot added a project: Patch-For-Review.Aug 19 2025, 1:27 PM
gerritbot added a comment.Aug 22 2025, 7:35 AM

Change #1179773 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Hide reference previews option when Popups not installed

https://gerrit.wikimedia.org/r/1179773

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.16; 2025-08-26).Aug 22 2025, 8:00 AM
Maintenance_bot removed a project: Patch-For-Review.Aug 22 2025, 8:31 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits