Form errors on Special:AllEvents cause misalignment of the whole form
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Daimona
	Apr 23 2024, 4:34 PM

Description

Steps to replicate the issue (include links if applicable):

In extension/CampaignEvents/src/Special/SpecialAllEvents, make the setSubmitCallback function return \MediaWiki\Status\Status::newFatal('test') instead of true.
- Note that we need this because the form currently has no validation, and therefore it's not possible to trigger any validation errors. This could've been reproduced differently before T362895 was fixed.
Go to Special:AllEvents
Click "Apply filters"

What happens?:
The error message follows the grid layout, and pushes all the form fields back, as can be seen in the following screenshot:

What should have happened instead?:
The error message should not be part of the grid layout.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia): master

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	SpecialAllEvents: exclude form errors from grid layout	mediawiki/extensions/CampaignEvents	master	+4 -0

Change #1023470 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] SpecialAllEvents: exclude form errors from grid layout

Change #1023470 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] SpecialAllEvents: exclude form errors from grid layout

✅ The error message is not part of the grid layout.

marking as resolved / done

	F48343859: Screen Recording 2024-04-23 at 5.05.05 PM.gif
	Apr 23 2024, 10:06 PM