The databasefield recentchanges.rc_new is marked as obsolete in RecentChanges.php
Please drop this field to clean up the table.
The problem is, that this field is used at many places in core. You can remove it with a check of the field "rc_source" against the const RecentChange::SRC_NEW.
| Title | Reference | Author | Source Branch | Dest Branch | |
|---|---|---|---|---|---|
| feat(featureset): fall back to default quality thresholds for unseen wikis | repos/research/knowledge_integrity!37 | mnz | mnz/supported-wikis | main |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T400696 FY25-26 WE1.4.1 RecentChanges database performance improvements | |||
| Resolved | Zabe | T36320 Remove obsolete recentchanges.rc_new database field | |||
| Resolved | Zabe | T244080 Add index to recentchanges.rc_source | |||
| Resolved | Ladsgroup | T400854 Add rc_source_name_timestamp index to recentchanges table in wmf production | |||
| Resolved | Ladsgroup | T402763 Drop rc_new from recentchanges table in wmf production |
Change 567541 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/SiteScout@master] Replace use of rc_new field with rc_source
Change 567542 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/SocialProfile@master] Replace use of rc_new field with rc_source
Change 567532 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceSmartList@master] Replace use of rc_new field with rc_source
Change 567542 merged by Jack Phoenix:
[mediawiki/extensions/SocialProfile@master] Replace use of rc_new field with rc_source
Change 567541 merged by Jack Phoenix:
[mediawiki/extensions/SiteScout@master] Replace use of rc_new field with rc_source
Change 568080 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[translatewiki@master] Replace use of rc_new field with rc_source
Change 568080 merged by jenkins-bot:
[translatewiki@master] Replace use of rc_new field with rc_source
Change 567539 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Replace use of rc_new field with rc_source
Change 569282 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Replace use of rc_new field with rc_source (part 1)
Change 567536 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@master] Replace use of rc_new field with rc_source
Change 567531 merged by jenkins-bot:
[mediawiki/extensions/BlockAndNuke@master] Replace use of rc_new field with rc_source
Change 567537 merged by jenkins-bot:
[mediawiki/extensions/LiquidThreads@master] Replace use of rc_new field with rc_source
Change 577735 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Nuke@master] Replace use of rc_new with rc_source, clean up query
Stalled pending addition of new index in T244080: Add index to recentchanges.rc_source
Change 567540 abandoned by Kosta Harlan:
[mediawiki/extensions/PageTriage@master] Replace use of `rc_new` field with `rc_source`
Reason:
Cleaning up the code review queue; if you'd like to keep working on this, please restore it!
There are several places in Wikimedia deployed code where rc_new is still used in queries:
// rc_new is not an ENUM, but adding a redundant rc_new IN (0,1) gives mysql enough // knowledge to use an index merge if it wants (it may use some other index though). $conds += [ 'rc_new' => [ 0, 1 ] ];
They are hard to deal with because queries with rc_new might already use the existing rc_new_name_timestamp index, but there is no index on rc_source (T244080). There is an index on rc_type, though, but it's a bit different:
INDEX rc_new_name_timestamp ( rc_new, rc_namespace, rc_timestamp ), INDEX rc_name_type_patrolled_timestamp ( rc_namespace, rc_type, rc_patrolled, rc_timestamp )
If we still want to do this, maybe we should change the direction a bit and look into finding ways to replace them with rc_type = RC_NEW first. We may need to fiddle with the indices, though.
Change #1027138 had a related patch set uploaded (by Scardenasmolinar; author: Scardenasmolinar):
[mediawiki/extensions/Nuke@master] Replace rc_new for rc_type in DB query
Change #1027147 had a related patch set uploaded (by Samwalton9; author: Samwalton9):
[mediawiki/core@master] Update documentation for rc_new
Change #577735 abandoned by Scardenasmolinar:
[mediawiki/extensions/Nuke@master] Replace use of rc_new with rc_source, clean up query
Reason:
Abandoning in favor of 1027138
Change #1027147 merged by jenkins-bot:
[mediawiki/core@master] Update documentation for rc_new
Change #1027138 merged by jenkins-bot:
[mediawiki/extensions/Nuke@master] Replace rc_new for rc_source in DB query
Change #1175125 had a related patch set uploaded (by Zabe; author: Zabe):
[mediawiki/core@master] Stop reading from rc_new
Change #567540 restored by Matěj Suchánek:
[mediawiki/extensions/PageTriage@master] Replace use of `rc_new` field with `rc_source`
Change #567540 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@master] Replace use of `rc_new` field with `rc_source`
Change #1178899 had a related patch set uploaded (by Zabe; author: Zabe):
[operations/puppet@production] maintain-views: Stop providing rc_new and rc_type to replicas
Change #1178902 had a related patch set uploaded (by Zabe; author: Zabe):
[mediawiki/extensions/CheckUser@master] Stop touching rc_new
Change #1178904 had a related patch set uploaded (by Zabe; author: Zabe):
[mediawiki/extensions/WikiLambda@master] Stop using rc_new
Change #1178906 had a related patch set uploaded (by Zabe; author: Zabe):
[mediawiki/extensions/Flow@master] Stop setting rc_new to 0
Change #1178907 had a related patch set uploaded (by Zabe; author: Zabe):
[mediawiki/extensions/Wikibase@master] Stop setting rc_new to 0
Change #1178908 had a related patch set uploaded (by Zabe; author: Zabe):
[mediawiki/extensions/Wikistories@master] Stop setting rc_new to 0
Change #1178902 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] Stop touching rc_new
Change #1178904 merged by jenkins-bot:
[mediawiki/extensions/WikiLambda@master] Stop using rc_new
Change #1178910 had a related patch set uploaded (by Zabe; author: Zabe):
[mediawiki/core@master] RecentChange: Support rc_new not present in row obj
Change #1175125 merged by jenkins-bot:
[mediawiki/core@master] Stop reading from rc_new
Change #1179139 had a related patch set uploaded (by Zabe; author: Zabe):
[mediawiki/core@master] Drop rc_new coloum from recentchanges
Change #1178910 merged by jenkins-bot:
[mediawiki/core@master] RecentChange: Support rc_new not present in row obj
Change #1178908 merged by jenkins-bot:
[mediawiki/extensions/Wikistories@master] Stop setting rc_new to 0
Change #1178906 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Stop setting rc_new to 0
Change #1178907 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Stop setting rc_new to 0
Change #569282 abandoned by Zabe:
[mediawiki/core@master] Replace use of `rc_new` field with `rc_source` (part 1)
Reason:
All of these were either done in other patches or are no longer existent
Change #1179702 had a related patch set uploaded (by Zabe; author: Zabe):
[mediawiki/core@master] Stop writing to rc_new
Change #1179702 merged by jenkins-bot:
[mediawiki/core@master] Stop writing to rc_new
Change #1179139 merged by jenkins-bot:
[mediawiki/core@master] Drop rc_new column from recentchanges
This will break the recentchanges views in Wiki Replicas.
I created T402787: [wikireplicas] Remove rc_new from recentchanges view definitions.
Change #1182134 had a related patch set uploaded (by Zabe; author: Zabe):
[analytics/wmde/scripts@master] Replace rc_new with rc_source
Change #1182134 merged by jenkins-bot:
[analytics/wmde/scripts@master] Replace rc_new with rc_source
Change #1182137 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Zabe):
[analytics/wmde/scripts@production] Replace rc_new with rc_source
Change #1182137 merged by jenkins-bot:
[analytics/wmde/scripts@production] Replace rc_new with rc_source
Change #1178899 merged by Ladsgroup:
[operations/puppet@production] maintain-views: Stop providing rc_new and rc_type to replicas
