Page MenuHomePhabricator

[jobs-api, jobs-cli] Prefix all endpoints with `/tool/<toolname>`
Closed, ResolvedPublic

Description

Otherwise once we have authentication per-user, we would not be able to know which tool they are acting on (today we authenticate with the tool certificate, so the authenticated user is the tool itself).

Note that the procedure to avoid downtime can be:

  • Change API to support both endpoints (add a check in the API between the path and the auth user for consistency for now)
  • Change the client to use the new url
  • Remove support for the non-prefixed url on the api side

Related Objects

StatusSubtypeAssignedTask
ResolvedLucasWerkmeister
Resolvedmatmarex
ResolvedLegoktm
ResolvedLegoktm
Opendcaro
Opendcaro
In Progressdcaro
In Progressdcaro
Resolveddcaro
Opendcaro
Opendcaro
ResolvedFeatureRaymond_Ndibe
OpenRaymond_Ndibe
OpenRaymond_Ndibe
In ProgressRaymond_Ndibe
Resolveddcaro
In Progressdcaro
OpenNone
ResolvedRaymond_Ndibe
Resolveddcaro
Opendcaro
Opendcaro
OpenNone
ResolvedSlst2020
ResolvedSlst2020

Event Timeline

dcaro triaged this task as High priority.Apr 24 2024, 3:28 PM
dcaro renamed this task from [jobs-api,builds-api,envvars-api,api-gateway] Prefix all endpoints with `/tool/<toolname>` to [jobs-apii] Prefix all endpoints with `/tool/<toolname>`.Apr 30 2024, 10:02 AM
dcaro updated the task description. (Show Details)
fnegri renamed this task from [jobs-apii] Prefix all endpoints with `/tool/<toolname>` to [jobs-api] Prefix all endpoints with `/tool/<toolname>`.May 8 2024, 9:32 AM
Slst2020 renamed this task from [jobs-api] Prefix all endpoints with `/tool/<toolname>` to [jobs-api, jobs-cli] Prefix all endpoints with `/tool/<toolname>`.Jun 3 2024, 12:51 PM
Slst2020 updated the task description. (Show Details)
Slst2020 changed the task status from Open to In Progress.Jun 4 2024, 8:18 AM
Slst2020 claimed this task.
Slst2020 moved this task from Next Up to In Progress on the Toolforge (Toolforge iteration 10) board.
Slst2020 changed the task status from In Progress to Stalled.Jul 10 2024, 11:45 AM

will merge the last patch when the old endpoints have been officially deprecated (Thu 18 July)

project_1317_bot_df3177307bed93c3f34e421e26c86e38 opened https://gitlab.wikimedia.org/repos/cloud/toolforge/toolforge-deploy/-/merge_requests/423

jobs-api: bump to 0.0.319-20240716153429-ac8e3c99

Slst2020 changed the task status from Stalled to In Progress.Jul 19 2024, 9:39 AM

project_1317_bot_df3177307bed93c3f34e421e26c86e38 opened https://gitlab.wikimedia.org/repos/cloud/toolforge/toolforge-deploy/-/merge_requests/442

jobs-api: bump to 0.0.323-20240723115142-863de5d7

Slst2020 updated the task description. (Show Details)
Slst2020 moved this task from In Review to Done on the Toolforge (Toolforge iteration 13) board.