Page MenuHomePhabricator
Create Task
Maniphest T363405

Respect the `Z3K4` Field instead of ad hoc Treatment of Identity Keys
Closed, ResolvedPublic
Actions

Description

Description

When eagerly evaluating, the logic depends on a bespoke list of keys like Z40K1, Z8K5, etc. which are known to be identities. This is not scalable to user-defined types.

Likewise, when inferring the identity of a function, Z8K5 is directly consulted.

In both cases, the upcoming Z3K4 key will standardize the usage of identities and scale them to user-defined types.

Desired behavior/Acceptance criteria (returned value, expected error, performance expectations, etc.)

  • eagerlyEvaluate respects the Z3K4 IsIdentity field (by ceasing to expand)
  • findIdentity in function-schemata respects the fact that Z8K5 is now an identity

Completion checklist

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
wikifunctions: Upgrade orchestrator from 2024-04-17-163312 to 2024-05-13-145903operations/deployment-chartsmaster+1 -1
tests: Updated expected "Invoke the Map function" Z4K4 value now that type identities aren't eagrely resolvedmediawiki/extensions/WikiLambdamaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

cmassaro created this task.Apr 24 2024, 7:52 PM
cmassaro added a parent task: T363390: [24Q4] Type support for Wikidata prototype: Enumerations.
cmassaro added a subtask: T282716: ZObject model: Extend Z3/Key with a Boolean key for identity.
Jdforrester-WMF triaged this task as High priority.Apr 24 2024, 7:54 PM
Jdforrester-WMF moved this task from To Triage to 24Q4 (Apr–Jun) on the Abstract Wikipedia team board.
Jdforrester-WMF edited projects, added Abstract Wikipedia team (24Q4 (Apr–Jun)); removed Abstract Wikipedia team.
Jdforrester-WMF moved this task from Incoming to Ready, Features on the Abstract Wikipedia team (24Q4 (Apr–Jun)) board.
cmassaro added a subtask: T363406: Adapt existing types that conceptually use identity to use the new identity key.Apr 24 2024, 7:58 PM
DVrandecic lowered the priority of this task from High to Medium.Apr 24 2024, 8:02 PM
Jdforrester-WMF changed the status of subtask T282716: ZObject model: Extend Z3/Key with a Boolean key for identity from Open to In Progress.Apr 30 2024, 3:23 PM
cmassaro claimed this task.Apr 30 2024, 10:05 PM
CodeReviewBot added a comment.May 2 2024, 8:07 PM

apine updated https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/167

Draft: Do not eagerly evaluate values corresponding to keys marked as identities.

CodeReviewBot added a comment.May 3 2024, 11:07 PM

ecarg merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/167

Do not eagerly evaluate values corresponding to keys marked as identities.

gerritbot added a comment.May 7 2024, 11:55 AM

Change #1028806 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] tests: Updated expected "Invoke the Map function" Z4K4 value now that type identities aren't eagrely resolved

https://gerrit.wikimedia.org/r/1028806

gerritbot added a project: Patch-For-Review.May 7 2024, 11:55 AM
gerritbot added a comment.May 7 2024, 1:37 PM

Change #1028806 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] tests: Updated expected "Invoke the Map function" Z4K4 value now that type identities aren't eagrely resolved

https://gerrit.wikimedia.org/r/1028806

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.5; 2024-05-14).May 7 2024, 2:00 PM
Jdforrester-WMF changed the task status from Open to In Progress.May 8 2024, 4:39 PM
Jdforrester-WMF moved this task from Ready, Features to In Progress on the Abstract Wikipedia team (24Q4 (Apr–Jun)) board.
gerritbot added a comment.May 13 2024, 3:32 PM

Change #1031004 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2024-04-17-163312 to 2024-05-13-145903

https://gerrit.wikimedia.org/r/1031004

gerritbot added a comment.May 20 2024, 4:49 PM

Change #1031004 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2024-04-17-163312 to 2024-05-13-145903

https://gerrit.wikimedia.org/r/1031004

Jdforrester-WMF moved this task from In Progress to Needs Sign-off on the Abstract Wikipedia team (24Q4 (Apr–Jun)) board.Jun 3 2024, 4:43 PM
Jdforrester-WMF closed this task as Resolved.Jun 13 2024, 6:35 PM
Jdforrester-WMF closed subtask T282716: ZObject model: Extend Z3/Key with a Boolean key for identity as Resolved.
Jdforrester-WMF closed subtask T363406: Adapt existing types that conceptually use identity to use the new identity key as Resolved.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits