Maniphest T363539

Fix JSDoc param tag in mw.rcfilters.dm.FilterGroup
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	apaskulin
	Apr 25 2024, 11:11 PM

Project Tags

Referenced Files

None

Subscribers

Description

In JSDoc, config object parameter names should start with config..

To do:

In the FilterGroup.js file, replace [supportsAll=true] in line 30 with [config.supportsAll=true]
Run npm install grunt and grunt lint, and ensure that no JSDoc warnings are reported for that file

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	mw.rcfilters.dm.FilterGroup: Fix JSDoc param tag	HakanIST	mediawiki/core	master	+1 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open	BUG REPORT	Catrope	T356455 Fix eslint warnings in MediaWiki core related to JSDoc
		Resolved		HakanIST	T363539 Fix JSDoc param tag in mw.rcfilters.dm.FilterGroup

Event Timeline

apaskulin created this task.Apr 25 2024, 11:11 PM

Restricted Application added a subscriber: • Aklapper. · View Herald TranscriptApr 25 2024, 11:11 PM

apaskulin added a parent task: T356455: Fix eslint warnings in MediaWiki core related to JSDoc.Apr 25 2024, 11:43 PM

HakanIST claimed this task.May 3 2024, 12:16 PM

Change #1026908 had a related patch set uploaded (by Jforrester; author: HakanIST):

[mediawiki/core@master] mw.rcfilters.dm.FilterGroup: Fix JSDoc param tag

https://gerrit.wikimedia.org/r/1026908

gerritbot added a project: Patch-For-Review.May 3 2024, 12:52 PM

Change #1026908 merged by jenkins-bot:

[mediawiki/core@master] mw.rcfilters.dm.FilterGroup: Fix JSDoc param tag

https://gerrit.wikimedia.org/r/1026908

Maintenance_bot removed a project: Patch-For-Review.May 3 2024, 3:30 PM

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.4; 2024-05-07).May 3 2024, 4:00 PM

Thanks, @HakanIST!