Lately I'm noticing that @Maintenance_bot seems to have stopped removing the Patch-For-Review tag from lots of task in CampaignEvents. Some example tasks where this happened: T363187, T363135, T363200, T362400, T362895 (super simple example) and that's just a sample from this week.
I checked the original announcement in wikitech-l, which I remembered had a list of scenarios where the bot wouldn't remove the tag, but none of them are met in those tasks AFAICS:
- The tag is always added by gerrit-bot
- There are no links to github anywhere
- All patches have been merged
- Nothing weird from gerrit-bot
So I'm not sure what's going on. The bot is definitely removing patch-for-review from other tasks (T346190#9747416, T362913#9747076, T353444#9746493), so there seems to be something specific going on here. Note, I didn't check how many tasks are affected overall (i.e., across the whole phabricator), so it's possible that the successful examples linked above are just some rare outliers. I skimmed through the bot source code but nothing obvious stands out there either.