Page MenuHomePhabricator
Create Task
Maniphest T363705

Missing location icon in indicator in Parsoid
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

Compare
https://en.wikipedia.org/w/index.php?title=Burgh%C3%B6lzli&useparsoid=1 and https://en.wikipedia.org/w/index.php?title=Burgh%C3%B6lzli&useparsoid=0

What happens?:

The indicator on the top of the page are not rendered in the same way - legacy parser has an extra icon
Parsoid:

image.png (22×211 px, 2 KB)

Legacy:
image.png (22×226 px, 3 KB)

What should have happened instead?:

Indicators should be rendered in identical/similar ways.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Bump wikimedia/parsoid to 0.20.0-a17mediawiki/vendormaster+387 -263
Makes AddLinkAttributes a traverser, including through embedded HTMLmediawiki/services/parsoidmaster+58 -45
Customize query in gerrit

Related Objects

Event Timeline

ihurbain created this task.Apr 29 2024, 1:53 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 29 2024, 1:53 PM
ihurbain edited projects, added Maps (Kartographer); removed Parsoid.May 30 2024, 2:26 PM
Restricted Application added a project: Parsoid. · View Herald TranscriptMay 30 2024, 2:26 PM
MSantos removed a project: Parsoid.Jun 6 2024, 2:30 PM
MSantos added a project: Content-Transform-Team-WIP.Jun 6 2024, 2:34 PM
MSantos moved this task from Backlog to Needs Investigation on the Content-Transform-Team-WIP board.
MSantos moved this task from Uncategorized to Phase 1 - DiscussionTools support on the Parsoid-Read-Views board.Jul 25 2024, 1:43 PM
MSantos edited projects, added Parsoid-Read-Views (Phase 1 - DiscussionTools support); removed Parsoid-Read-Views.
MSantos assigned this task to ihurbain.Aug 12 2024, 3:04 PM
gerritbot added a comment.Aug 15 2024, 10:59 AM

Change #1062978 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/services/parsoid@master] Allow link processing of nested content

https://gerrit.wikimedia.org/r/1062978

gerritbot added a project: Patch-For-Review.Aug 15 2024, 10:59 AM
ihurbain moved this task from Needs Investigation to Code Review on the Content-Transform-Team-WIP board.Aug 15 2024, 1:20 PM
gerritbot added a comment.Aug 15 2024, 9:29 PM

Change #1062978 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Makes AddLinkAttributes a traverser, including through embedded HTML

https://gerrit.wikimedia.org/r/1062978

Maintenance_bot removed a project: Patch-For-Review.Aug 15 2024, 9:30 PM
ABreault-WMF moved this task from Code Review to To Deploy on the Content-Transform-Team-WIP board.Aug 15 2024, 10:04 PM
TheDJ subscribed.Aug 16 2024, 9:51 AM
gerritbot added a comment.Aug 19 2024, 1:52 PM

Change #1063811 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.20.0-a17

https://gerrit.wikimedia.org/r/1063811

gerritbot added a project: Patch-For-Review.Aug 19 2024, 1:52 PM
gerritbot added a comment.Aug 19 2024, 2:32 PM

Change #1063811 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.20.0-a17

https://gerrit.wikimedia.org/r/1063811

ihurbain closed this task as Resolved.Aug 26 2024, 3:18 PM
cscott mentioned this in T420051: plwiki: Missing coordinates at top of page.Mar 23 2026, 3:20 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 23 2026, 3:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits