Description

NOTE: Replace with beta cluster link when fix for https://phabricator.wikimedia.org/T354889 is merged.

Steps to replicate the issue (include links if applicable):

Login
visit https://patchdemo.wmflabs.org/wikis/abfa33da2d/w/index.php?title=Dog&vectornightmode=1
Load Echo
Check accessibility color contrast issues

What happens?:

Screenshot 2024-04-29 at 4.14.16 PM.png (900×2 px, 1 MB)

What should have happened instead?:

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Notes for first-time taskers

you will need to install Extension:Echo to test this
The fix will live in the https://www.mediawiki.org/wiki/Extension:Echo
Adding the notheme class to any element will make the element look the same in night and day themes - this should be used here.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Add notheme class to Echo	mediawiki/extensions/Echo	wmf/1.43.0-wmf.4	+1 -1
	Add notheme class to Echo	mediawiki/extensions/Echo	master	+1 -1

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		ovasileva	T341631 [EPIC] Q1 Main hypothesis: Typographical and palette customizations
Resolved		ovasileva	T341632 [EPIC] Palette customizations and dark mode
Resolved		ovasileva	T354835 [epic] Release night mode as a beta feature on desktop and mobile
Resolved		ovasileva	T363814 Release dark mode as a beta feature on desktop (May 15th)
Resolved	BUG REPORT	ovasileva	T363779 [Bug] Echo not compatible with desktop night theme

Event Timeline

Jdlrobson created this task.Apr 29 2024, 11:14 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 29 2024, 11:14 PM

Jdlrobson added a project: Wikimedia-Hackathon-2024.Apr 30 2024, 12:19 AM

Jdlrobson moved this task from Backlog to Hacking project: Dark mode on the Wikimedia-Hackathon-2024 board.Apr 30 2024, 12:27 AM

ovasileva triaged this task as High priority.Apr 30 2024, 5:43 PM

ovasileva added a parent task: T363814: Release dark mode as a beta feature on desktop (May 15th) .

Jdlrobson added projects: FY2023-24-WE 2.1 Typography and palette customizations, good first task.May 4 2024, 7:01 PM

Jdlrobson updated the task description. (Show Details)

ovasileva set the point value for this task to 2.May 6 2024, 5:29 PM

ovasileva moved this task from Backlog to Ready for Development on the Web-Team-Backlog-Archived (FY2023-24 Q4 Sprint 3) board.

bwang claimed this task.May 7 2024, 6:12 PM

bwang moved this task from Ready for Development to Doing on the Web-Team-Backlog-Archived (FY2023-24 Q4 Sprint 3) board.

Change #1028880 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/extensions/Echo@master] Add notheme class to Echo

https://gerrit.wikimedia.org/r/1028880

gerritbot added a project: Patch-For-Review.May 7 2024, 6:34 PM

bwang removed bwang as the assignee of this task.May 8 2024, 5:22 PM

bwang moved this task from Doing to Code Review on the Web-Team-Backlog-Archived (FY2023-24 Q4 Sprint 3) board.

bwang subscribed.

Change #1028880 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] Add notheme class to Echo

https://gerrit.wikimedia.org/r/1028880

Maintenance_bot removed a project: Patch-For-Review.May 9 2024, 9:31 AM

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.5; 2024-05-14).May 9 2024, 10:00 AM

Edtadros moved this task from Code Review to QA on the Web-Team-Backlog-Archived (FY2023-24 Q4 Sprint 3) board.May 9 2024, 5:00 PM

SToyofuku-WMF assigned this task to Edtadros.May 9 2024, 5:09 PM

Change #1030984 had a related patch set uploaded (by Jdlrobson; author: Bernard Wang):

[mediawiki/extensions/Echo@wmf/1.43.0-wmf.4] Add notheme class to Echo

https://gerrit.wikimedia.org/r/1030984

gerritbot added a project: Patch-For-Review.May 13 2024, 6:50 PM

Test Result - Beta

Status: ❌ Fail
Environment: beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

Test Steps

Login
visit https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Dog&vectornightmode=1
Load Echo
Check accessibility color contrast issues
❌ AC1: There should be no color contrast issues.
It is not clear what the expected result is, the notification dropdown is legible but has the following WCAG issues

Opened T364805 as these color contrast issues are present in the default mode as well :(

Change #1030984 merged by jenkins-bot:

[mediawiki/extensions/Echo@wmf/1.43.0-wmf.4] Add notheme class to Echo

https://gerrit.wikimedia.org/r/1030984

Mentioned in SAL (#wikimedia-operations) [2024-05-14T15:58:16Z] <logmsgbot> lucaswerkmeister-wmde@deploy1002 Started scap: Backport for [[gerrit:1030984|Add notheme class to Echo (T363779)]], [[gerrit:1031180|Convert function to arrow function to fix context (T364783)]]

Stashbot mentioned this in T364783: Large amount of errors in animateToolbarIntoView function in VisualEditor.May 14 2024, 3:58 PM

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.4; 2024-05-07); removed MW-1.43-notes (1.43.0-wmf.5; 2024-05-14).May 14 2024, 4:00 PM

Mentioned in SAL (#wikimedia-operations) [2024-05-14T16:05:33Z] <logmsgbot> lucaswerkmeister-wmde@deploy1002 jdlrobson and jforrester and lucaswerkmeister-wmde: Backport for [[gerrit:1030984|Add notheme class to Echo (T363779)]], [[gerrit:1031180|Convert function to arrow function to fix context (T364783)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-05-14T16:21:00Z] <logmsgbot> lucaswerkmeister-wmde@deploy1002 Finished scap: Backport for [[gerrit:1030984|Add notheme class to Echo (T363779)]], [[gerrit:1031180|Convert function to arrow function to fix context (T364783)]] (duration: 22m 43s)

Jdlrobson edited projects, added MW-1.43-notes (1.43.0-wmf.3; 2024-04-30); removed MW-1.43-notes (1.43.0-wmf.4; 2024-05-07).May 14 2024, 4:24 PM

Maintenance_bot removed a project: Patch-For-Review.May 14 2024, 4:31 PM

Jdlrobson assigned this task to ovasileva.May 14 2024, 6:04 PM

Chlod subscribed.May 18 2024, 1:04 AM

All done here. Will track light mode issues in T364805: Echo has color contrast issues in standard theme and night theme

	F49351795: Screenshot 2024-04-29 at 4.14.16 PM.png
	Apr 29 2024, 11:14 PM

	F53049476: screenshot 337.png
	May 14 2024, 1:08 AM

	F53049473: screenshot 335.png
	May 14 2024, 1:08 AM

	F53049472: screenshot 336.png
	May 14 2024, 1:08 AM

[Bug] Echo not compatible with desktop night themeClosed, ResolvedPublic2 Estimated Story PointsBUG REPORTActions