Page MenuHomePhabricator

[builds-api, builds-cli] Prefix all endpoints with `/tool/<toolname>`
Closed, ResolvedPublic

Description

Otherwise once we have authentication per-user, we would not be able to know which tool they are acting on (today we authenticate with the tool certificate, so the authenticated user is the tool itself).

Note that the procedure to avoid downtime can be:

  • Change API to support both endpoints (add a check in the API between the path and the auth user for consistency for now)
  • Change the client to use the new url
  • Remove support for the non-prefixed url on the api side

Details

Related Changes in GitLab:
TitleReferenceAuthorSource BranchDest Branch
api: remove unprefixed endpointsrepos/cloud/toolforge/envvars-api!33sstefanovaslavina/remove-old-endpointsmain
Customize query in GitLab

Related Objects

StatusSubtypeAssignedTask
ResolvedLucasWerkmeister
Resolvedmatmarex
ResolvedLegoktm
ResolvedLegoktm
In Progressdcaro
Resolveddcaro
In Progresskomla
Resolveddcaro
Resolveddcaro
Resolveddcaro
Opendcaro
Resolveddcaro
OpenNone
OpenNone
Resolveddcaro
ResolvedSlst2020
ResolvedSlst2020
Resolveddcaro

Event Timeline

dcaro triaged this task as High priority.Apr 30 2024, 10:07 AM
dcaro moved this task from Backlog to Ready to be worked on on the Toolforge board.
Slst2020 changed the task status from Open to In Progress.May 21 2024, 2:48 PM
Slst2020 moved this task from Next Up to In Progress on the Toolforge (Toolforge iteration 09) board.
Slst2020 renamed this task from [builds-api] Prefix all endpoints with `/tool/<toolname>` to [builds-api, builds-cli] Prefix all endpoints with `/tool/<toolname>`.May 29 2024, 8:59 AM
Slst2020 updated the task description. (Show Details)
Slst2020 moved this task from In Review to Done on the Toolforge (Toolforge iteration 12) board.