| thcipriani | |
| May 1 2024, 3:59 PM |
| F58613413: 2025-03-05_rerun.png | |
| Mar 5 2025, 4:54 PM |
| F54289604: gerrit-run-puppet-compiler_below-commit.png | |
| May 24 2024, 1:55 PM |
| F54289611: gerrit-run-pcc-runnable-check.png | |
| May 24 2024, 1:55 PM |
| F53599428: gerrit_checkrun_run_action.png | |
| May 17 2024, 1:18 PM |
| F53599425: gerrit_checkrun_recheck_button.png | |
| May 17 2024, 1:18 PM |
Based on open feedback from the 2024 Developer Satisfaction Survey, it'd be nice to have a "recheck" button in Gerrit.
Similar to T214631: Create a plugin that add's recheck as a button to PolyGerrit's ui, but requires updating to use the checks api.
I think that we would *use* https://github.com/GerritCodeReview/gerrit/blob/4f82b6d02ac5517e8db3771b17fa28da0a0b9677/polygerrit-ui/app/models/checks/checks-model.ts#L158 in https://gerrit.wikimedia.org/r/plugins/gitiles/operations/software/gerrit/+/refs/heads/deploy/wmf/stable-3.8/plugins/wm-checks-api.js#631.
I'm not 100% sure but that looks like the correct place.
Change #1026135 had a related patch set uploaded (by Paladox; author: Paladox):
[operations/software/gerrit@deploy/wmf/stable-3.8] Allow users to recheck tests in checkers
Change #1032759 had a related patch set uploaded (by Hashar; author: Hashar):
[test/gerrit-ping@master] Test change for a recheck plugin
By default the actions for a given run are only showing up in the popup which is displaying when hovering a run:
The documentation states that when naming the action Run or Cancel, it gets a special treatment in the UI, and indeed that makes the action to show up immediately next to the run:
And potentially we could add Runnable runs in the UI for some of the manually triggerable zuul pipelines (experimental, coverage, php) which would have a Run action commenting the appropriate triggering comment when clicked.
Change #1026135 merged by jenkins-bot:
[operations/software/gerrit@deploy/wmf/stable-3.8] Allow users to recheck tests in checkers
Mentioned in SAL (#wikimedia-operations) [2024-05-24T09:25:11Z] <hashar@deploy1002> Started deploy [gerrit/gerrit@159288a]: Allow users to recheck tests in checkers - T363918
Mentioned in SAL (#wikimedia-operations) [2024-05-24T09:25:18Z] <hashar@deploy1002> Finished deploy [gerrit/gerrit@159288a]: Allow users to recheck tests in checkers - T363918 (duration: 00m 07s)
Change #1032759 abandoned by Hashar:
[test/gerrit-ping@master] Test change for a recheck plugin - take 5
Reason:
Change #1032855 had a related patch set uploaded (by Hashar; author: Hashar):
[operations/software/gerrit@deploy/wmf/stable-3.8] wm-pcc: add a run action
I went to do the same thing for the Puppet compiler. It is not run by default so I went to create a Runnable check which can be triggered from the checks tab:
And I went to add a RUN PUPPET COMPILER link directly below the commit message:
Change #1032855 merged by jenkins-bot:
[operations/software/gerrit@deploy/wmf/stable-3.8] wm-pcc: add a run action
Mentioned in SAL (#wikimedia-operations) [2024-05-24T13:59:30Z] <hashar@deploy1002> Started deploy [gerrit/gerrit@af1257f]: wm-pcc: add a run action - T363918
Mentioned in SAL (#wikimedia-operations) [2024-05-24T13:59:37Z] <hashar@deploy1002> Finished deploy [gerrit/gerrit@af1257f]: wm-pcc: add a run action - T363918 (duration: 00m 07s)
The RUN PUPPET COMPILER has been praised by several people since Friday which is a great win.
For the other recheck series of button, I guess that could use some announcements on wikitech-l and other channels since the feature is not immediately discoverable. Maybe Recheck can be added below the commit message whenever the test pipeline failed.
Is this followup you're planning on or are you looking for assistance/opinions here?
