NOTE: This is blocked on DST and T358246
Background
- Follow up from T354889
Migrating to Codex icons ensures consistency with icon styles and usage across skins/extensions, and allows to remove extra CSS and special icon cases
While we don't do this we waste time addressing issues such as T365951.
User story
As a developer, I want icons to be more maintainable and less prone to breaking, which will affect the end user
Design
- no visual changes
Acceptance criteria
- The module skins.vector.icons and skins.vector.icons.js has been removed. In its place, a Codex CSS mixin is used to render icons.
- There is no increase in CSS bytes shipped, as we are using a URL to an SVG rather than an embedded data URI (a solution that should be provided by T358246)
- The CSS rule in https://github.com/wikimedia/mediawiki-skins-Vector/blob/master/resources/skins.vector.styles/components/Icon.less#L20-69 has been fully removed.
- In night mode, all icons would behave correctly thanks to CSS variables, rather than a CSS filter (invert).
Communication criteria - does this need an announcement or discussion?
- No
Sign off
- Step up ticket for Minerva.