Page MenuHomePhabricator

Migrate ResourceLoader Icons in Vector to use Codex
Open, HighPublic

Description

NOTE: This is blocked on DST and T358246

Background

Migrating to Codex icons ensures consistency with icon styles and usage across skins/extensions, and allows to remove extra CSS and special icon cases
While we don't do this we waste time addressing issues such as T365951.

User story

As a developer, I want icons to be more maintainable and less prone to breaking, which will affect the end user

Design

  • no visual changes

Acceptance criteria

Communication criteria - does this need an announcement or discussion?

  • No

Sign off

  • Step up ticket for Minerva.
  • Setup ticket for follow up task to remove need for ResourceLoader/ImageModule altogether.

Event Timeline

After starting this task, I realized this migration is blocked on T344183. The current Codex icon usage requires the CSS and PHP to be aware of the specific usage of the icon, including whether its an icon button, its size, etc. Our current menu and icon architecture isnt flexible enough to accomodate this usage.

In addition to changes to Codex, we likely need to refactor our menu architecture in order to easily migrate to Codex icons. Currently menu and icon data is handled in multiple places (i.e. Hooks.php, VectorComponentUserLinks.php) and often hardcoded. Because we never fully transitioned our menus to use the component system, we arent able to easily migrate all icons.

SToyofuku-WMF lowered the priority of this task from High to Medium.May 7 2024, 6:17 PM

I also filed https://phabricator.wikimedia.org/T364643 as another blocker for this task. Depending on if T344183 is completed or not, we could potential de scope T364643 from being a blocker for this task. As codex currently functions though, it is a blocker

Jdlrobson changed the task status from Open to Stalled.May 15 2024, 12:24 AM
Jdlrobson subscribed.

Isn't this also blocked on T358246 ?

Jdlrobson raised the priority of this task from Medium to High.May 28 2024, 8:41 PM

Looks like this is still stalled? Shall we punt to sprint 2?

Change #1038910 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] POC: Use mask-image for all Vector icons

https://gerrit.wikimedia.org/r/1038910

Jdlrobson changed the task status from Stalled to Open.Wed, Jul 17, 1:36 AM
Jdlrobson updated the task description. (Show Details)
Jdlrobson updated the task description. (Show Details)
Jdlrobson removed the point value for this task.