Page MenuHomePhabricator

Media dialog layout broken
Open, In Progress, Needs TriagePublic

Description

  • Open VE and choose Insert->Media
  • Search for "cat" and click the first result:
ObservedExpected
image.png (661×923 px, 365 KB)
image.png (666×926 px, 400 KB)
image.png (661×923 px, 41 KB)

Event Timeline

zoe changed the task status from Open to In Progress.May 2 2024, 5:49 PM

Change #1026652 had a related patch set uploaded (by Zoe; author: Zoe):

[mediawiki/extensions/VisualEditor@master] Fix media dialog layout.

https://gerrit.wikimedia.org/r/1026652

Change #1026652 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Fix media dialog layout.

https://gerrit.wikimedia.org/r/1026652

Insert Experience and Drag and drop shuffles between these experiences

Screenshot 2024-05-08 at 11.48.47.png (1×1 px, 200 KB)

Screenshot 2024-05-08 at 10.44.19.png (1×1 px, 125 KB)

However, images are broken

Screenshot 2024-05-08 at 10.44.07.png (1×1 px, 116 KB)

Screenshot 2024-05-08 at 11.47.40.png (418×426 px, 12 KB)

I'm having trouble reproing so I'm not sure how to proceed. I'll have another go in a couple days.

It breaks in Chrome and Firefox for me.

It works just fine in prod. If you can't reproduce the broken image, let's have someone else try. If it works fine for them, we can unblock it.

Screenshot 2024-05-14 at 18.01.13.png (1×1 px, 207 KB)

Thanks for double checking… I was hoping it would just be transient.

I don't see how my change could result in broken images, as it's a pure CSS change. Do you mind if I file that as a separate ticket?

The layout stuff needs further investigation. I notice from the metadata that the thinner images get metadata shown to the right but the wider ones get it below, so this may be behaving as intended. I'll go and have a dig through the code to see if that's on purpose and get back to you.

The broken images wasn't introduced by your change. I think the experience in my comment is expected. We can align with the team to confirm.

Insert Experience and Drag and drop shuffles between these experiences

Screenshot 2024-05-08 at 11.48.47.png (1×1 px, 200 KB)

Screenshot 2024-05-08 at 10.44.19.png (1×1 px, 125 KB)

However, images are broken

Screenshot 2024-05-08 at 10.44.07.png (1×1 px, 116 KB)

Screenshot 2024-05-08 at 11.47.40.png (418×426 px, 12 KB)

Recent uploads are broken. We should confirm that this is just a beta issue.

Screenshot 2024-05-14 at 23.25.46.png (1×1 px, 185 KB)

I've not been able to reproduce on the main branch so it might be environmental?

It's just a beta issue – apparently nobody's actively maintaining it. I fired up a patchdemo and was able to upload an image just fine.

This works as expected.

Verifying, following offline alignment.

Test wiki on Patch demo by Zoe-WMF using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/e858753122/w/