⚓ T364088 Remove custom Legalpad API downstream changes

	Title	Reference	Author	Source Branch	Dest Branch
	Remove custom Legalpad API downstream changes	repos/phabricator/phabricator!58	aklapper	T364088rmLegalpadConduit	wmf/stable

		Status	Subtype	Assigned	Task
		Resolved		Aklapper	T341799 Remove custom WMF Phab downstream hacks superseded by upstream Phorge changes
		Resolved		Aklapper	T364088 Remove custom Legalpad API downstream changes

Aklapper created this task.May 3 2024, 9:29 AM

Aklapper triaged this task as Low priority.

Aklapper added a parent task: T341799: Remove custom WMF Phab downstream hacks superseded by upstream Phorge changes.

Aklapper mentioned this in T341799: Remove custom WMF Phab downstream hacks superseded by upstream Phorge changes.

@sguebo_WMF, @jrbs: Would you know if our custom Phabricator API from non-public T253265 is still used in some ways (e.g. for https://meta.wikimedia.org/wiki/Access_to_nonpublic_personal_data_policy/Noticeboard or such) nowadays, and where its code is located?
That code would pull data from Phabricator by calling legalpad.search and/or legalpad.signature.search. Thanks in advance!

I'd like to deprecate and remove https://phabricator.wikimedia.org/conduit/method/legalpad.search/ and https://phabricator.wikimedia.org/conduit/method/legalpad.signature.search/ in favor of upstream https://phabricator.wikimedia.org/conduit/method/legalpad.document.search/ and https://phabricator.wikimedia.org/conduit/method/legalpad.signature.search (the latter is probably the same code anyway).

Aklapper updated the task description. (Show Details)May 17 2024, 2:56 PM

Aklapper mentioned this in T607: Check easily who has signed Legalpad documents by their Wikimedia username.May 20 2024, 12:54 PM

@sguebo_WMF, @jrbs: Could you please answer the last comment? Thanks in advance!

RhinosF1 subscribed.Jun 4 2024, 8:59 PM

Sorry, I was on sabbatical until yesterday.

In T364088#9789802, @Aklapper wrote:

@sguebo_WMF, @jrbs: Would you know if our custom Phabricator API from non-public T253265 is still used in some ways (e.g. for https://meta.wikimedia.org/wiki/Access_to_nonpublic_personal_data_policy/Noticeboard or such) nowadays, and where its code is located?
That code would pull data from Phabricator by calling legalpad.search and/or legalpad.signature.search. Thanks in advance!

I'd like to deprecate and remove https://phabricator.wikimedia.org/conduit/method/legalpad.search/ and https://phabricator.wikimedia.org/conduit/method/legalpad.signature.search/ in favor of upstream https://phabricator.wikimedia.org/conduit/method/legalpad.document.search/ and https://phabricator.wikimedia.org/conduit/method/legalpad.signature.search (the latter is probably the same code anyway).

I am not super familiar with the technical side of things but my understanding is that right now we do not use the API for this. (I wrote a short thing in Python a few months ago to automate the checks, compare them to SUL accounts for account age / edit count / user rights / blocks, etc. but it is not actively used by anyone else.) So I think I would have no blockers especially since they seem extremely similar to me. Maybe even the same?

Edit to clarify that the Python script I mention here was never published anywhere. I can provide it if it's helpful but since it's not actually really used I don't think it would be.

Yay, thanks a lot! I'm going to undeploy our custom changes then on one of the next Tuesdays. In case anything breaks we can always revert that change again. :)

Aklapper added a project: Release-Engineering-Team (Priority Backlog 📥).Jun 5 2024, 5:39 AM

aklapper opened https://gitlab.wikimedia.org/repos/phabricator/phabricator/-/merge_requests/58

Remove custom Legalpad API downstream changes

• sguebo_WMF awarded a token.Jun 5 2024, 1:21 PM

brennen merged https://gitlab.wikimedia.org/repos/phabricator/phabricator/-/merge_requests/58

Remove custom Legalpad API downstream changes

Aklapper edited projects, added Phabricator (2024-06-25); removed Patch-For-Review, Phabricator.Jun 17 2024, 8:19 PM

brennen mentioned this in rPHDEPebe3a947ad22: update submodules for 2024-06-18 release.Jun 18 2024, 3:03 PM