Page MenuHomePhabricator

After deleting pages with Nuke, also display a count and list of eligible pages which were not deleted
Closed, ResolvedPublic3 Estimated Story Points

Description

When deleting pages with Nuke, admins can use checkboxes to deselect pages that they don't want to have deleted. This is sometimes because the admin wants to follow up for these pages to perform some manual actions.

On the page confirming page deletions being queued, a list is shown of the pages to be deleted. We could also show a list of pages which were deselected (i.e. those that were in the list of pages which could be deleted, but were deselected), or simply the count of such pages which exist.

Example of current behaviour

Screenshot 2024-05-04 at 15.26.21.png (712×1 px, 112 KB)

New behaviour
Under the list of pages queued for deletion, add a sentence:

X pages were not selected for deletion:

where X is the count of pages the user deselected from the available list.
Then list those pages like so:

  • Title (talk | history)

This should be above the 'Delete more pages' link.

Details

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Samwalton9-WMF renamed this task from After deleting pages with Nuke, also display a list of eligible pages which were not deleted to After deleting pages with Nuke, also display a count or list of eligible pages which were not deleted.Oct 29 2024, 1:06 PM
Samwalton9-WMF updated the task description. (Show Details)

I think in this context a list makes the most sense, because the idea is that users may want to follow-up on those pages. Just having a count isn't particularly informative.

Samwalton9-WMF renamed this task from After deleting pages with Nuke, also display a count or list of eligible pages which were not deleted to After deleting pages with Nuke, also display a count and list of eligible pages which were not deleted.Nov 12 2024, 4:09 PM
Samwalton9-WMF updated the task description. (Show Details)
Chlod changed the task status from Open to In Progress.Nov 14 2024, 10:09 AM
Chlod moved this task from Ready to In Progress on the Moderator-Tools-Team (Kanban) board.

Since this overlaps with the code from T364225, I'll add in the changes for this task on the patch on that task (https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Nuke/+/1091189).

Change #1091189 had a related patch set uploaded (by Chlod Alejandro; author: Chlod Alejandro):

[mediawiki/extensions/Nuke@master] Add more details to post-delete page

https://gerrit.wikimedia.org/r/1091189

Scardenasmolinar subscribed.

Thanks for working on this ticket. When testing locally, I found that some pages I marked for deletion still show on the new list of pages not queued for deletion.

Screenshot 2024-11-19 at 13.15.52.png (560×734 px, 89 KB)

Thanks for testing! It turns out I never experienced this issue because I didn't have spaces in the titles of pages I tested with, and this issue only ever appears when running in a browser. New patchset uploaded and ready for review. :)

Change #1091189 merged by jenkins-bot:

[mediawiki/extensions/Nuke@master] Add more details to post-delete page

https://gerrit.wikimedia.org/r/1091189