Page MenuHomePhabricator
Create Task
Maniphest T364273

Wikibase breaks schema update with "Class 'Onoi\MessageReporter\NullMessageReporter' not found"
Closed, ResolvedPublic
Actions

Description

[b044c19a718cc572f5c35d43] [no req]   Error: Class 'Onoi\MessageReporter\NullMessageReporter' not found
Backtrace:
from /vagrant/mediawiki/extensions/Wikibase/client/includes/Store/Sql/UnexpectedUnconnectedPagePrimer.php(61)
#0 /vagrant/mediawiki/extensions/Wikibase/client/includes/Hooks/LoadExtensionSchemaUpdatesHookHandler.php(45): Wikibase\Client\Store\Sql\UnexpectedUnconnectedPagePrimer->__construct()
#1 /vagrant/mediawiki/includes/installer/DatabaseUpdater.php(604): Wikibase\Client\Hooks\LoadExtensionSchemaUpdatesHookHandler::primeUnexpectedUnconnectedPage()
#2 /vagrant/mediawiki/includes/installer/DatabaseUpdater.php(563): MediaWiki\Installer\DatabaseUpdater->runUpdates()
#3 /vagrant/mediawiki/maintenance/update.php(189): MediaWiki\Installer\DatabaseUpdater->doUpdates()
#4 /vagrant/mediawiki/maintenance/includes/MaintenanceRunner.php(696): UpdateMediaWiki->execute()
#5 /vagrant/mediawiki/maintenance/run.php(51): MediaWiki\Maintenance\MaintenanceRunner->run()
#6 /var/www/w/MWScript.php(99): require_once(string)
#7 {main}

Seen in Vagrant after installing the mediainfo role. The file exists on disk so not quite sure what's going on. Adding

require_once( "/vagrant/mediawiki/extensions/Wikibase/vendor/onoi/message-reporter/src/MessageReporter.php" );
require_once( "/vagrant/mediawiki/extensions/Wikibase/vendor/onoi/message-reporter/src/NullMessageReporter.php" );
require_once( "/vagrant/mediawiki/extensions/Wikibase/vendor/onoi/message-reporter/src/CallbackMessageReporter.php" );

to the beginning of UnexpectedUnconnectedPagePrimer.php fixed the error, so clearly some kind of autoloading problem.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Load composer autoloaderGergő Tiszamediawiki/extensions/Wikibasemaster+2 -0
Customize query in gerrit

Related Objects

Event Timeline

Tgr created this task.May 5 2024, 11:06 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 5 2024, 11:06 AM
Addshore awarded a token.May 5 2024, 11:11 AM
Tgr added a comment.May 5 2024, 11:28 AM

I can't reproduce it anymore (I guess I would have to undo the migration first) but I guess it's the thing where you have to tell extension.json you have composer dependencies, otherwise it might or might not break depending on how you use composer.

Maintenance_bot added a project: Wikidata.May 5 2024, 11:29 AM
gerritbot added a comment.May 5 2024, 11:34 AM

Change #1027561 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/Wikibase@master] Load composer autoloader

https://gerrit.wikimedia.org/r/1027561

gerritbot added a project: Patch-For-Review.May 5 2024, 11:34 AM
Lydia_Pintscher added a project: wmde-wikidata-tech.May 6 2024, 12:22 PM
Lucas_Werkmeister_WMDE added a project: [Archived]Wikidata Dev Team (Wikidata.org Slice).May 16 2024, 12:09 PM
Lucas_Werkmeister_WMDE moved this task from In Task Breakdown to Ready for Peer Review on the [Archived]Wikidata Dev Team (Wikidata.org Slice) board.
Lucas_Werkmeister_WMDE moved this task from Incoming to Ongoing on the wmde-wikidata-tech board.
Lucas_Werkmeister_WMDE subscribed.May 16 2024, 12:31 PM

Yeah, “Onoi” issues in Wikibase generally mean something’s wrong with the autoloader.

If I understand the load_composer_autoloader flag correctly, it’s probably only needed if you’re not using the composer merge plugin? I think we generally recommend that instead, but specifying the flag as well seems reasonable. Thanks for the Gerrit change!

Lucas_Werkmeister_WMDE moved this task from Ready for Peer Review to In Peer Review on the [Archived]Wikidata Dev Team (Wikidata.org Slice) board.May 16 2024, 12:31 PM
gerritbot added a comment.May 16 2024, 1:00 PM

Change #1027561 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Load composer autoloader

https://gerrit.wikimedia.org/r/1027561

Lucas_Werkmeister_WMDE closed this task as Resolved.May 16 2024, 1:02 PM
Lucas_Werkmeister_WMDE assigned this task to Tgr.
Lucas_Werkmeister_WMDE moved this task from In Peer Review to Done on the [Archived]Wikidata Dev Team (Wikidata.org Slice) board.

Since the issue isn’t reproducible anymore, let’s just hope it’s fixed now and close the task.

Maintenance_bot removed a project: Patch-For-Review.May 16 2024, 1:31 PM
ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.6; 2024-05-21).May 16 2024, 2:00 PM
Tgr added a comment.May 16 2024, 2:09 PM
In T364273#9804281, @Lucas_Werkmeister_WMDE wrote:

If I understand the load_composer_autoloader flag correctly, it’s probably only needed if you’re not using the composer merge plugin?

Yeah, it loads the autoloader.php file in the extension's vendor folder if it exists.

Lucas_Werkmeister_WMDE mentioned this in T364986: PHP 8.2 CI for OATHAuth on 1.42 fails due to missing pimple/container for Flow....May 17 2024, 8:54 AM
Lucas_Werkmeister_WMDE added a comment.May 17 2024, 9:13 AM
In T364273#9804281, @Lucas_Werkmeister_WMDE wrote:

I think we generally recommend [the composer merge plugin] instead

Though our README was a bit outdated in that regard – uploaded https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/1032720 to improve it.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits