Page MenuHomePhabricator

Mobile multimedia viewer not night mode friendly on bad connections
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:

Screenshot 2024-05-05 at 2.18.21 PM.png (1×3 px, 146 KB)

What should have happened instead?:
Icon and text should be readable

Screenshot 2024-05-05 at 2.19.17 PM.png (1×3 px, 148 KB)

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

  • Use @color-inverted-fixed instead.
  • Use a Codex icon instead of a ResourceLoaderImage icon.

Info for newcomers

  • Make sure you setup MobileFrontend https://mediawiki.org/wiki/extension:MobileFrontend
  • Your fixes should be made in resources/mobile.mediaViewer/ImageCarousel.less
  • The image is defined inside extension.json. Remove the image there and instead use .cdx-mixin-css-icon inside ImageCarousel.less instead.

QA Results - Beta

ACStatusDetails
1T364274#9979188

QA Results - PROD

ACStatusDetails
1T364274#9979189

Event Timeline

Thank you for tagging this task with good first task for Wikimedia newcomers!

Newcomers often may not be aware of things that may seem obvious to seasoned contributors, so please take a moment to reflect on how this task might look to somebody who has never contributed to Wikimedia projects.

A good first task is a self-contained, non-controversial task with a clear approach. It should be well-described with pointers to help a completely new contributor, for example it should clearly pointed to the codebase URL and provide clear steps to help a contributor get setup for success. We've included some guidelines at https://phabricator.wikimedia.org/tag/good_first_task/ !

Thank you for helping us drive new contributions to our projects <3

ovasileva triaged this task as Medium priority.May 9 2024, 10:06 AM

I am tring to solve this issue and have changed @color-inverted to @color-inverted-fixed, as it has beed asked https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/MobileFrontend/+/refs/heads/master/resources/mobile.mediaViewer/ImageCarousel.less#86

But I am having problem what other changes do I have to make in this :-

  • The image is defined inside extension.json. Remove the image there and instead use .cdx-mixin-css-icon inside ImageCarousel.less instead.
  • Use a Codex icon instead of a ResourceLoaderImage icon.

~ Thanks for the Help.

Hey there @Agamyasamuel ! Thanks for the offer of help!
It looks like since we wrote this ticket, things have got simpler. You should be able to fix this by making the change to --color-inverted-fixed as suggested.
You'll notice this also needs to apply to .mf-icon-alert-invert by updating the variable used here! https://gerrit.wikimedia.org/g/mediawiki/extensions/MobileFrontend/+/fb0fba95597633ef83e6a3bf58cc78758eecc569/resources/mobile.init.styles/icons.less#43

Let me know if you get stuck and feel free to push a patch even if it's not quite working to help troubleshoot!

Change #1052433 had a related patch set uploaded (by Agamyasamuel; author: Agamyasamuel):

[mediawiki/extensions/MobileFrontend@master] Fix: Mobile multimedia viewer not night mode friendly on bad connections

https://gerrit.wikimedia.org/r/1052433

Change #1052666 had a related patch set uploaded (by Agamyasamuel; author: Agamyasamuel):

[mediawiki/extensions/MobileFrontend@master] Fix: Mobile multimedia viewer not night mode friendly on bad connections

https://gerrit.wikimedia.org/r/1052666

Change #1052433 abandoned by Agamyasamuel:

[mediawiki/extensions/MobileFrontend@master] Fix: Mobile multimedia viewer not night mode friendly on bad connections

Reason:

#1052666
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MobileFrontend/+/1052666

https://gerrit.wikimedia.org/r/1052433

Change #1052666 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Fix: Mobile multimedia viewer not night mode friendly on bad connections

https://gerrit.wikimedia.org/r/1052666

Glad I could Help @Jdlrobson 😊 Thanks to the awesome Wiki community that helps when we get stuck.

Test Result - Beta

Status: ✅ PASS
Environment: Beta
OS: macOS Sonoma 14.5
Browser: Chrome 126
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps
  1. Visit https://en.m.wikipedia.beta.wmflabs.org/wiki/California
  2. Disable network in your chrome developer tools
  3. Click an image
Mobile
2024-07-13_08-43-45.png (967×2 px, 87 KB)
GMikesell-WMF assigned this task to ovasileva.
GMikesell-WMF updated the task description. (Show Details)
GMikesell-WMF subscribed.

Test Result - PROD

Status: ✅ PASS
Environment: PROD
OS: macOS Sonoma 14.5
Browser: Chrome 126
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps
  1. Visit https://en.m.wikipedia.org/wiki/California
  2. Disable network in your chrome developer tools
  3. Click an image
Mobile
2024-07-13_08-41-21.png (815×1 px, 70 KB)