Page MenuHomePhabricator

"Next #" link is displayed even if there are no more entries.
Closed, ResolvedPublic

Description

Author: christof

Description:
If you go to the Special:Log page and press the "Next #" link until you see the
last log entry, you can press it even more and are presented with empty lists.
Google-Bot is following these links until it gets bored, one for each increment.


Version: 1.4.x
Severity: minor
OS: Linux
Platform: PC
URL: http://krass.com/wiki/index.php?title=Special:Log&limit=500&offset=1000&type=&user=&page=

Details

Reference
bz1644
TitleReferenceAuthorSource BranchDest Branch
analytics_product: T&S admin actions: fix MW sensorrepos/data-engineering/airflow-dags!795bearlogafix-tsp-metrics-dagmain
Update function-schemata sub-module to HEAD (18c7b06)repos/abstract-wiki/wikifunctions/wikilambda-cli!44jforrestersync-function-schematamain
Update function-schemata sub-module to HEAD (18c7b06)repos/abstract-wiki/wikifunctions/function-orchestrator!206jforrestersync-function-schematamain
Update function-schemata sub-module to HEAD (18c7b06)repos/abstract-wiki/wikifunctions/function-evaluator!238jforrestersync-function-schematamain
LoggerWrapper: Set x-request-id, not requestId, in log inforepos/abstract-wiki/wikifunctions/function-schemata!138jforresterlogger-x-request-idmain
Draft: [BREAKING CHANGE] Use new createZObjectKey.repos/abstract-wiki/wikifunctions/function-orchestrator!200apineapine-no-stable-stringifymain
Update function-schemata sub-module to HEAD (eb689ce)repos/abstract-wiki/wikifunctions/wikilambda-cli!43jforrestersync-function-schematamain
Update function-schemata sub-module to HEAD (eb689ce)repos/abstract-wiki/wikifunctions/function-evaluator!231jforrestersync-function-schematamain
Update function-schemata sub-module to HEAD (eb689ce)repos/abstract-wiki/wikifunctions/function-orchestrator!198jforrestersync-function-schematamain
Adjust existing logging to new changes in schemata/LoggerWrapperrepos/abstract-wiki/wikifunctions/function-evaluator!230ecarggrace/T364413/begin-update-logging-to-standardmain
Adjust logging to new LoggerWrapper changes in function-schematarepos/abstract-wiki/wikifunctions/function-orchestrator!197ecarggrace/T364413/begin-update-logging-to-standardmain
Update function-schemata sub-module to HEAD (851131f)repos/abstract-wiki/wikifunctions/function-orchestrator!193jforrestersync-function-schematamain
Update function-schemata sub-module to HEAD (851131f)repos/abstract-wiki/wikifunctions/function-evaluator!227jforrestersync-function-schematamain
Update function-schemata sub-module to HEAD (851131f)repos/abstract-wiki/wikifunctions/wikilambda-cli!41jforrestersync-function-schematamain
[BREAKING CHANGE] Refactor LoggerWrapper for better outputs to LogStashrepos/abstract-wiki/wikifunctions/function-schemata!127ecarggrace/T364413/update-logging-to-standardmain
Add new logs for debuggingrepos/abstract-wiki/wikifunctions/function-evaluator!226ecarggrace/T364413/update-logging-to-standardmain
Add new logs for debuggingrepos/abstract-wiki/wikifunctions/function-orchestrator!187ecarggrace/T364413/update-logging-to-standardmain
Adjust logger to reflect MW standardrepos/abstract-wiki/wikifunctions/function-schemata!123ecarggrace/T364413/update-logging-to-standardmain
Draft: Adjust our logging to fit MW standardrepos/abstract-wiki/wikifunctions/function-orchestrator!186ecarggrace/T364413/update-logging-to-standardmain
cloudvps_flavors: Support setting per-project flavors per deploymentrepos/cloud/cloud-vps/tofu-infra!2taavitaavi/flavorsmain
Show related patches Customize query in GitLab

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 8:13 PM
bzimport set Reference to bz1644.
bzimport added a subscriber: Unknown Object (MLST).

Michael.Keppler wrote:

patch for HEAD

The patch adds a private variable to the log reader to count the number of log
lines shown. Depending on that number the links are shown or not.

Additionally the patch fixes another bug (without bugzilla entry). For an empty
log there is a mysql warning shown when trying to do seek(0) on the mysql
result. The patch avoids that warning.

Attached:

jeluf wrote:

Rewrote patch and committed to CVS HEAD.

SpecialLog.php, rev 1.21