Page MenuHomePhabricator

"Next #" link is displayed even if there are no more entries.
Closed, ResolvedPublic

Description

Author: christof

Description:
If you go to the Special:Log page and press the "Next #" link until you see the
last log entry, you can press it even more and are presented with empty lists.
Google-Bot is following these links until it gets bored, one for each increment.


Version: 1.4.x
Severity: minor
OS: Linux
Platform: PC
URL: http://krass.com/wiki/index.php?title=Special:Log&limit=500&offset=1000&type=&user=&page=

Details

Reference
bz1644
TitleReferenceAuthorSource BranchDest Branch
Draft: Improve logging in evaluatorrepos/abstract-wiki/wikifunctions/function-evaluator!226ecarggrace/T364413/update-logging-to-standardmain
Draft: Improve logging in orchestratorrepos/abstract-wiki/wikifunctions/function-orchestrator!187ecarggrace/T364413/update-logging-to-standardmain
Adjust logger to reflect MW standardrepos/abstract-wiki/wikifunctions/function-schemata!123ecarggrace/T364413/update-logging-to-standardmain
Draft: Adjust our logging to fit MW standardrepos/abstract-wiki/wikifunctions/function-orchestrator!186ecarggrace/T364413/update-logging-to-standardmain
cloudvps_flavors: Support setting per-project flavors per deploymentrepos/cloud/cloud-vps/tofu-infra!2taavitaavi/flavorsmain
Manage new flavorsrepos/cloud/cloud-vps/tofu-infra!1taavitaavi/flavorsmain
Prod monitoring: fix so we can emit all four metricsrepos/abstract-wiki/wikifunctions/function-orchestrator!181ecarggrace/T364410/debugging-prod-resp-count-metricsmain
Define path as "phabricator/" rather than "phorge/"repos/phabricator/arcanist!2ppperyplatformpathwmf/stable
Add repos/data-engineering/kubernetes/csi to the trusted-runnersrepos/releng/gitlab-trusted-runner!75btullisadd_kubernetes_csimain
acme_chief,x509: Provide private key first filesrepos/sre/acme-chief!7vgutierrezT364424main
gitlab and concurrency fixestoolforge-repos/wikibugs2!37bd808work/bd808/gitlabmain
Show related patches Customize query in GitLab

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 8:13 PM
bzimport set Reference to bz1644.
bzimport added a subscriber: Unknown Object (MLST).

Michael.Keppler wrote:

patch for HEAD

The patch adds a private variable to the log reader to count the number of log
lines shown. Depending on that number the links are shown or not.

Additionally the patch fixes another bug (without bugzilla entry). For an empty
log there is a mysql warning shown when trying to do seek(0) on the mysql
result. The patch avoids that warning.

Attached:

jeluf wrote:

Rewrote patch and committed to CVS HEAD.

SpecialLog.php, rev 1.21