Page MenuHomePhabricator
Create Task
Maniphest T364420

QA Editing-related night mode changes (desktop)
Closed, DuplicatePublic
Actions

Description

In T360691, we QA'd Editing-related night mode changes on mobile. This task involves doing similar work on desktop.

This task involves the work of:

  1. Identifying issues stemming from night mode within Editing Team-owned experiences
  2. Determining which – if any – team will be responsible for fixing the issues "1)" will have identified

Issues

IssueScreenshotAffected interfaceTeam responsible for fixTicket (if needed)

Steps

Per previous discussions between the Editing and Web Teams, work on this task will progress in the following way...

  1. For each issue, Editing + Web Teams will explicitly decide who is best positioned to fix said issue
  2. Editing Team will block making any fixes they are responsible for on the Web Team fully implementing night mode within editing interface.
    • Reason: Avoids potential for duplicate work to be done by improving a state that has, or will soon be made, made obsolete by a newer implementation.

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedovasilevaT341631 [EPIC] Q1 Main hypothesis: Typographical and palette customizations
 ResolvedovasilevaT341632 [EPIC] Palette customizations and dark mode
 ResolvedovasilevaT354835 [epic] Release night mode as a beta feature on desktop and mobile
 ResolvedJdlrobsonT354836 [goal] Allow desktop and mobile page chrome to appear in night mode ahead of beta release
 ResolvedovasilevaT354837 [Night mode] Page background appears in night mode on desktop
ResolvedovasilevaT354838 [Night mode] Page background appears in night mode on mobile
 ResolvedJScherer-WMFT356825 Implement the new night mode color palette in Minerva
 ResolvedovasilevaT357759 Deploy night mode on the minerva skin on test wiki
 ResolvedSpikeSToyofuku-WMFT357077 [Spike] Explore different options for code sharing of page-specific configuration between Minerva and Vector
 ResolvedovasilevaT354842 [Night mode] All global navigation open by default appear in night mode on desktop
 ResolvedovasilevaT354843 [Night mode] Make all open-by-default global navigation appear in night mode on mobile
 ResolvedJdlrobsonT356074 Implement the dark mode color palette and switch LESS variables in Minerva to use it, degrade support for browsers that do not support CSS custom properties
 ResolvedovasilevaT356900 Regression: Issues with color-subtle (Codex .cdx-mixin-css-icon mixin doesn't work with CSS variables)
 ResolvedBUG REPORTJdlrobsonT356928 Regression: Visited links on mobile appearing as black
 ResolvedBUG REPORTJScherer-WMFT357381 Regression: Active link color is broken on mobile
 ResolvedJdlrobsonT356344 [Night mode] Templates can be fixed by editors when necessary for night mode
 DuplicateFeatureNoneT353887 Support prefers-color-scheme in css-sanitizer
 ResolvedSpikeJdlrobsonT356432 [spike] Audit broken experiences in templates night mode
 ResolvedJdlrobsonT357453 WCAG Color Contrast Violations in Infobox on Minerva Skin Night Mode
 ResolvedovasilevaT359658 [QA task] WCAG Color Contrast Violations in Infobox on Minerva Skin Night Mode
 ResolvedFeatureJdlrobsonT241946 Support @media (prefers-color-scheme: ...) rule in css-sanitizer
 DuplicateNoneT357585 WCAG Color Contrast Violations in Tables with Inline Style Attributes on Minerva Night Mode
 ResolvedJdlrobsonT357717 Color Contrast Issue on Wikipedia Portal: Current Events
 ResolvedovasilevaT357721 Hatnote Color Contrast Issues Across Wikipedia Pages on Minerva Night Mode
 DuplicateJdlrobsonT358007 [French Wikipedia] Minerva Night Mode Color Contrast Issue - links in .bandeau-container .bandeau-section.bandeau-niveau-information
 ResolvedJdlrobsonT357730 Template:Track listing has color contrast issues with Minerva Night Mode
 DuplicateNoneT357733 Color Contrast Issue in ambox
 ResolvedJdlrobsonT357735 Color contrast issues with Template:Quote_box in Minerva Night Mode
 ResolvedBUG REPORTovasilevaT358608 Phonos is not night mode friendly
 ResolvedovasilevaT357998 Address color contrast issues in .wikitable
 InvalidNoneT358000 Color Contrast Error - [style] Styling in .reference > a Element in Minerva Night Mode
 InvalidJdlrobsonT358004 Color Contrast Issue in Minerva Night Mode - table.sidebar Template
 DuplicateNoneT358005 Minerva Night Mode Color Contrast Issue - current-events-sidebar (Portal Pages)
 DuplicateNoneT358010 Main Page Template Color Contrast Issue in Minerva Night Mode
 DuplicateNoneT358013 Citation Reference Color Contrast Issue - Minerva Night Mode
 DuplicateNoneT358014 Color Contrast Issue in Minerva Night Mode - .colonnes.liste-simple
 ResolvedovasilevaT358015 Color Contrast Issue in Minerva Night Mode - a.mw-redirect
 ResolvedJdlrobsonT358387 [EPIC] Ensure all template text is readable in night mode: Fix all templates using background without color
 ResolvedJdlrobsonT358164 Set color/background to inherit or #333 on common templates/use of HTML4 bgcolor
 ResolvedJdlrobsonT358012 Navbox Related Color Contrast Issue in Minerva Night Mode
 ResolvedJdlrobsonT357726 Color contrast issue with Template:Side_box in Minerva Night Mode
 DuplicateJdlrobsonT358016 Other Projects Template Color Contrast Issue - Minerva Night Mode
 ResolvedJdlrobsonT358385 Address issues with usage of [bgcolor]
 ResolvedJdlrobsonT356899 [Spike] Explore automatic night mode fixes with content transform team
 DeclinedJdlrobsonT358239 Automatic Correction of Template and Inline Styles
 ResolvedSToyofuku-WMFT358240 [Spike 4hours] Performance Impact Assessment for Night Mode Style Correction
 ResolvedJdlrobsonT358388 Tag problematic pages with tracking category
 ResolvedKSarabia-WMFT358003 [3hr] [FRENCH WIKIPEDIA] Color Contrast Issue in Minerva Night Mode - .alternance
 ResolvedNoneT359488 Make MediaWiki:Minerva.css render blocking to allow editors to ship styles that fix issues with night mode
 ResolvedovasilevaT359644 Apply night mode fixes to French infoboxes
 ResolvedJdlrobsonT360683 How should Template:Color work in night mode?
 ResolvedBUG REPORTJdlrobsonT360844 Links in elements with background color should become black so they are accessible
 DuplicateBUG REPORTNoneT365318 Dark/night mode shouldn't reset .metadata styles
 ResolvedBUG REPORTovasilevaT357179 Page issues as rendered in article is not compatible with night mode
 ResolvedBUG REPORTovasilevaT356822 Minerva/MobileFrontend icons not using embedded data URI rules should be compatible with night mode
 ResolvedBUG REPORTabi_T356821 Make <languages> compatible with night mode by using Codex design tokens
 ResolvedBUG REPORTNikerabbitT358381 Make Translate outdated translations text compatible with night mode
 ResolvedBUG REPORTovasilevaT359081 [Bug] Page previews currently does not work in night mode.
 ResolvedJdlrobsonT360877 [Bug] Page previews gradient not working in night mode
ResolvedBUG REPORTJdlrobsonT358822 Translate extension needs to import mediawiki.skin.variables to get night mode
 ResolvedovasilevaT356341 [Night Mode] I want to opt into or out of night mode on mobile
 ResolvedovasilevaT355065 Set up feature flag and menu for night mode on desktop
 ResolvedovasilevaT357707 Re-order Vector preferences - night mode should be above limited width
 ResolvedovasilevaT355118 Set up feature flag for night mode on mobile
 ResolvedovasilevaT355705 Allow pages to not appear in night mode
ResolvedFeatureNoneT328850 Minerva/Vector: Dark mode toggle needs to be tri state
 ResolvedovasilevaT356653 Show a toast notification on page load for night mode when the setting doesn't take effect in Minerva
 ResolvedovasilevaT358811 Set Minerva default to day mode
 ResolvedovasilevaT361047 Minerva Night Mode launch notifications
 ResolvedovasilevaT356434 [Night Mode] All pages and overlays that can be accessed within 2 clicks by a logged in user (AMC disabled) appear in night mode on mobile
 ResolvedovasilevaT359152 Deploy initial version of night mode to pilot wikis on the mobile website for testing
 ResolvedovasilevaT359183 Exclude non-functional pages from night mode
 ResolvedBUG REPORTovasilevaT359958 Exclude list is not working for special page names
 ResolvedJdlrobsonT358238 Implement Linting Rule for Template Style Fixes
 ResolvedJdlrobsonT359205 Deployment Ticket - Linting Rule for Template Style Fixes
 ResolvedNoneT358241 Document new night mode linting rules
 ResolvedJdrewniakT358059 Use Codex experimental build in Minerva to allow codex components to appear in night mode
 ResolvedovasilevaT357722 Main pages should work in night mode
 ResolvedBUG REPORTovasilevaT358528 Mobile editor inconsistently renders both night mode and light mode elements
 ResolvedovasilevaT358797 Autocorrect content which uses inline styles using background without color
 ResolvedovasilevaT359571 Add note specifying night mode release is experimental
 ResolvedJdlrobsonT360132 QA: Night mode linting rule
 ResolvedJdlrobsonT359983 Rename the skin night mode classes to something more sensible before they become widely used
 ResolvedovasilevaT363814 Release dark mode as a beta feature on desktop (May 15th)
ResolvedJdrewniakT354889 Vector 2022 should get night theme
 ResolvedJScherer-WMFT354891 [Design] Implement the dark mode color palette and switch LESS variables in Vector to use it
 ResolvedovasilevaT361157 Change "Night" to "Dark" in Appearance settings
 ResolvedovasilevaT362726 [config] Enable night mode styles on Vector 2022 skin
 ResolvedBUG REPORTovasilevaT363779 [Bug] Echo not compatible with desktop night theme
 ResolvedBUG REPORTovasilevaT363861 Visual Editor overlays do not work in night theme
 ResolvedJdlrobsonT363920 Migrate ResourceLoader Icons in Vector to use Codex
 ResolvedovasilevaT367150 Deploy dark mode to logged-out users in tier 1 and 2 wikis on the Vector2022 and Minerva skin
 ResolvedovasilevaT366738 ULS should have a dark theme
 ResolvedovasilevaT365509 Enable night mode on talk page namespaces
 ResolvedovasilevaT366378 [Config change] Enable night theme on preferences pages
 ResolvedovasilevaT360656 [GOAL] Interfaces using OOUI should work in night mode
 InvalidBUG REPORTNoneT358410 Special:MovePage has color contrast issue in night mode
 ResolvedSgsT366760 [EPIC] Dark mode for Growth team maintained features
 ResolvedBUG REPORTovasilevaT358405 Special:Notifications should work in night mode
 ResolvedDTorsani-WMFT355147 [EPIC] Dark Mode
 ResolvedVolker_ET334790 tokens: Implement new static layout background-color tokens
 ResolvedovasilevaT366520 [Config] Dark mode is not available on Special:ApiSandbox
 ResolvedBUG REPORTovasilevaT357575 File pages are not compatible with night mode
 DuplicateBUG REPORTNoneT366336 Color contrast: Non JavasScript editor should use design tokens to work in dark mode
 ResolvedovasilevaT366375 Special:QrCode and Special:UrlShortener has night mode issues
 ResolvedJdlrobsonT364777 [EPIC] Enable dark mode in OOUI
 DeclinedFeatureegardnerT363849 [OOUI] Make WikimediaUI theme compatible with CSS custom properties and future versions Codex Design Tokens
 DuplicateNoneT364420 QA Editing-related night mode changes (desktop)
 DeclinedFeatureegardnerT363857 [OOUI] Make WikimediaUI theme compatible with 'rem' units and future versions Codex Design Tokens
 DuplicateCCiufo-WMFT365521 QA Editing-related REM changes
 ResolvedovasilevaT365764 [OOUI] Icons: Add support for use in dark mode
 ResolvedNBaca-WMFT366709 [Spike] Make a decision on what needs to happen for icons before the new OOUI release
 DeclinedVolker_ET366101 [OOUI] Fix font size inconsistencies across skins with `rem` based sizing

Event Timeline

ppelberg created this task.May 7 2024, 6:33 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 7 2024, 6:33 PM
ppelberg mentioned this in T360691: QA Editing-related OOUI updates (mobile + desktop).May 7 2024, 6:33 PM
ppelberg updated the task description. (Show Details)
ppelberg moved this task from Untriaged to Upcoming on the Editing-team board.May 9 2024, 6:50 PM
ovasileva moved this task from Incoming to Tracking on the Web-Team-Backlog-Archived board.May 16 2024, 9:48 AM

@ppelberg - the beta feature is now available on desktop so testing can start

ppelberg added a parent task: T363849: [OOUI] Make WikimediaUI theme compatible with CSS custom properties and future versions Codex Design Tokens.EditedMay 21 2024, 6:32 PM
ppelberg added a project: Editing QA.
In T364420#9803704, @ovasileva wrote:

@ppelberg - the beta feature is now available on desktop so testing can start

Sounds great. Although, per today's offline discussion the Editing Team is going to wait on prioritize further dark mode/REM-related QA until we've heard back from Design-System-Team (by way of @CCiufo-WMF) about whether we'll begin this QA before T363857 is done.

ppelberg removed a project: Editing QA.May 21 2024, 6:35 PM
ppelberg added a subscriber: CCiufo-WMF.
ppelberg mentioned this in T365521: QA Editing-related REM changes.May 21 2024, 6:50 PM
ppelberg closed this task as a duplicate of T360691: QA Editing-related OOUI updates (mobile + desktop).May 30 2024, 10:38 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits