Page MenuHomePhabricator

1.19 change to display bytes added by [edit], as opposed to total page size after [edit]
Closed, ResolvedPublic


So, 1.19 means that page histories, instead of displaying the total size of a page in rounded brackets by each edit, display the number of bytes added or subtracted in the same way that Special:RecentChanges or Special:Watchlist do. This is on occasion useful, but there are a lot of things that, communally, we've built on the implicit assumption that an editor can easily see the total size of a page. An example, on enwiki, is - the general guideline rule of thumb for when a page has become Too Large, and should be split. It's based around size in kb, and the 1.19 change means that can't easily be found any more. Even on pages not ruled by this (talkpages, ferinstance) it's still a useful rule of thumb. The only real alternative is to wait until browsers start to lag before you do anything.

That being said, I find knowing how much was added/taken away to be really useful. Maybe it should be (pagesize) +bytesadded instead of having to choose between (pagesize) and (bytesadded).

Version: 1.19
Severity: normal



Event Timeline

bzimport raised the priority of this task from to Unbreak Now!.Nov 22 2014, 12:18 AM
bzimport set Reference to bz34449.

I agree, delta is useful mostly for patroller not for working on article itself, on wikisource size gave us an estimate of the amount of work to do on a page, e.g. to reformat a page to know if it's worth to do it it manually or to use a bot.

I don't see why we can't have both, unless there's a technical reason as to why. Oliver's suggestion sounds good.

(In reply to comment #3)

I don't see why we can't have both, unless there's a technical reason as to
why. Oliver's suggestion sounds good.

Any good UI suggestions that avoid clutter? As long as the diff sizes stay, I'm probably happy.

I don't know if it is *possible* to avoid clutter on these pages. Ideally we'll eventually find a new way of displaying this kind of information but right now I can't see it. It's probably only an additional 10-15 characters, maximum, so I think we can just in-line it for now.

Colorizing the size changes will be good.

Done in r111800. Deployed to cluster.

See the revision, the size is inside the tooltip of the byte change. The bytechange is colored already.

Personally I think this would have been better as an optional parameter $2 to rc-change-size-new (that's not displayed by default). That way any community that super relies on it could customize it whichever way they like. Most people who don't care about it wouldn't see two things that are almost the exact same (Especially since all you have to do is hover to see the other value).

Anyhow, I rather dislike this change.