Page MenuHomePhabricator

namespaceDupes is not respecting links migration stage (again)
Closed, ResolvedPublic

Description

This broke replication to five hosts today.

Event Timeline

Just for the record, the fix was:

  • Re-add the columns:
set session sql_log_bin=0; alter table pagelinks add column `pl_title` varbinary(255) NOT NULL DEFAULT '', add column `pl_namespace` int(11) NOT NULL DEFAULT 0;
  • Restart replication
Ladsgroup moved this task from Triage to In progress on the DBA board.

Change #1029576 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] Disable namespaceDupes again

https://gerrit.wikimedia.org/r/1029576

Change #1029547 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@wmf/1.43.0-wmf.4] Disable namespaceDupes again

https://gerrit.wikimedia.org/r/1029547

Change #1029548 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@wmf/1.43.0-wmf.3] Disable namespaceDupes again

https://gerrit.wikimedia.org/r/1029548

Pending: Drop the columns again in db1189

Change #1029547 merged by jenkins-bot:

[mediawiki/core@wmf/1.43.0-wmf.4] Disable namespaceDupes again

https://gerrit.wikimedia.org/r/1029547

Change #1029576 merged by jenkins-bot:

[mediawiki/core@master] Disable namespaceDupes again

https://gerrit.wikimedia.org/r/1029576

Change #1029548 merged by jenkins-bot:

[mediawiki/core@wmf/1.43.0-wmf.3] Disable namespaceDupes again

https://gerrit.wikimedia.org/r/1029548

Mentioned in SAL (#wikimedia-operations) [2024-05-09T14:52:10Z] <ladsgroup@deploy1002> Started scap: Backport for [[gerrit:1029547|Disable namespaceDupes again (T364546)]], [[gerrit:1029548|Disable namespaceDupes again (T364546)]]

Mentioned in SAL (#wikimedia-operations) [2024-05-09T14:54:49Z] <ladsgroup@deploy1002> ladsgroup: Backport for [[gerrit:1029547|Disable namespaceDupes again (T364546)]], [[gerrit:1029548|Disable namespaceDupes again (T364546)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-05-09T15:08:12Z] <ladsgroup@deploy1002> Finished scap: Backport for [[gerrit:1029547|Disable namespaceDupes again (T364546)]], [[gerrit:1029548|Disable namespaceDupes again (T364546)]] (duration: 16m 02s)

FWIW, the query is this:

UPDATE /* NamespaceDupes::movePage  */  `pagelinks` SET pl_from_namespace = 4 WHERE ((pl_from = 13779 AND (pl_namespace = 0 AND pl_title IN ('Qhichwa_simi','Wikipidiya:Qulluy'...
Ladsgroup edited projects, added MediaWiki-Maintenance-system; removed DBA.

At least we know it's not going to break replication again but someone needs to fix the underlying problem. I might get to it eventually but no cookie licking so if someone else is willing to, sure.

Change #1032022 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] maintenance: Check PageLinksSchemaMigrationStage in namespaceDupes.php

https://gerrit.wikimedia.org/r/1032022

Change #1032022 merged by jenkins-bot:

[mediawiki/core@master] maintenance: Check PageLinksSchemaMigrationStage in namespaceDupes.php

https://gerrit.wikimedia.org/r/1032022