Page MenuHomePhabricator

Visual Diff not working
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Go to a random page
  • Edit the page using the visual editor (not the VE source editor)
  • Click save
  • Check the diff, make sure the visual option is selected

What happens?:
Loader stays shown and no diff is shown

What should have happened instead?:
Changes made should be shown, with added text in green background and removed text in red background

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):
Error in browser console:

jQuery.Deferred exception: visualDiffGenerator is not a function ve.ui.MWSaveDialog.prototype.setDiffAndReview/this.getDiffElementPromise/<@https://nl.wikipedia.org/w/load.php?lang=nl&modules=ext.visualEditor.articleTarget%2Cbase%2Ccore%2CdesktopTarget%2Cdiffing%2Cicons%2Clanguage%2Cmediawiki%2Cmwalienextension%2Cmwcore%2Cmwextensions%2Cmwformatting%2Cmwgallery%2Cmwimage%2Cmwlanguage%2Cmwlink%2Cmwmeta%2Cmwsave%2Cmwsignature%2Cmwtransclusion%2Cmwwikitext%2Csanitize%2Cswitching%2Cwelcome%7Cext.visualEditor.core.desktop%2Cutils%7Cext.visualEditor.mwextensions.desktop%7Cext.visualEditor.mwimage.core&skin=vector-2022&version=fs8oj:1667:232
mightThrow@https://nl.wikipedia.org/w/load.php?lang=nl&modules=ext.centralNotice.bannerHistoryLogger%2CchoiceData%2Cdisplay%2CgeoIP%2CimpressionDiet%2CkvStore%2ClargeBannerLimit%2ClegacySupport%2CstartUp%7Cext.centralauth.centralautologin%7Cext.checkUser.clientHints%7Cext.cx.eventlogging.campaigns%7Cext.discussionTools.init%2Cminervaicons%7Cext.echo.centralauth%7Cext.eventLogging%2CnavigationTiming%2Cpopups%2CwikimediaEvents%7Cext.uls.interface%2Cpreferences%2Cwebfonts%7Cext.urlShortener.toolbar%7Cjquery%2Cmoment%2Coojs%2Coojs-ui-core%2Coojs-ui-windows%2Crangefix%2Csite%7Cjquery.client%2CtextSelection%7Cmediawiki.String%2CTitle%2CUri%2Capi%2Cbase%2Ccldr%2Ccookie%2Cexperiments%2CjqueryMsg%2Clanguage%2Crouter%2Cstorage%2Ctoc%2Cuser%2Cutil%2CvisibleTimeout%7Cmediawiki.editfont.styles%7Cmediawiki.libs.pluralruleparser%7Cmediawiki.page.ready%7Cmediawiki.page.watch.ajax%7Cmmv.bootstrap%2Ccodex%2Chead%7Cmmv.bootstrap.autostart%7Coojs-ui-windows.icons%7Cskins.vector.clientPreferences%2Cjs%7Cskins.vector.icons.js%7Cwikibase.client.vector-2022&skin=vector-2022&version=33hay:577:648
Deferred/then/resolve/</process<@https://nl.wikipedia.org/w/load.php?lang=nl&modules=ext.centralNotice.bannerHistoryLogger%2CchoiceData%2Cdisplay%2CgeoIP%2CimpressionDiet%2CkvStore%2ClargeBannerLimit%2ClegacySupport%2CstartUp%7Cext.centralauth.centralautologin%7Cext.checkUser.clientHints%7Cext.cx.eventlogging.campaigns%7Cext.discussionTools.init%2Cminervaicons%7Cext.echo.centralauth%7Cext.eventLogging%2CnavigationTiming%2Cpopups%2CwikimediaEvents%7Cext.uls.interface%2Cpreferences%2Cwebfonts%7Cext.urlShortener.toolbar%7Cjquery%2Cmoment%2Coojs%2Coojs-ui-core%2Coojs-ui-windows%2Crangefix%2Csite%7Cjquery.client%2CtextSelection%7Cmediawiki.String%2CTitle%2CUri%2Capi%2Cbase%2Ccldr%2Ccookie%2Cexperiments%2CjqueryMsg%2Clanguage%2Crouter%2Cstorage%2Ctoc%2Cuser%2Cutil%2CvisibleTimeout%7Cmediawiki.editfont.styles%7Cmediawiki.libs.pluralruleparser%7Cmediawiki.page.ready%7Cmediawiki.page.watch.ajax%7Cmmv.bootstrap%2Ccodex%2Chead%7Cmmv.bootstrap.autostart%7Coojs-ui-windows.icons%7Cskins.vector.clientPreferences%2Cjs%7Cskins.vector.icons.js%7Cwikibase.client.vector-2022&skin=vector-2022&version=33hay:578:309
 undefined

Issue occurs in Chrome and Firefox, logged in and not logged in

I can reproduce the issue on Dutch Wikipedia and Wikidata. Haven't checked other projects.

Event Timeline

Same here. Safemode, Firefox 125 on Linux, Monobook or Vector-2022. Also reported by another user at enwiki help desk.

Change #1030300 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] ArticleTarget: Fix return of getVisualDiffGeneratorPromise

https://gerrit.wikimedia.org/r/1030300

Change #1030300 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] ArticleTarget: Fix return of getVisualDiffGeneratorPromise

https://gerrit.wikimedia.org/r/1030300

Change #1030308 had a related patch set uploaded (by Bartosz Dziewoński; author: Esanders):

[mediawiki/extensions/VisualEditor@wmf/1.43.0-wmf.4] ArticleTarget: Fix return of getVisualDiffGeneratorPromise

https://gerrit.wikimedia.org/r/1030308

Change #1030308 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@wmf/1.43.0-wmf.4] ArticleTarget: Fix return of getVisualDiffGeneratorPromise

https://gerrit.wikimedia.org/r/1030308

Mentioned in SAL (#wikimedia-operations) [2024-05-13T13:29:44Z] <logmsgbot> lucaswerkmeister-wmde@deploy1002 Started scap: Backport for [[gerrit:1029564|specials: Fix "include templates" query builder for Special:Export (T364554)]], [[gerrit:rOMWC103030846065|ArticleTarget: Fix return of getVisualDiffGeneratorPromise (T364635)]]

Mentioned in SAL (#wikimedia-operations) [2024-05-13T13:32:09Z] <logmsgbot> lucaswerkmeister-wmde@deploy1002 umherirrender and lucaswerkmeister-wmde and matmarex: Backport for [[gerrit:1029564|specials: Fix "include templates" query builder for Special:Export (T364554)]], [[gerrit:rOMWC103030846065|ArticleTarget: Fix return of getVisualDiffGeneratorPromise (T364635)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-05-13T13:45:48Z] <logmsgbot> lucaswerkmeister-wmde@deploy1002 Finished scap: Backport for [[gerrit:1029564|specials: Fix "include templates" query builder for Special:Export (T364554)]], [[gerrit:rOMWC103030846065|ArticleTarget: Fix return of getVisualDiffGeneratorPromise (T364635)]] (duration: 16m 04s)

• matmarex assigned this task to Esanders.