Translated content (i.e. anything outside of en/qqq.json) is effectively owned by TranslateWiki and their bot which self +2s. Flagging issues with the data and blocking CI (e.g. trailing whitespace) is useless as the data should only be fixed upstream.
At most we should show a warning when such issues are detected.
Description
Description
Details
Details
Related Changes in Gerrit:
Customize query in gerrit
Related Changes in GitLab:
| Title | Reference | Author | Source Branch | Dest Branch | |
|---|---|---|---|---|---|
| Downgrade errors with translated data (in default config) to warnings | repos/ci-tools/banana-checker!13 | esanders | warn | main |
Related Objects
Related Objects
- Mentioned In
- T364742: Trailing spaces exported from translatewiki.net
- Mentioned Here
- T22076: Template Parser does not treat ideographic spaces and non-breaking spaces as whitespace
T364742: Trailing spaces exported from translatewiki.net
T91707: L10n-bot should not force-merge / override Jenkins (breaks the build)
T258381: l10n-bot may export empty translations to Git, making banana tests fail
Event Timeline
Comment Actions
This appears to be a new issue with grunt-banana-checker 0.12.0, which turned on whitespace checks by default for all languages.
Comment Actions
esanders opened https://gitlab.wikimedia.org/repos/ci-tools/banana-checker/-/merge_requests/13
Downgrade errors with translated data (in default config) to warnings
Comment Actions
CI is failing on all patches in CentralAuth extension after https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralAuth/+/1030782.
Running "banana:SpecialCentralAuth" (banana) task >> The "zh-hant" translation has 1 translation with trailing whitespace: >> The translation of "apihelp-query+globaluserinfo-example-2" has trailing whitespace. Warning: Task "banana:SpecialCentralAuth" failed. Use --force to continue.
Comment Actions
Interestingly, the translation in question has been unchanged since 2014.
With it containing the trailing space since that same revision.
This suggests there is an additional issue where translatewiki, starting this month?, is now exporting trailing spaces into i18n commits where previously it was somehow trimmed away?
Comment Actions
Change #1031467 had a related patch set uploaded (by Krinkle; author: SD0001):
[mediawiki/extensions/Scribunto@master] Revert "Localisation updates from https://translatewiki.net."
Comment Actions
Change #1031467 merged by jenkins-bot:
[mediawiki/extensions/Scribunto@master] Revert "Localisation updates from https://translatewiki.net."
Comment Actions
Change #1031852 had a related patch set uploaded (by Krinkle; author: Krinkle):
[mediawiki/extensions/CentralAuth@master] Revert "build: Updating grunt-banana-checker to 0.12.0"
Comment Actions
Change #1031852 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@master] Revert "build: Updating grunt-banana-checker to 0.12.0"
Comment Actions
It has always exported them, but the recent dependency upgrades auto-fixed them, and the localisation exports are just restoring them. For example:
Comment Actions
jforrester merged https://gitlab.wikimedia.org/repos/ci-tools/banana-checker/-/merge_requests/13
Downgrade errors with translated data (in default config) to warnings
Comment Actions
In some cases the !!FUZZY!! was at end of the string and the trailing whitespace was there after stripping the fuzzy tag, maybe the Translate extension needs to trim() after stripping
- https://translatewiki.net/w/i.php?title=MediaWiki:Project-localized-name-srnwiki/ksh&diff=prev&oldid=12411565
- https://translatewiki.net/w/i.php?title=MediaWiki:Oathauth-validatedoath/ksh&diff=prev&oldid=12411474
- https://translatewiki.net/w/i.php?title=MediaWiki:Fancycaptcha-desc/ksh&diff=prev&oldid=12411582
ideographic space is not trimmed by mediawiki on save (not for save, but similiar T22076)
Some seems to need a non-breaking space as delimeter, maybe only the ascii whitespaces should be checked by banana