Page MenuHomePhabricator

Dark mode - popupWidget displayed blank
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • On any beta wiki where Side menus (Tools and Appearance) are present, click to move them to the sidebar
  • Then click on 'Hide' to hide those menus
  • When you click on 'Hide', the menus are hidden and the popup message appears:
Screen Shot 2024-05-13 at 9.28.49 AM.png (198×972 px, 31 KB)
Screen Shot 2024-05-13 at 3.27.20 PM.png (358×788 px, 44 KB)
  • Switch to Dark mode via Appearance menu

What happens?:
The following element won't display any content:
<div class="oo-ui-popupWidget-popup"><div class="oo-ui-clippableElement-clippable oo-ui-popupWidget-body oo-ui-popupWidget-body-padded" style=""><p>The tools menu has moved here.</p></div></div>

Screen Shot 2024-05-13 at 3.25.38 PM.png (432×986 px, 33 KB)
Screen Shot 2024-05-13 at 3.26.01 PM.png (470×742 px, 36 KB)

What should have happened instead?:
The content of the popups should be readable (black text on white background is OK)

Software version :

  • checked on beta

Signoff criteria

  • Create ticket for making this notice appear in dark mode

Requirement

Ensure that the popupWidget content is visible and readable in dark mode.

BDD

gherkin
Feature: PopupWidget Content Visibility in Dark Mode

  Scenario: Ensure PopupWidget content is visible in dark mode
    Given the user has enabled dark mode
    When the user views the popupWidget
    Then the content of the popupWidget should be visible and readable

Test Steps

Test Case 1: Ensure PopupWidget Content is Visible in Dark Mode

  1. On any beta wiki where side menus (Tools and Appearance) are present, switch to dark mode via the Appearance menu.
  2. Click to move the side menus to the sidebar.
  3. Click on 'Hide' to hide those menus.
  4. AC1: Confirm that the content of the popupWidget is visible and readable.

QA Results - Beta

ACStatusDetails
1T364798#9831927

Event Timeline

ovasileva set the point value for this task to 1.

Change #1034927 had a related patch set uploaded (by Mabualruz; author: Mabualruz):

[mediawiki/skins/Vector@master] fix(vector): Set popup notification color to inverted

https://gerrit.wikimedia.org/r/1034927

Jdlrobson added a subscriber: Quiddity.
Jdlrobson added a subscriber: ovasileva.

Does it make sense to work on this right now @ovasileva it seems like this would cause work for us after T363849..?

Change #1034927 merged by jenkins-bot:

[mediawiki/skins/Vector@master] fix(vector): Set popup notification color to inverted

https://gerrit.wikimedia.org/r/1034927

The issue's been checked on beta - works as expected:

Screen Shot 2024-05-24 at 11.58.21 AM.png (328×978 px, 44 KB)
Screen Shot 2024-05-24 at 11.59.27 AM.png (410×998 px, 41 KB)

@Edtadros - does the task need to be checked anywhere else? testwiki doesn't have the Dark mode option in the Appearance menu and I didn't see the option on mobile.

Test Result - Beta

Status: ✅ PASS
Environment: Beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Ensure PopupWidget Content is Visible in Dark Mode

  1. On any beta wiki where side menus (Tools and Appearance) are present, switch to dark mode via the Appearance menu.
  2. Click to move the side menus to the sidebar.
  3. Click on 'Hide' to hide those menus.
  4. AC1: Confirm that the content of the popupWidget is visible and readable.

screenshot 89.mov.gif (724×1 px, 449 KB)

screenshot 90.mov.gif (724×1 px, 469 KB)

screenshot 91.mov.gif (724×1 px, 493 KB)

Jdlrobson claimed this task.