Page MenuHomePhabricator

Decide on the login flow in MediaWiki under SUL3
Closed, ResolvedPublic

Description

T362706: Permit displaying the login / signup page in a popup or iframe adds the ability to do the login / signup flow inside a popup window. One use case for this is logging in via a remote identity provider (another wiki, or something else entirely like Google or Facebook). In such a setup, clicking on the Login or Signup link should open a popup (on desktop; maybe not on mobile). It's not obvious though what "in such a setup" should mean, exactly. A configuration setting? A hook entry point for extensions? (Maybe one that already exists - could SkinTemplateNavigation::Universal be used for this?) AuthManager detecting that the only primary provider is a remote one?

Related Objects

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
This comment was removed by Tgr.
matmarex subscribed.

It's not obvious though what "in such a setup" should mean, exactly. A configuration setting? A hook entry point for extensions? AuthManager detecting that the only primary provider is a remote one?

It's not obvious to me either. I suggest we don't overthink it and just add a config setting, defaulting to being turned off. If we get a better feel for this in the future, we can change that to a dynamic default.

Change #1032585 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] [WIP] Allow using popup for the normal login link

https://gerrit.wikimedia.org/r/1032585

JTweed-WMF subscribed.

From what I can tell, the patch to implement this has been reverted. It's not something that we want to do right now, having gone for redirects rather than a popup, so I think it can be closed.

JTweed-WMF changed the task status from Declined to Resolved.Oct 28 2024, 5:23 PM