Page MenuHomePhabricator

Add terms of use checkbox to the form
Open, Stalled, LowPublic

Description

Add a 'terms of use' checkbox above the form submit button, linking to https://foundation.wikimedia.org/wiki/Policy:Terms_of_Use

The form should not be able to be submitted without the checkbox being checked.

There should be a horizontal rule with a bit of margin above it, above the checkbox.

Design file https://www.figma.com/file/JcTMFwbEJPpCKBiZ16Jkel/Future-of-the-Wishlist?type=design&node-id=1368%3A14631&mode=design&t=82UpjjgYE5jXp3L9-1

Details

TitleReferenceAuthorSource BranchDest Branch
Remove Terms of Use checkboxrepos/commtech/wishlist-intake!34samwilsonrm-termsofuse-checkboxmain
Adjust terms-of-use field vertical spacingrepos/commtech/wishlist-intake!29samwilsontermsofuse-T364959-spacingmain
Add 'Terms of Use' field to intake formrepos/commtech/wishlist-intake!27samwilsontermsofuse-T364959main
Customize query in GitLab

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Samwilson added a subscriber: JSengupta-WMF.

@JSengupta-WMF Is the part here about disabling the submit button correct?

@Samwilson yes. I have updated the button state to disabled in design when the checkbox is not selected.

@JSengupta-WMF Terrific, thanks. Done.

Also, I'm afraid I'm still figuring out how to measure things properly in Figma, so am I right with the spacing of the items here? The gap above the line is 300 and below is 100? Like this:

Wikimedia-Foundation-wish-submission.png (379×1 px, 42 KB)

I adjusted it. You can use 200 and 100 spacing.

I'm not sure why, but the checkbox doesn't always work for me. Sometimes the "Submit wish" button stays disabled.

We should remove the checkbox, anyway, because:

  • we don't do this anywhere else in the wikiverse
  • it could dissuade folks from creating wishes
  • it makes testing the intake form slower

Instead, it should do like elsewhere and say i.e. "By submitting, you agree…" and perhaps more importantly, specify the license. We can use what DiscussionTools uses, as that message is tailored to an internal thing (replying on talk pages) as opposed to creating articles or editing in general:

By clicking "Submit wish", you agree to our Terms of Use and agree to irrevocably release your text under CC BY-SA 4.0 License and GFDL.

Hey @Samwilson I don't think we need to use a checkbox, but probably need text dislaimer with the T&S. Can we pull this out of review and into the backlog until I have a response from legal?

I'm not sure why, but the checkbox doesn't always work for me. Sometimes the "Submit wish" button stays disabled.

The submit button is only enabled when the title, description, and checkbox are filled in. That might be what you were seeing. The description doesn't yet have an error state, but the title gets a red border (we need to add more messages for these states).

Can we pull this out of review and into the backlog until I have a response from legal?

It's done and merged now, sorry! But easy to remove. I'll do that, and then stall this until you've got confirmation. I think the text that @MusikAnimal posted above sounds good.

Note that the usual edit message on Meta is wikimedia-copyrightwarning:

By saving changes, you agree to the Terms of Use, and you irrevocably agree to release your contribution under the CC BY-SA 4.0 License and the GFDL. You agree that a hyperlink or URL is sufficient attribution under the Creative Commons license.

We could just use that?

Checkbox has been removed and copy updated.

What about licensing? All other editors specify this.

Samwilson changed the task status from Open to Stalled.Thu, May 23, 11:20 AM
Samwilson removed Samwilson as the assignee of this task.

After T365471 is done it'll be easy to use wikimedia-copyrightwarning.