Page MenuHomePhabricator

Add 'Affected users' field to the form
Closed, ResolvedPublic

Description

User story

Given that I am filling out the wishlist form, when I am creating a wish, I want to share who the primary affected users are, so that the community tech team and other stakeholders can best understand a user's struggle, and I increase my chances of my wish being incorporated in a focus area.

Acceptance criteria

  • Add a one-line free text TextInput field to the intake form, above the 'Phabricator tasks' field.
  • The field contents should be saved to the |audience= template parameter.
  • The text field should have a maximum 300 characters and a minimum 3 characters.

Design

  • Label: Primary affected users
  • Help text: Describe which user group and situation this will affect the most
  • Error message: Please enter a value for this field (between 3 and 300 characters).

Figma file

Related tasks

QA

QA Results - PatchDemo

ACStatusDetails
1โœ…T364960#9822985

Details

TitleReferenceAuthorSource BranchDest Branch
Add error message to Audience fieldrepos/commtech/wishlist-intake!46samwilsonaudience-error-msgmain
Add 'audience' fieldrepos/commtech/wishlist-intake!31samwilsonaudience-sectionmain
Customize query in GitLab

Event Timeline

Restricted Application added a subscriber: Aklapper. ยท View Herald Transcript

@Samwilson Submit was enabled and processed even though I was under/over the character limit while logged in. When I was logged out, the Submit button was enabled but I wasn't able to process when I was under or over the character limit.
What is the expected behavior supposed to be for logging out and logging in? Shouldn't I get some kind of warning if I'm over or under the character limit along with the Submit button staying disabled?

Status: โŒ FAIL
Environment: Patch Demo
OS: macOS Sonoma 14.4.1
Browser: Chrome 124
Skins. N/a
Device: MBA M2
Emulated Device:: n/a
Test Links:
https://patchdemo.wmflabs.org/wikis/daa3db7f2e/wiki/Community_Requests/Intake

โŒAC1: https://phabricator.wikimedia.org/T364960

Logged StatusUnder 3 charactersOver 300 characters
Logged ON
Logged OUT

What is the expected behavior supposed to be for logging out and logging in? Shouldn't I get some kind of warning if I'm over or under the character limit along with the Submit button staying disabled?

@GMikesell-WMF Thanks! I totally overlooked the length requirements. Added now in the above patch (ready for review).

As for being logged in or not, there's no special handling for either yet (I'm assuming we'll do that in T363221, so I think it's out of scope for this task).

@Samwilson Help text and error message works as designed as seen in the videos below. I will move this to Done. Thanks for all your work!

Status: โœ… PASS
Environment: Patch Demo
OS: macOS Sonoma 14.5
Browser: Chrome 1245
Skins. N/a
Device: MBA M2
Emulated Device:: n/a
Test Links:
https://patchdemo.wmflabs.org/wikis/daa3db7f2e/wiki/Community_Requests/Intake

โœ…AC1: https://phabricator.wikimedia.org/T364960

Under 3 charactersOver 300 characters