Page MenuHomePhabricator
Create Task
Maniphest T365043

[S] Apple Pay Form - make maximum proportional to USD min/max
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

The AppsDonateConfig only sets a maximum for USD. For other currencies, we need to calculate the maximum ourselves against the USD min / max proportion.

Background: https://wikimedia.slack.com/archives/C05Q15P657F/p1715623799807529

Other currencies have no min and max set. Users can check out with smaller or larger donations that equivalent USD amounts.

Due date: before Big English 2024

Related Objects
Search...

Event Timeline

Tsevener created this task.May 15 2024, 4:07 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 15 2024, 4:07 PM
Tsevener renamed this task from Apple Pay Form - make maximum proportional to USD min/max to [S] Apple Pay Form - make maximum proportional to USD min/max.May 15 2024, 4:09 PM
HNordeenWMF triaged this task as Low priority.May 21 2024, 8:18 PM
HNordeenWMF moved this task from Needs Triage to Bug Backlog on the Wikipedia-iOS-App-Backlog board.
HNordeenWMF added a parent task: T352725: [XL] Fundraising cleanup 2023-2024.
HNordeenWMF edited parent tasks, added: T369525: iOS Fundraising Improvements [2024-2025]; removed: T352725: [XL] Fundraising cleanup 2023-2024.Jul 8 2024, 3:46 PM
HNordeenWMF mentioned this in T369525: iOS Fundraising Improvements [2024-2025].
HNordeenWMF updated the task description. (Show Details)Aug 27 2024, 8:52 PM
HNordeenWMF raised the priority of this task from Low to Medium.Aug 27 2024, 8:56 PM
HNordeenWMF edited projects, added Wikipedia-iOS-App-Backlog (iOS Release FY2024-25); removed Wikipedia-iOS-App-Backlog.
HNordeenWMF updated the task description. (Show Details)
HNordeenWMF moved this task from Tasks from Product Backlog to Needs Eng Sync or Estimation on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Aug 27 2024, 9:00 PM
Seddon set the point value for this task to 1.Aug 29 2024, 12:32 PM
Seddon moved this task from Needs Eng Sync or Estimation to Current Sprint Work on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Aug 29 2024, 12:54 PM
Seddon moved this task from Current Sprint Work to Ready for future sprints on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Aug 29 2024, 5:55 PM
Seddon moved this task from Ready for future sprints to Current Sprint Work on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Aug 29 2024, 5:59 PM
Mazevedo claimed this task.Aug 30 2024, 5:55 PM
Mazevedo moved this task from Current Sprint Work to Doing on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.
GOlson-WMF moved this task from Doing to Needs Code Review on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Aug 30 2024, 6:07 PM
GOlson-WMF moved this task from Needs Code Review to Doing on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.
GitHubPRBot added a comment.Sep 2 2024, 6:12 PM

mazevedofs opened https://github.com/wikimedia/wikipedia-ios/pull/4955

Mazevedo moved this task from Doing to Needs Code Review on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Sep 2 2024, 6:15 PM
GitHubPRBot added a comment.Sep 9 2024, 6:00 PM

mazevedofs closed https://github.com/wikimedia/wikipedia-ios/pull/4955

Tsevener moved this task from Needs Code Review to Waiting for Build on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Sep 9 2024, 7:03 PM
Mazevedo removed Mazevedo as the assignee of this task.Sep 11 2024, 1:56 PM
Mazevedo moved this task from Waiting for Build to Needs QA signoff on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.
Mazevedo subscribed.
Tsevener mentioned this in T374666: Release `7.5.9`.Sep 13 2024, 8:50 PM
Tsevener moved this task from Needs QA signoff to Doing on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Sep 17 2024, 8:42 PM
GitHubPRBot added a comment.Sep 17 2024, 11:27 PM

tonisevener opened https://github.com/wikimedia/wikipedia-ios/pull/4973

Tsevener moved this task from Doing to Needs Code Review on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Sep 17 2024, 11:27 PM
GitHubPRBot added a comment.Sep 18 2024, 12:47 PM

mazevedofs closed https://github.com/wikimedia/wikipedia-ios/pull/4973

Mazevedo moved this task from Needs Code Review to Waiting for Build on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Sep 18 2024, 12:53 PM
Mazevedo moved this task from Waiting for Build to Needs QA signoff on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Sep 18 2024, 1:54 PM

Can be retested in 7.5.9 (4067)

Tsevener moved this task from Needs QA signoff to Needs Code Review on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Sep 18 2024, 4:37 PM
Tsevener moved this task from Needs Code Review to Waiting for Build on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Sep 18 2024, 8:06 PM
Tsevener moved this task from Waiting for Build to Needs QA signoff on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Sep 18 2024, 9:21 PM
ABorbaWMF moved this task from Needs QA signoff to Ready for PM Signoff on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Sep 20 2024, 3:24 PM
ABorbaWMF subscribed.

Looks good to me on 7.5.9 (4078)

HNordeenWMF moved this task from Ready for PM Signoff to Ready for Release on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Sep 20 2024, 6:06 PM
HNordeenWMF closed this task as Resolved.Sep 23 2024, 3:43 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits