Page MenuHomePhabricator

Use central proxy as WDQS proxy as well, remove WDQS proxy
Closed, ResolvedPublicSpike

Description

Current Situation:

  • there is a service that does some http proxy-ing work in front of wdqs
  • it is called wdqs proxy
  • it is based on nginx
  • we added traefik as a central proxy to deployment kit
  • traefik sits in front of all the other services

Goal:

  • Understand whether wdqs proxy as a product delivers any value
  • Remove WDQS proxy and let traefik take over that task for deployment kit

Acceptance Criteria:

  • understood all the work wdqs-proxy is doing
  • understood the value it delivers
  • decide whether we want support this outside of deployment kit
  • decide next steps / (if applies) create tickets to implement the solution

[optional] Notes:

  • depending how the decision is this will probably be a breaking change and needs to trigger a deployment kit major version bump
  • another alternative could also be to move all proxies to nginx instead of traefik
  • underlying motivation is reducing complexity in our stack

[optional] Open Questions:

Event Timeline

Wholeheartedly agree. Here are a few notes about what I think it would take to deprecate WDQS-proxy for Traefik proxy buffering instead:

  1. Currently we don't publish the underlying WDQS service to Traefik / outside of the Docker network. To utilise Traefik as the buffering proxy server instead of the special WDQS-proxy image we need to expose WDQS on a public URL and set the WDQS_HOST on the WDQS-frontend service to point to that.
  1. Reference the nginx proxy buffering settings in build/WDQS-proxy/wdqs.template, and set related Traefik labels on the WDQS service to approximately match those settings where there are not an already suitable default for Traefik. One helpful reference for research on this part: https://github.com/traefik/traefik/issues/4580 for translating build/WDQS-proxy/wdqs.template (nginx) to Traefik settings
Restricted Application changed the subtype of this task from "Task" to "Spike". · View Herald TranscriptAug 6 2024, 2:37 PM
lojo_wmde changed the task status from Open to In Progress.Sep 17 2024, 9:28 AM
lojo_wmde claimed this task.
lojo_wmde moved this task from Sprint Backlog to Doing on the Wikibase Suite Team (Sprint-∞) board.

I downside of this would be, that situations like this https://github.com/wmde/wikibase-release-pipeline/issues/760#issuecomment-2358441630 become more complicated for the user.