Page MenuHomePhabricator

Design QA for QuickSurveys
Closed, ResolvedPublic

Assigned To
Authored By
KColeman-WMF
May 16 2024, 1:35 PM
Referenced Files
F54522142: surveys-qa05.png
Tue, May 28, 10:12 AM
F54522139: surveys-qa04.png
Tue, May 28, 10:12 AM
F53485729: surveys-qa03.png
May 16 2024, 1:35 PM
F53485696: surveys-qa01.png
May 16 2024, 1:35 PM
F53485852: surveys-design-ref.png
May 16 2024, 1:35 PM
F53485652: surveys-qa02.png
May 16 2024, 1:35 PM

Description

Aim

Review the QuickSurveys UI using this demo

Design QA
Changes to be madeBuildDesign
Submit button should be Primary progressive (i.e. change weight to primary so button is blue)
surveys-qa02.png (349×509 px, 30 KB)
surveys-design-ref.png (408×308 px, 21 KB)
Add missing divider above survey footer (color gray 300)
surveys-qa01.png (349×509 px, 28 KB)
surveys-design-ref.png (408×308 px, 21 KB)
Add copy: "To stop QuickSurveys from appearing, change your preferences" to the footer, so there's always a link to stop surveys.
surveys-qa03.png (349×509 px, 29 KB)
surveys-design-ref.png (408×308 px, 21 KB)
Acceptance criteria
  • Submit button is primary progressive
  • Divider separates form fields from footer text
  • Footer contains link to stop displaying surveys in Preferences

Event Timeline

Amdrel changed the task status from Open to In Progress.Mon, May 20, 9:28 PM
Amdrel claimed this task.

Change #1034189 had a related patch set uploaded (by Amdrel; author: Amdrel):

[mediawiki/extensions/QuickSurveys@master] Apply design feedback and preference disclaimer

https://gerrit.wikimedia.org/r/1034189

Test wiki created on Patch demo by SimoneThisDot using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/42ce80c18c/w

Test wiki created on Patch demo by SimoneThisDot using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/a44d09140e/w

Test wiki on Patch demo by SimoneThisDot using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/42ce80c18c/w/

Thanks for making the changes!

@SimoneThisDot I have spotted two small remaining things:

  • Space between buttons needs increasing (see image below)
  • Divider is missing on final screen

surveys-qa04.png (431×509 px, 38 KB)

surveys-qa05.png (431×509 px, 46 KB)

Change #1037233 had a related patch set uploaded (by Simone Cuomo; author: Simone Cuomo):

[mediawiki/extensions/QuickSurveys@community-safety] Improve capability of QuickSurvey

https://gerrit.wikimedia.org/r/1037233

Change #1037233 merged by jenkins-bot:

[mediawiki/extensions/QuickSurveys@community-safety] Improve capability of QuickSurvey

https://gerrit.wikimedia.org/r/1037233

Change #1034189 abandoned by Amdrel:

[mediawiki/extensions/QuickSurveys@master] Apply design feedback and preference disclaimer

Reason:

This patch has been cherry-picked and squashed into the following branch: https://gerrit.wikimedia.org/r/q/project:mediawiki/extensions/QuickSurveys+branch:community-safety+status:merged

https://gerrit.wikimedia.org/r/1034189

Test wiki on Patch demo by SimoneThisDot using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/a44d09140e/w/

Test wiki created on Patch demo by SimoneThisDot using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/1f5a200338/w

Test wiki on Patch demo by SimoneThisDot using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/1f5a200338/w/

Test wiki created on Patch demo by Jdlrobson using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/e606e11883/w

Test wiki created on Patch demo by SimoneThisDot using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/0d85df7998/w

Test wiki on Patch demo by Amdrel using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/80286dd93e/w/

Test wiki on Patch demo by Amdrel using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/7ed125994c/w/

Test wiki on Patch demo by SimoneThisDot using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/0d85df7998/w/