Page MenuHomePhabricator

The ReturnTo query parameter of Special:UserLogin skips array-valued parameters
Closed, ResolvedPublic


Author: it_is_me_here

See If you aren't logged in on a particular browser, then you paste in a Wikimedia URL that is only accessible to Admins/whatever and that includes doing an action (e.g. deleting) on multiple items (log entries, old versions of pages, etc.), and then you log in and click "return to X", you get an error message. An example of such a URL is The error message you get when trying to return to the page is:

"Invalid target revision: You have either not specified a target revision(s) to perform this function, the specified revision does not exist, or you are attempting to hide the current revision.
Return to Main Page."

If you are already logged in, pasting in the URL works fine.

Version: 1.19
Severity: normal



Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 12:13 AM
bzimport set Reference to bz34521.
bzimport added a subscriber: Unknown Object (MLST).

it_is_me_here wrote:

I've now found another example of this. If you are editing the section of a page whilst logged out (e.g. []), click the "logged in" link from [], then the URL you are led to is [] and, sure enough, you will be taken back, upon logging in, to [] (i.e. without the section-edit bit).

Benny investigated this bug and tracked it down to a bug in WebRequest::getValues(). This function claims not to apply any transformations to its input, but that's a lie, it calls getVal() which strips out arrays.

Fixed in r113545.